cosmos-sdk/x/distribution
Riccardo Montagnin 90157fc5f4
feat: Improve withdraw-all-rewards UX (#9781)
## Description
Related to #9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). 

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-07-28 11:58:32 +00:00
..
client feat: Improve withdraw-all-rewards UX (#9781) 2021-07-28 11:58:32 +00:00
keeper fix: WithdrawRewards event emit value when no rewards (#9599) 2021-07-05 18:28:25 +00:00
migrations fix: check store keys length before accessing (#9639) 2021-07-08 13:29:12 +02:00
simulation refactor!: Remove `clientCtx.JSONCodec` and rename `EncodingConfig.Marshaler` to `Codec` (#9521) 2021-07-01 08:52:38 +00:00
spec chore: add markdownlint to lint commands (#9353) 2021-05-27 15:31:04 +00:00
types fix: check store keys length before accessing (#9639) 2021-07-08 13:29:12 +02:00
abci.go Merge PR #6761: telemetry: use UTC() in wrappers 2020-07-17 15:33:50 -04:00
doc.go Merge PR #5417: Update distribution module doc 2019-12-17 13:59:16 -05:00
handler.go feat!: remove legacy handler (#9650) 2021-07-19 14:49:42 +00:00
module.go feat!: remove legacy handler (#9650) 2021-07-19 14:49:42 +00:00
module_test.go tendermint: update to rc3 (#6892) 2020-08-14 13:58:53 -04:00
proposal_handler_test.go refactor: Move simapp FundAccount and FundModuleAccount to testutil (#9427) 2021-06-29 10:23:13 +00:00