certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
cosmos-sdk/client/keys
History
Emmanuel T Odeke d0f64dff2c
perf: avoid unnecessary byteslice->string before fmt %s verb (#10364) 
fmt.Printf or fmt.Sprintf already know how to convert a
byteslice into a string when building the output; we shouldn't
incur the unnecessary string(byteslice) conversion.
Using Bencher, we can see improvements such as
https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe
which in independent experiments show:

* time/op (ns/op)
FormatIt-8	1.2µs ± 2%	1.1µs ± 10%	-11.77%	(p=0.000 n=10+9)

* speed (MB/s)
FormatIt-8	0.71GB/s ± 2%	0.80GB/s ± 9%	+13.59%	(p=0.000 n=10+9)

* allocs/op (B/op)
FormatIt-8	2.0kB ± 0%	1.1kB ± 0%	-45.62%	(p=0.000 n=10+10)

* allocs/op (count/op)
FormatIt-8	11 ± 0%	        9.0 ± 0%	-18.18%	(p=0.000 n=10+10)

Fixes #10363
 		2021-10-14 08:53:38 +00:00
..
testdata/keys/keys.db crypto/keyring: fix offline keys migration (#8639) 2021-03-01 12:41:49 +00:00
add.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
add_ledger_test.go perf: avoid unnecessary byteslice->string before fmt %s verb (#10364) 2021-10-14 08:53:38 +00:00
add_test.go perf: avoid unnecessary byteslice->string before fmt %s verb (#10364) 2021-10-14 08:53:38 +00:00
codec.go Remove bech32 PubKey support (#7477) 2021-03-25 14:53:22 +00:00
codec_test.go Remove bech32 PubKey support (#7477) 2021-03-25 14:53:22 +00:00
delete.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
delete_test.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
export.go fix: file keyring fails to add/import/export keys when input is not stdin (fix #9566) (#9821) 2021-08-09 10:35:01 +00:00
export_test.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
import.go refactor: move from io/ioutil to io and os package (#10341) 2021-10-13 07:38:22 +00:00
import_test.go refactor: move from io/ioutil to io and os package (#10341) 2021-10-13 07:38:22 +00:00
list.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
list_test.go fix: --home flag parsing (#10226) 2021-09-30 12:01:56 +00:00
migrate.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
migrate_test.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
mnemonic.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
mnemonic_test.go testutil: add ApplyMockIODiscardOutErr, simplify existing functions (#6665) 2020-07-10 08:55:48 +02:00
parse.go refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations (#9780) 2021-09-24 14:37:34 +00:00
parse_test.go build(deps): bump github.com/spf13/viper from 1.6.3 to 1.7.0 (#6183) 2020-05-11 10:22:36 +02:00
rename.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
rename_test.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
root.go feat!: key rename cli command (#9601) 2021-07-19 15:20:27 +00:00
root_test.go feat!: key rename cli command (#9601) 2021-07-19 15:20:27 +00:00
show.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
show_test.go build(deps): Use self-maintained btcutil (#10082) (#10201) 2021-09-30 13:25:44 +00:00
types.go refactor!: Keyring migration (#9695) 2021-09-20 12:02:15 +00:00
types_test.go Replace defer with testing.T.Cleanup() (#5732) 2020-03-02 00:16:23 +00:00
utils.go refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations (#9780) 2021-09-24 14:37:34 +00:00