Emmanuel T Odeke abe3e0c6da perf: all: remove unnecessary allocations from strings.Builder.WriteString(fmt.Sprintf(...)) (#13230) ... This change removes a code pattern that I noticed while on a late night audit of cosmovisor in which strings.Builder.WriteString(fmt.Sprintf(...)) calls were being made, yet that's counterproductive to using fmt.Fprintf which will check whether the writer implements .WriteString and then avoids the need to firstly build a string using fmt.Sprintf. The performance wins from this change transcend all dimensions as exhibited below: ```shell $ benchstat before.txt after.txt name old time/op new time/op delta DetailString-8 5.48µs ±23% 4.40µs ±11% -19.79% (p=0.000 n=20+17) name old alloc/op new alloc/op delta DetailString-8 2.63kB ± 0% 2.11kB ± 0% -19.76% (p=0.000 n=20+20) name old allocs/op new allocs/op delta DetailString-8 63.0 ± 0% 50.0 ± 0% -20.63% (p=0.000 n=20+20) ``` Fixes #13229		2022-09-09 21:57:46 +00:00
..
block.go	Fixed typo in block module help output (#10926)	2022-01-11 23:38:44 +01:00
rpc_test.go	chore: remove norace tag (#12738)	2022-07-27 14:44:23 +00:00
status.go	chore: downgrade to tendermint `v0.34.x` (#12958)	2022-08-20 02:33:07 +02:00
validators.go	perf: all: remove unnecessary allocations from strings.Builder.WriteString(fmt.Sprintf(...)) (#13230)	2022-09-09 21:57:46 +00:00