cosmos-sdk/x/auth
Zaki Manian f65b6c9363
feat: Error on blank chain-id in multisign command (#9593)
Error on `tx multisign` command if chain-id is blank. This is a common cause of signature verification failures when combining signatures and the error message doesn't provide any clues to this common cause.

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-06-29 08:10:04 +00:00
..
ante SDK Core Audit - simapp updates (#9315) 2021-05-17 15:42:44 +00:00
atlas chore: add markdownlint to lint commands (#9353) 2021-05-27 15:31:04 +00:00
client feat: Error on blank chain-id in multisign command (#9593) 2021-06-29 08:10:04 +00:00
keeper Update doc for IterateAccounts x/auth keeper meethod (#9285) 2021-05-11 21:13:31 +00:00
legacy refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
signing SDK Core Audit - simapp updates (#9315) 2021-05-17 15:42:44 +00:00
simulation codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
spec chore: add markdownlint to lint commands (#9353) 2021-05-27 15:31:04 +00:00
testutil cosmos-reflection: extend to support writing by reflection clients (#8965) 2021-04-07 00:33:54 +01:00
tx refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
types codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
vesting refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
genesis.go Enable proto JSON for genesis (#7000) 2020-08-11 14:22:30 +00:00
module.go codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
module_test.go tendermint: update to rc3 (#6892) 2020-08-14 13:58:53 -04:00