cosmos-sdk/x/gov/keeper/msg_server_test.go

1085 lines
26 KiB
Go

package keeper_test
import (
"strings"
"time"
simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims"
"github.com/cosmos/cosmos-sdk/testutil/testdata"
sdk "github.com/cosmos/cosmos-sdk/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
"github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
)
func (suite *KeeperTestSuite) TestSubmitProposalReq() {
suite.reset()
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
initialDeposit := coins
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
cases := map[string]struct {
preRun func() (*v1.MsgSubmitProposal, error)
expErr bool
expErrMsg string
}{
"metadata too long": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
initialDeposit,
proposer.String(),
strings.Repeat("1", 300),
)
},
expErr: true,
expErrMsg: "metadata too long",
},
"many signers": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{testdata.NewTestMsg(govAcct, addrs[0])},
initialDeposit,
proposer.String(),
"",
)
},
expErr: true,
expErrMsg: "expected gov account as only signer for proposal message",
},
"signer isn't gov account": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{testdata.NewTestMsg(addrs[0])},
initialDeposit,
proposer.String(),
"",
)
},
expErr: true,
expErrMsg: "expected gov account as only signer for proposal message",
},
"invalid msg handler": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{testdata.NewTestMsg(govAcct)},
initialDeposit,
proposer.String(),
"",
)
},
expErr: true,
expErrMsg: "proposal message not recognized by router",
},
"all good": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
initialDeposit,
proposer.String(),
"",
)
},
expErr: false,
},
"all good with min deposit": {
preRun: func() (*v1.MsgSubmitProposal, error) {
return v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
},
expErr: false,
},
}
for name, tc := range cases {
suite.Run(name, func() {
msg, err := tc.preRun()
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
}
})
}
}
func (suite *KeeperTestSuite) TestVoteReq() {
suite.reset()
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
proposalId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
expErr bool
expErrMsg string
option v1.VoteOption
metadata string
voter sdk.AccAddress
}{
"vote on inactive proposal": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: "",
expErr: true,
expErrMsg: "inactive proposal",
},
"metadata too long": {
preRun: func() uint64 {
return proposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: strings.Repeat("a", 300),
expErr: true,
expErrMsg: "metadata too long",
},
"voter error": {
preRun: func() uint64 {
return proposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: sdk.AccAddress(strings.Repeat("a", 300)),
metadata: "",
expErr: true,
expErrMsg: "address max length is 255",
},
"all good": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: "",
expErr: false,
},
}
for name, tc := range cases {
suite.Run(name, func() {
pId := tc.preRun()
voteReq := v1.NewMsgVote(tc.voter, pId, tc.option, tc.metadata)
_, err := suite.msgSrvr.Vote(suite.ctx, voteReq)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestVoteWeightedReq() {
suite.reset()
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
proposalId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
vote *v1.MsgVote
expErr bool
expErrMsg string
option v1.VoteOption
metadata string
voter sdk.AccAddress
}{
"vote on inactive proposal": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: "",
expErr: true,
expErrMsg: "inactive proposal",
},
"metadata too long": {
preRun: func() uint64 {
return proposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: strings.Repeat("a", 300),
expErr: true,
expErrMsg: "metadata too long",
},
"voter error": {
preRun: func() uint64 {
return proposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: sdk.AccAddress(strings.Repeat("a", 300)),
metadata: "",
expErr: true,
expErrMsg: "address max length is 255",
},
"all good": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1.VoteOption_VOTE_OPTION_YES,
voter: proposer,
metadata: "",
expErr: false,
},
}
for name, tc := range cases {
suite.Run(name, func() {
pId := tc.preRun()
voteReq := v1.NewMsgVoteWeighted(tc.voter, pId, v1.NewNonSplitVoteOption(tc.option), tc.metadata)
_, err := suite.msgSrvr.VoteWeighted(suite.ctx, voteReq)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestDepositReq() {
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
pId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
expErr bool
proposalId uint64
depositor sdk.AccAddress
deposit sdk.Coins
options v1.WeightedVoteOptions
}{
"wrong proposal id": {
preRun: func() uint64 {
return 0
},
depositor: proposer,
deposit: coins,
expErr: true,
options: v1.NewNonSplitVoteOption(v1.OptionYes),
},
"all good": {
preRun: func() uint64 {
return pId
},
depositor: proposer,
deposit: minDeposit,
expErr: false,
options: v1.NewNonSplitVoteOption(v1.OptionYes),
},
}
for name, tc := range cases {
suite.Run(name, func() {
proposalId := tc.preRun()
depositReq := v1.NewMsgDeposit(tc.depositor, proposalId, tc.deposit)
_, err := suite.msgSrvr.Deposit(suite.ctx, depositReq)
if tc.expErr {
suite.Require().Error(err)
} else {
suite.Require().NoError(err)
}
})
}
}
// legacy msg server tests
func (suite *KeeperTestSuite) TestLegacyMsgSubmitProposal() {
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
initialDeposit := coins
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
cases := map[string]struct {
preRun func() (*v1beta1.MsgSubmitProposal, error)
expErr bool
}{
"all good": {
preRun: func() (*v1beta1.MsgSubmitProposal, error) {
return v1beta1.NewMsgSubmitProposal(
v1beta1.NewTextProposal("test", "I am test"),
initialDeposit,
proposer,
)
},
expErr: false,
},
"all good with min deposit": {
preRun: func() (*v1beta1.MsgSubmitProposal, error) {
return v1beta1.NewMsgSubmitProposal(
v1beta1.NewTextProposal("test", "I am test"),
minDeposit,
proposer,
)
},
expErr: false,
},
}
for name, c := range cases {
suite.Run(name, func() {
msg, err := c.preRun()
suite.Require().NoError(err)
res, err := suite.legacyMsgSrvr.SubmitProposal(suite.ctx, msg)
if c.expErr {
suite.Require().Error(err)
} else {
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
}
})
}
}
func (suite *KeeperTestSuite) TestLegacyMsgVote() {
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
proposalId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
expErr bool
expErrMsg string
option v1beta1.VoteOption
metadata string
voter sdk.AccAddress
}{
"vote on inactive proposal": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1beta1.OptionYes,
voter: proposer,
metadata: "",
expErr: true,
expErrMsg: "inactive proposal",
},
"voter error": {
preRun: func() uint64 {
return proposalId
},
option: v1beta1.OptionYes,
voter: sdk.AccAddress(strings.Repeat("a", 300)),
metadata: "",
expErr: true,
expErrMsg: "address max length is 255",
},
"all good": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1beta1.OptionYes,
voter: proposer,
metadata: "",
expErr: false,
},
}
for name, tc := range cases {
suite.Run(name, func() {
pId := tc.preRun()
voteReq := v1beta1.NewMsgVote(tc.voter, pId, tc.option)
_, err := suite.legacyMsgSrvr.Vote(suite.ctx, voteReq)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestLegacyVoteWeighted() {
suite.reset()
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
proposalId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
vote *v1beta1.MsgVote
expErr bool
expErrMsg string
option v1beta1.VoteOption
metadata string
voter sdk.AccAddress
}{
"vote on inactive proposal": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1beta1.OptionYes,
voter: proposer,
metadata: "",
expErr: true,
expErrMsg: "inactive proposal",
},
"voter error": {
preRun: func() uint64 {
return proposalId
},
option: v1beta1.OptionYes,
voter: sdk.AccAddress(strings.Repeat("a", 300)),
metadata: "",
expErr: true,
expErrMsg: "address max length is 255",
},
"all good": {
preRun: func() uint64 {
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
minDeposit,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
return res.ProposalId
},
option: v1beta1.OptionYes,
voter: proposer,
metadata: "",
expErr: false,
},
}
for name, tc := range cases {
suite.Run(name, func() {
pId := tc.preRun()
voteReq := v1beta1.NewMsgVoteWeighted(tc.voter, pId, v1beta1.NewNonSplitVoteOption(v1beta1.VoteOption(tc.option)))
_, err := suite.legacyMsgSrvr.VoteWeighted(suite.ctx, voteReq)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestLegacyMsgDeposit() {
govAcct := suite.govKeeper.GetGovernanceAccount(suite.ctx).GetAddress()
addrs := suite.addrs
proposer := addrs[0]
coins := sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(100)))
minDeposit := suite.govKeeper.GetParams(suite.ctx).MinDeposit
bankMsg := &banktypes.MsgSend{
FromAddress: govAcct.String(),
ToAddress: proposer.String(),
Amount: coins,
}
msg, err := v1.NewMsgSubmitProposal(
[]sdk.Msg{bankMsg},
coins,
proposer.String(),
"",
)
suite.Require().NoError(err)
res, err := suite.msgSrvr.SubmitProposal(suite.ctx, msg)
suite.Require().NoError(err)
suite.Require().NotNil(res.ProposalId)
pId := res.ProposalId
cases := map[string]struct {
preRun func() uint64
expErr bool
proposalId uint64
depositor sdk.AccAddress
deposit sdk.Coins
options v1beta1.WeightedVoteOptions
}{
"wrong proposal id": {
preRun: func() uint64 {
return 0
},
depositor: proposer,
deposit: coins,
expErr: true,
options: v1beta1.NewNonSplitVoteOption(v1beta1.OptionYes),
},
"all good": {
preRun: func() uint64 {
return pId
},
depositor: proposer,
deposit: minDeposit,
expErr: false,
options: v1beta1.NewNonSplitVoteOption(v1beta1.OptionYes),
},
}
for name, tc := range cases {
suite.Run(name, func() {
proposalId := tc.preRun()
depositReq := v1beta1.NewMsgDeposit(tc.depositor, proposalId, tc.deposit)
_, err := suite.legacyMsgSrvr.Deposit(suite.ctx, depositReq)
if tc.expErr {
suite.Require().Error(err)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestMsgUpdateParams() {
authority := suite.govKeeper.GetAuthority()
params := v1.DefaultParams()
testCases := []struct {
name string
input func() *v1.MsgUpdateParams
expErr bool
expErrMsg string
}{
{
name: "valid",
input: func() *v1.MsgUpdateParams {
return &v1.MsgUpdateParams{
Authority: authority,
Params: params,
}
},
expErr: false,
},
{
name: "invalid authority",
input: func() *v1.MsgUpdateParams {
return &v1.MsgUpdateParams{
Authority: "authority",
Params: params,
}
},
expErr: true,
expErrMsg: "invalid authority address",
},
{
name: "invalid min deposit",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.MinDeposit = nil
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "invalid minimum deposit",
},
{
name: "negative deposit",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.MinDeposit = sdk.Coins{{
Denom: sdk.DefaultBondDenom,
Amount: sdk.NewInt(-100),
}}
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "invalid minimum deposit",
},
{
name: "invalid max deposit period",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.MaxDepositPeriod = nil
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "maximum deposit period must not be nil",
},
{
name: "zero max deposit period",
input: func() *v1.MsgUpdateParams {
params1 := params
duration := time.Duration(0)
params1.MaxDepositPeriod = &duration
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "maximum deposit period must be positive",
},
{
name: "invalid quorum",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Quorum = "abc"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "invalid quorum string",
},
{
name: "negative quorum",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Quorum = "-0.1"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "quorom cannot be negative",
},
{
name: "quorum > 1",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Quorum = "2"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "quorom too large",
},
{
name: "invalid threshold",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Threshold = "abc"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "invalid threshold string",
},
{
name: "negative threshold",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Threshold = "-0.1"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "vote threshold must be positive",
},
{
name: "threshold > 1",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.Threshold = "2"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "vote threshold too large",
},
{
name: "invalid veto threshold",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.VetoThreshold = "abc"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "invalid vetoThreshold string",
},
{
name: "negative veto threshold",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.VetoThreshold = "-0.1"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "veto threshold must be positive",
},
{
name: "veto threshold > 1",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.VetoThreshold = "2"
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "veto threshold too large",
},
{
name: "invalid voting period",
input: func() *v1.MsgUpdateParams {
params1 := params
params1.VotingPeriod = nil
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "voting period must not be nil",
},
{
name: "zero voting period",
input: func() *v1.MsgUpdateParams {
params1 := params
duration := time.Duration(0)
params1.VotingPeriod = &duration
return &v1.MsgUpdateParams{
Authority: authority,
Params: params1,
}
},
expErr: true,
expErrMsg: "voting period must be positive",
},
}
for _, tc := range testCases {
tc := tc
suite.Run(tc.name, func() {
msg := tc.input()
exec := func(updateParams *v1.MsgUpdateParams) error {
if err := msg.ValidateBasic(); err != nil {
return err
}
if _, err := suite.msgSrvr.UpdateParams(suite.ctx, updateParams); err != nil {
return err
}
return nil
}
err := exec(msg)
if tc.expErr {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.expErrMsg)
} else {
suite.Require().NoError(err)
}
})
}
}
func (suite *KeeperTestSuite) TestSubmitProposal_InitialDeposit() {
const meetsDepositValue = baseDepositTestAmount * baseDepositTestPercent / 100
baseDepositRatioDec := sdk.NewDec(baseDepositTestPercent).Quo(sdk.NewDec(100))
testcases := map[string]struct {
minDeposit sdk.Coins
minInitialDepositRatio sdk.Dec
initialDeposit sdk.Coins
accountBalance sdk.Coins
expectError bool
}{
"meets initial deposit, enough balance - success": {
minDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(baseDepositTestAmount))),
minInitialDepositRatio: baseDepositRatioDec,
initialDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue))),
accountBalance: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue))),
},
"does not meet initial deposit, enough balance - error": {
minDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(baseDepositTestAmount))),
minInitialDepositRatio: baseDepositRatioDec,
initialDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue-1))),
accountBalance: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue))),
expectError: true,
},
"meets initial deposit, not enough balance - error": {
minDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(baseDepositTestAmount))),
minInitialDepositRatio: baseDepositRatioDec,
initialDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue))),
accountBalance: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue-1))),
expectError: true,
},
"does not meet initial deposit and not enough balance - error": {
minDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(baseDepositTestAmount))),
minInitialDepositRatio: baseDepositRatioDec,
initialDeposit: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue-1))),
accountBalance: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(meetsDepositValue-1))),
expectError: true,
},
}
for name, tc := range testcases {
suite.Run(name, func() {
// Setup
govKeeper, ctx := suite.govKeeper, suite.ctx
address := simtestutil.AddTestAddrs(suite.bankKeeper, suite.stakingKeeper, ctx, 1, tc.accountBalance[0].Amount)[0]
params := v1.DefaultParams()
params.MinDeposit = tc.minDeposit
params.MinInitialDepositRatio = tc.minInitialDepositRatio.String()
govKeeper.SetParams(ctx, params)
msg, err := v1.NewMsgSubmitProposal(TestProposal, tc.initialDeposit, address.String(), "test")
suite.Require().NoError(err)
// System under test
_, err = suite.msgSrvr.SubmitProposal(sdk.WrapSDKContext(ctx), msg)
// Assertions
if tc.expectError {
suite.Require().Error(err)
return
}
suite.Require().NoError(err)
})
}
}