81 lines
2.8 KiB
Go
81 lines
2.8 KiB
Go
|
package rpcserver_test
|
||
|
|
|
||
|
|
import (
|
||
|
|
"bytes"
|
||
|
|
"encoding/json"
|
||
|
|
"io/ioutil"
|
||
|
|
"net/http"
|
||
|
|
"net/http/httptest"
|
||
|
|
"strings"
|
||
|
|
"testing"
|
||
|
|
|
||
|
|
"github.com/stretchr/testify/assert"
|
||
|
|
|
||
|
|
rs "github.com/tendermint/tendermint/rpc/lib/server"
|
||
|
|
types "github.com/tendermint/tendermint/rpc/lib/types"
|
||
|
|
"github.com/tendermint/tmlibs/log"
|
||
|
|
)
|
||
|
|
|
||
|
|
// Ensure that nefarious/unintended inputs to `params`
|
||
|
|
// do not crash our RPC handlers.
|
||
|
|
// See Issue https://github.com/tendermint/tendermint/issues/708.
|
||
|
|
func TestRPCParams(t *testing.T) {
|
||
|
|
funcMap := map[string]*rs.RPCFunc{
|
||
|
|
"c": rs.NewRPCFunc(func(s string, i int) (string, error) { return "foo", nil }, "s,i"),
|
||
|
|
}
|
||
|
|
mux := http.NewServeMux()
|
||
|
|
buf := new(bytes.Buffer)
|
||
|
|
logger := log.NewTMLogger(buf)
|
||
|
|
rs.RegisterRPCFuncs(mux, funcMap, logger)
|
||
|
|
|
||
|
|
tests := []struct {
|
||
|
|
payload string
|
||
|
|
wantErr string
|
||
|
|
notification bool
|
||
|
|
}{
|
||
|
|
{`{"jsonrpc": "2.0"}`, "", true}, // The server SHOULD NOT respond to a notification according to JSONRPC Section 4.1.
|
||
|
|
{`{"jsonrpc": "2.0", "id": "0"}`, "Method not found", false},
|
||
|
|
{`{"jsonrpc": "2.0", "method": "y", "id": "0"}`, "Method not found", false},
|
||
|
|
{`{"jsonrpc": "2.0", "method": "c", "id": "0", "params": null}`, "", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": {}}`, "", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": a}`, "invalid character", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": ["a", 10]}`, "", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": ["a"]}`, "got 1", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": ["a", "b"]}`, "of type int", false},
|
||
|
|
{`{"method": "c", "id": "0", "params": [1, 1]}`, "of type string", false},
|
||
|
|
}
|
||
|
|
|
||
|
|
statusOK := func(code int) bool { return code >= 200 && code <= 299 }
|
||
|
|
|
||
|
|
for i, tt := range tests {
|
||
|
|
req, _ := http.NewRequest("POST", "http://localhost/", strings.NewReader(tt.payload))
|
||
|
|
rec := httptest.NewRecorder()
|
||
|
|
mux.ServeHTTP(rec, req)
|
||
|
|
res := rec.Result()
|
||
|
|
// Always expecting back a JSONRPCResponse
|
||
|
|
assert.True(t, statusOK(res.StatusCode), "#%d: should always return 2XX", i)
|
||
|
|
blob, err := ioutil.ReadAll(res.Body)
|
||
|
|
if err != nil {
|
||
|
|
t.Errorf("#%d: err reading body: %v", i, err)
|
||
|
|
continue
|
||
|
|
}
|
||
|
|
|
||
|
|
if tt.notification {
|
||
|
|
assert.Equal(t, len(blob), 0, "#%d: a notification SHOULD NOT be responded to by the server", i)
|
||
|
|
continue
|
||
|
|
}
|
||
|
|
|
||
|
|
recv := new(types.RPCResponse)
|
||
|
|
assert.Nil(t, json.Unmarshal(blob, recv), "#%d: expecting successful parsing of an RPCResponse:\nblob: %s", i, blob)
|
||
|
|
assert.NotEqual(t, recv, new(types.RPCResponse), "#%d: not expecting a blank RPCResponse", i)
|
||
|
|
|
||
|
|
if tt.wantErr == "" {
|
||
|
|
assert.Nil(t, recv.Error, "#%d: not expecting an error", i)
|
||
|
|
} else {
|
||
|
|
assert.False(t, statusOK(recv.Error.Code), "#%d: not expecting a 2XX success code", i)
|
||
|
|
// The wanted error is either in the message or the data
|
||
|
|
assert.Contains(t, recv.Error.Message+recv.Error.Data, tt.wantErr, "#%d: expected substring", i)
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|