From 0ae0155cba7b63b0e6bdb453348f211b74fd45af Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Sat, 10 Feb 2018 00:05:35 +0400 Subject: [PATCH] restore mempool memory leak tests --- mempool/reactor_test.go | 70 +++++++++++++++++++++-------------------- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/mempool/reactor_test.go b/mempool/reactor_test.go index 9f0b5b48..3cbc5748 100644 --- a/mempool/reactor_test.go +++ b/mempool/reactor_test.go @@ -6,6 +6,8 @@ import ( "testing" "time" + "github.com/fortytw2/leaktest" + "github.com/pkg/errors" "github.com/stretchr/testify/assert" "github.com/go-kit/kit/log/term" @@ -112,44 +114,44 @@ func TestReactorBroadcastTxMessage(t *testing.T) { waitForTxs(t, txs, reactors) } -// func TestBroadcastTxForPeerStopsWhenPeerStops(t *testing.T) { -// if testing.Short() { -// t.Skip("skipping test in short mode.") -// } +func TestBroadcastTxForPeerStopsWhenPeerStops(t *testing.T) { + if testing.Short() { + t.Skip("skipping test in short mode.") + } -// config := cfg.TestConfig() -// const N = 2 -// reactors := makeAndConnectMempoolReactors(config, N) -// defer func() { -// for _, r := range reactors { -// r.Stop() -// } -// }() + config := cfg.TestConfig() + const N = 2 + reactors := makeAndConnectMempoolReactors(config, N) + defer func() { + for _, r := range reactors { + r.Stop() + } + }() -// // stop peer -// sw := reactors[1].Switch -// sw.StopPeerForError(sw.Peers().List()[0], errors.New("some reason")) + // stop peer + sw := reactors[1].Switch + sw.StopPeerForError(sw.Peers().List()[0], errors.New("some reason")) -// // check that we are not leaking any go-routines -// // i.e. broadcastTxRoutine finishes when peer is stopped -// leaktest.CheckTimeout(t, 10*time.Second)() -// } + // check that we are not leaking any go-routines + // i.e. broadcastTxRoutine finishes when peer is stopped + leaktest.CheckTimeout(t, 10*time.Second)() +} -// func TestBroadcastTxForPeerStopsWhenReactorStops(t *testing.T) { -// if testing.Short() { -// t.Skip("skipping test in short mode.") -// } +func TestBroadcastTxForPeerStopsWhenReactorStops(t *testing.T) { + if testing.Short() { + t.Skip("skipping test in short mode.") + } -// config := cfg.TestConfig() -// const N = 2 -// reactors := makeAndConnectMempoolReactors(config, N) + config := cfg.TestConfig() + const N = 2 + reactors := makeAndConnectMempoolReactors(config, N) -// // stop reactors -// for _, r := range reactors { -// r.Stop() -// } + // stop reactors + for _, r := range reactors { + r.Stop() + } -// // check that we are not leaking any go-routines -// // i.e. broadcastTxRoutine finishes when reactor is stopped -// leaktest.CheckTimeout(t, 10*time.Second)() -// } + // check that we are not leaking any go-routines + // i.e. broadcastTxRoutine finishes when reactor is stopped + leaktest.CheckTimeout(t, 10*time.Second)() +}