linting: catch some errors
This commit is contained in:
parent
6a378d30f3
commit
36e96c5bf1
2
Makefile
2
Makefile
|
@ -58,6 +58,7 @@ metalinter: tools
|
|||
metalinter_test: tools
|
||||
@gometalinter --install
|
||||
gometalinter --vendor --deadline=600s --disable-all \
|
||||
--enable=aligncheck \
|
||||
--enable=deadcode \
|
||||
--enable=gas \
|
||||
--enable=goimports \
|
||||
|
@ -70,7 +71,6 @@ metalinter_test: tools
|
|||
--enable=varcheck \
|
||||
./...
|
||||
|
||||
#--enable=aligncheck \
|
||||
#--enable=dupl \
|
||||
#--enable=errcheck \
|
||||
#--enable=goconst \
|
||||
|
|
|
@ -41,7 +41,9 @@ func dialerFunc(addr string, timeout time.Duration) (net.Conn, error) {
|
|||
}
|
||||
|
||||
func (cli *grpcClient) OnStart() error {
|
||||
cli.BaseService.OnStart()
|
||||
if err := cli.BaseService.OnStart(); err != nil {
|
||||
return err
|
||||
}
|
||||
RETRY_LOOP:
|
||||
|
||||
for {
|
||||
|
|
|
@ -57,7 +57,9 @@ func NewSocketClient(addr string, mustConnect bool) *socketClient {
|
|||
}
|
||||
|
||||
func (cli *socketClient) OnStart() error {
|
||||
cli.BaseService.OnStart()
|
||||
if err := cli.BaseService.OnStart(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
var err error
|
||||
var conn net.Conn
|
||||
|
|
|
@ -37,7 +37,9 @@ func NewGRPCServer(protoAddr string, app types.ABCIApplicationServer) cmn.Servic
|
|||
|
||||
// OnStart starts the gRPC service
|
||||
func (s *GRPCServer) OnStart() error {
|
||||
s.BaseService.OnStart()
|
||||
if err := s.BaseService.OnStart(); err != nil {
|
||||
return err
|
||||
}
|
||||
ln, err := net.Listen(s.proto, s.addr)
|
||||
if err != nil {
|
||||
return err
|
||||
|
|
|
@ -44,7 +44,9 @@ func NewSocketServer(protoAddr string, app types.Application) cmn.Service {
|
|||
}
|
||||
|
||||
func (s *SocketServer) OnStart() error {
|
||||
s.BaseService.OnStart()
|
||||
if err := s.BaseService.OnStart(); err != nil {
|
||||
return err
|
||||
}
|
||||
ln, err := net.Listen(s.proto, s.addr)
|
||||
if err != nil {
|
||||
return err
|
||||
|
|
Loading…
Reference in New Issue