p2p/addrbook: fix addToOldBucket

p2p/addrbook.go

@@ -475,7 +475,7 @@ func (a *AddrBook) addToOldBucket(ka *knownAddress, bucketIdx int) bool {
 	}
 
 	addrStr := ka.Addr.String()
-	bucket := a.getBucket(bucketTypeNew, bucketIdx)
+	bucket := a.getBucket(bucketTypeOld, bucketIdx)
 
 	// Already exists?
 	if _, ok := bucket[addrStr]; ok {

p2p/addrbook_test.go

@@ -53,8 +53,10 @@ func TestAddrBookPickAddress(t *testing.T) {
 	assert.NotNil(addr, "expected an address")
 	addr = book.PickAddress(50)
 	assert.NotNil(addr, "expected an address")
+
+	// in this case, nNew==0 but we biased 100% to new, so we return nil
 	addr = book.PickAddress(100)
-	assert.NotNil(addr, "expected an address")
+	assert.Nil(addr, "did not expected an address")
 }
 
 func TestAddrBookSaveLoad(t *testing.T) {