fixes from review

This commit is contained in:
Ethan Buchman 2018-08-17 10:32:10 -04:00
parent 76bb4b15c7
commit 6dde320591
2 changed files with 8 additions and 11 deletions

View File

@ -116,11 +116,16 @@ See below for more details on the message types and how they are used.
- **Response**:
- `ConsensusParams (ConsensusParams)`: Initial
consensus-critical parameters.
- `Validators ([]ValidatorUpdate)`: Initial validator set.
- `Validators ([]ValidatorUpdate)`: Initial validator set (if non empty).
- **Usage**:
- Called once upon genesis.
- List of validators in the response will be used as the initial validator set
(regardless of what was sent in the request).
- If ResponseInitChain.Validators is empty, the initial validator set will be the RequestInitChain.Validators
- If ResponseInitChain.Validators is not empty, the initial validator set will be the
ResponseInitChain.Validators (regardless of what is in RequestInitChain.Validators).
- This allows the app to decide if it wants to accept the initial validator
set proposed by tendermint (ie. in the genesis file), or if it wants to use
a different one (perhaps computed based on some application specific
information in the genesis file).
### Query

View File

@ -209,14 +209,6 @@ func (pb2tm) ValidatorUpdates(vals []abci.ValidatorUpdate) ([]*Validator, error)
if err != nil {
return nil, err
}
// If the app provided an address too, it must match.
// This is just a sanity check.
/*if len(v.Address) > 0 {
if !bytes.Equal(pub.Address(), v.Address) {
return nil, fmt.Errorf("Validator.Address (%X) does not match PubKey.Address (%X)",
v.Address, pub.Address())
}
}*/
tmVals[i] = NewValidator(pub, v.Power)
}
return tmVals, nil