From a171d906110ea86c3e9e79f3e0bd6c7c7640abc2 Mon Sep 17 00:00:00 2001 From: Jae Kwon Date: Thu, 28 Dec 2017 17:37:21 -0800 Subject: [PATCH] Fix possibly incorrect usage of conversion --- common/repeat_timer.go | 3 +-- common/repeat_timer_test.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/common/repeat_timer.go b/common/repeat_timer.go index 96348bd1..2e6cb81c 100644 --- a/common/repeat_timer.go +++ b/common/repeat_timer.go @@ -36,8 +36,7 @@ func (t *defaultTicker) Chan() <-chan time.Time { // Implements Ticker func (t *defaultTicker) Stop() { - tt := time.Ticker(*t) - tt.Stop() + ((*time.Ticker)(t)).Stop() } //---------------------------------------- diff --git a/common/repeat_timer_test.go b/common/repeat_timer_test.go index 269316bd..da168707 100644 --- a/common/repeat_timer_test.go +++ b/common/repeat_timer_test.go @@ -31,7 +31,7 @@ func TestRepeat(t *testing.T) { for i := 0; i < cnt; i++ { timeout := time.After(time.Second * 2) select { - case _ = <-rt.Chan(): + case <-rt.Chan(): case <-timeout: t.Fatal("expected RepeatTimer to fire") }