From b36203bb02857ce7c2dac66244ec9a2760c650d9 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Tue, 23 May 2017 23:27:26 +0200 Subject: [PATCH] [cli] add a test case to TestParseLogLevel where there is no module key --- cli/flags/log_level_test.go | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/cli/flags/log_level_test.go b/cli/flags/log_level_test.go index 91f49b69..458a9e24 100644 --- a/cli/flags/log_level_test.go +++ b/cli/flags/log_level_test.go @@ -25,18 +25,22 @@ func TestParseLogLevel(t *testing.T) { ``, // if no default is given, assume info ``, `{"_msg":"Mesmero","level":"error","module":"mempool"}`, - `{"_msg":"Mind","level":"info","module":"state"}`}}, // if no default is given, assume info + `{"_msg":"Mind","level":"info","module":"state"}`, // if no default is given, assume info + ``}}, + {"mempool:error,*:debug", []string{ `{"_msg":"Kingpin","level":"debug","module":"wire"}`, ``, `{"_msg":"Mesmero","level":"error","module":"mempool"}`, - `{"_msg":"Mind","level":"info","module":"state"}`}}, + `{"_msg":"Mind","level":"info","module":"state"}`, + `{"_msg":"Gideon","level":"debug"}`}}, {"*:debug,wire:none", []string{ ``, `{"_msg":"Kitty Pryde","level":"info","module":"mempool"}`, `{"_msg":"Mesmero","level":"error","module":"mempool"}`, - `{"_msg":"Mind","level":"info","module":"state"}`}}, + `{"_msg":"Mind","level":"info","module":"state"}`, + `{"_msg":"Gideon","level":"debug"}`}}, } for _, c := range correctLogLevels { @@ -75,6 +79,12 @@ func TestParseLogLevel(t *testing.T) { t.Errorf("\nwant '%s'\nhave '%s'\nlevel '%s'", c.expectedLogLines[3], have, c.lvl) } + buf.Reset() + + logger.Debug("Gideon") + if have := strings.TrimSpace(buf.String()); c.expectedLogLines[4] != have { + t.Errorf("\nwant '%s'\nhave '%s'\nlevel '%s'", c.expectedLogLines[4], have, c.lvl) + } } incorrectLogLevel := []string{"some", "mempool:some", "*:some,mempool:error"}