From e6164d40528b8621b01cacdb82efe72dee01eeb0 Mon Sep 17 00:00:00 2001
From: Anton Kaliaev <anton.kalyaev@gmail.com>
Date: Mon, 6 Nov 2017 12:47:23 -0500
Subject: [PATCH] change service#Stop to be similar to Start

---
 common/service.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/service.go b/common/service.go
index 3973adab..32f531d1 100644
--- a/common/service.go
+++ b/common/service.go
@@ -16,7 +16,7 @@ type Service interface {
 	Start() error
 	OnStart() error
 
-	Stop() bool
+	Stop() error
 	OnStop()
 
 	Reset() (bool, error)
@@ -127,15 +127,15 @@ func (bs *BaseService) Start() error {
 func (bs *BaseService) OnStart() error { return nil }
 
 // Implements Service
-func (bs *BaseService) Stop() bool {
+func (bs *BaseService) Stop() error {
 	if atomic.CompareAndSwapUint32(&bs.stopped, 0, 1) {
 		bs.Logger.Info(Fmt("Stopping %v", bs.name), "impl", bs.impl)
 		bs.impl.OnStop()
 		close(bs.Quit)
-		return true
+		return nil
 	} else {
 		bs.Logger.Debug(Fmt("Stopping %v (ignoring: already stopped)", bs.name), "impl", bs.impl)
-		return false
+		return ErrAlreadyStopped
 	}
 }