a506cf47ad
protect Record* peerStateStats functions by mutex
...
Fixes #1414
DATA RACE:
```
Read at 0x00c4214ee940 by goroutine 146:
github.com/tendermint/tendermint/consensus.(*peerStateStats).String()
<autogenerated>:1 +0x57
fmt.(*pp).handleMethods()
/usr/local/go/src/fmt/print.go:596 +0x3f4
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:679 +0x11f
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:996 +0x319
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:196 +0x73
github.com/tendermint/tendermint/consensus.(*PeerState).StringIndented()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:1426 +0x573
github.com/tendermint/tendermint/consensus.(*PeerState).String()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:1419 +0x66
github.com/go-logfmt/logfmt.safeString()
/home/ubuntu/go/src/github.com/go-logfmt/logfmt/encode.go:299 +0x9d
github.com/go-logfmt/logfmt.writeValue()
/home/ubuntu/go/src/github.com/go-logfmt/logfmt/encode.go:217 +0x5a0
github.com/go-logfmt/logfmt.(*Encoder).EncodeKeyval()
/home/ubuntu/go/src/github.com/go-logfmt/logfmt/encode.go:61 +0x1dd
github.com/tendermint/tmlibs/log.tmfmtLogger.Log()
/home/ubuntu/go/src/github.com/tendermint/tmlibs/log/tmfmt_logger.go:107 +0x1001
github.com/tendermint/tmlibs/log.(*tmfmtLogger).Log()
<autogenerated>:1 +0x93
github.com/go-kit/kit/log.(*context).Log()
/home/ubuntu/go/src/github.com/go-kit/kit/log/log.go:124 +0x248
github.com/tendermint/tmlibs/log.(*tmLogger).Debug()
/home/ubuntu/go/src/github.com/tendermint/tmlibs/log/tm_logger.go:64 +0x1d0
github.com/tendermint/tendermint/consensus.(*PeerState).PickSendVote()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:1059 +0x242
github.com/tendermint/tendermint/consensus.(*ConsensusReactor).gossipVotesForHeight()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:789 +0x6ef
github.com/tendermint/tendermint/consensus.(*ConsensusReactor).gossipVotesRoutine()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:723 +0x1039
Previous write at 0x00c4214ee940 by goroutine 21:
github.com/tendermint/tendermint/consensus.(*PeerState).RecordVote()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:1242 +0x15a
github.com/tendermint/tendermint/consensus.(*ConsensusReactor).Receive()
github.com/tendermint/tendermint/consensus/_test/_obj_test/reactor.go:309 +0x32e6
github.com/tendermint/tendermint/p2p.createMConnection.func1()
/home/ubuntu/go/src/github.com/tendermint/tendermint/p2p/peer.go:365 +0xea
github.com/tendermint/tendermint/p2p/conn.(*MConnection).recvRoutine()
/home/ubuntu/go/src/github.com/tendermint/tendermint/p2p/conn/connection.go:531 +0x779
```
2018-04-05 11:42:45 +02:00
37ce6b195a
ValidatorSet#GetByAddress: return -1 if no validator was found
2018-04-04 10:42:34 +02:00
5f548c7679
consensus: close pubsub channels. fixes #1372
2018-04-03 22:57:32 +03:00
2644a529f0
Fix lint errors ( #1390 )
...
* use increment and decrement operators.
* remove unnecessary else branches.
* fix package comment with leading space.
* fix receiver names.
* fix error strings.
* remove omittable code.
* remove redundant return statement.
* Revert changes (code is generated.)
* use cfg as receiver name for all config-related types.
* use lsi as the receiver name for the LastSignedInfo type.
2018-04-02 10:21:17 +02:00
1c82281b77
make app_options -> app_state backwards compatible
2018-03-26 21:51:07 +02:00
20b198681b
Merge pull request #1328 from tendermint/bucky/add-vote-readability
...
addVote readability
2018-03-19 12:24:28 +01:00
2c445059f2
mark peer as good every blocksToContributeToBecomeGoodPeer blocks
...
if enough peers are marked good eventually some will become unmarked, so
good to have a force that will continue to cycle them back into good
territory!
Refs #1317
2018-03-19 14:10:25 +03:00
ab59f64f57
test we record votes and block parts
...
Refs #1317
2018-03-19 13:17:11 +03:00
42e3457884
fix tracking of votes and blockparts to not allow old information
...
also remove mutex
Refs #1317
2018-03-19 13:17:06 +03:00
31f3dd42e7
mark peer as good only once
...
or should we do it every N blocks?
Refs #1317
2018-03-19 13:17:00 +03:00
5fab8e404d
replace magic number with blocksToContributeToBecomeGoodPeer const
...
Refs #1317
2018-03-19 13:16:56 +03:00
ab7dea4f20
consensus: return from errors sooner in addVote
2018-03-18 23:09:04 +01:00
b297efb532
consensus: return from go-routine in test
2018-03-18 23:05:04 +01:00
86ddf17db0
add a todo
...
Refs #1281
2018-03-15 11:58:20 +04:00
a655500047
fix copy-pasted comment [ci skip]
2018-03-15 11:58:20 +04:00
714f885dac
mark peer as good if it contributed enough votes or block parts
...
Refs #1147
2018-03-15 11:58:20 +04:00
b0d8f552c5
return err if peer has sent a vote that does not match our round
2018-03-15 11:58:20 +04:00
63cb69cb96
comment out ErrAddingVote because it breaks byzantine_test
2018-03-15 11:58:20 +04:00
266974cb59
stop peer if it sends invalid vote
2018-03-15 11:58:20 +04:00
4242352852
stop peer on decoding error
2018-03-15 11:58:19 +04:00
fff0c6cd8e
Add app_state from genesis file in InitChain message
2018-03-02 03:46:04 -05:00
5378bfc5c7
types.SignBytes -> o.SignBytes
2018-03-02 01:50:17 -05:00
ca3655a409
types: p2pID -> P2PID
2018-03-02 01:42:56 -05:00
d4e93a6de3
Separate ValidBlock rule from unlocking rule
2018-03-01 11:42:22 +01:00
4670857c15
Add support for ValidBlock mechanism for the simplest case
2018-03-01 11:42:22 +01:00
2cc63069c6
rename dummy to kvstore ( #1223 )
...
* remove accidental binary
* docs: s/Dummy&dummy/KVStore&kvstore/g
* glide update to abci
* update abci import paths
* dummy begone, hello kvstore
* RequestInitChain needs genesisBytes
* glide update
2018-02-27 18:01:10 +04:00
3cd604562c
RequestInitChain needs genesisBytes
2018-02-21 03:43:47 +00:00
2a24ae90c1
fixes from Jae's review
...
1. remove pointer
2. add Quit() method to Service interface
2018-02-12 14:32:09 +04:00
d34286c421
minor fixes - tests pass
2018-02-03 03:54:49 -05:00
e7747f7d66
it compiles
2018-02-03 03:52:17 -05:00
cd0fd06b0d
update for sdk2 libs. need to fix kv test
...
NOTE we only updating for tmlibs and abci
2018-02-03 03:35:02 -05:00
ab13806276
consensus: print go routines in failed test
2018-01-25 01:22:53 -05:00
3ae26bd6e6
consensus: fix SetLogger in tests
2018-01-24 23:34:57 -05:00
87087b8acd
consensus: minor cosmetic
2018-01-23 21:41:13 -05:00
ee674f919f
StopPeerForError in blockchain and consensus
2018-01-21 13:32:04 -05:00
6f3d9b4be3
fix race
2018-01-19 01:36:52 -05:00
f06cc6630b
mempool: cfg.CacheSize and expose InitWAL
2018-01-19 01:03:03 -05:00
8171628ee5
make tests run faster
2018-01-19 00:59:09 -05:00
1cb76625d3
consensus: rename test funcs
2018-01-19 00:59:09 -05:00
b1485b181a
Merge branch 'p2p-consolidate' into p2p-id
2018-01-13 15:20:23 -05:00
e0e600df05
Merge branch 'develop' into config
2018-01-06 05:30:38 +00:00
a17105fd46
p2p: peer.Key -> peer.ID
2018-01-01 22:39:05 -05:00
ff99ca7cdf
bump wal test timeout
2017-12-29 17:51:13 -05:00
6112578d07
ValidateBlock is a method on blockExec
2017-12-28 23:15:54 -05:00
ae68fcb78a
move fireEvents to ApplyBlock
2017-12-28 23:15:54 -05:00
1d6f00859d
fixes from review
2017-12-28 23:15:54 -05:00
537b0dfa1a
use NopEventBus
2017-12-28 23:15:54 -05:00
0acca7fe69
final updates for state
2017-12-28 23:15:54 -05:00
f55135578c
state: move methods to funcs
2017-12-28 23:15:54 -05:00
a8e625e99d
config: unexpose chainID
2017-12-28 20:49:02 +00:00
Anton Kaliaev
Ethan Buchman
Thomas Corbière
Ethan Frey
Zarko Milosevic
Zach