3 Commits

Author	SHA1	Message	Date
Emmanuel T Odeke	8813684040	lite/proxy: consolidate some common test headers into a variable ... Addressing some feedback from @ebuchman in regards to consolidating some common test headers into a variable. I've added that for simple cases, trying to meet in the middle instead of creating helpers that obscure readibility and easy comparison of test cases.	2018-03-25 00:27:42 -06:00
Emmanuel T Odeke	58f36bb321	Review feedback from @melekes ... * Fix typo on naming s/deabBeef/deadBeef/g * Use `assert.*(t,` instead of `assert.New(t);...;assert.*(`	2018-03-24 23:54:01 -06:00
Emmanuel T Odeke	4c2f56626a	lite/proxy: Validation* tests and hardening for nil dereferences ... Updates https://github.com/tendermint/tendermint/issues/1017 Ensure that the Validate* functions in proxy are tests and cover the case of sneakish bugs that have been encountered a few times from nil dereferences. The lite package should theoretically never panic with a nil dereference. It is meant to contain the certifiers hence it should never panic with such. Requires the following bugs to be fixed first; * https://github.com/tendermint/tendermint/issues/1298 * https://github.com/tendermint/tendermint/issues/1299	2018-03-24 23:54:01 -06:00