Commit Graph

119 Commits

Author SHA1 Message Date
Emmanuel Odeke bbc3b807c6
all: fix vet issues with build tags, formatting
* Build tags need to come before the package name
and have at least a blank line, between them and
the package, please see
  https://golang.org/pkg/go/build/#hdr-Build_Constraints
* fmt.Println doesn't take formatting verbs
* Fix a missing formatting argument to fmt.Printf
2017-12-12 17:23:16 -07:00
Ethan Buchman 310beae63c types: check ResponseCheckTx too 2017-12-12 10:14:50 -05:00
Emmanuel Odeke 7167d4e4c7
types: compile type assertions to avoid sneaky runtime surprises
Ensure that the types in result.go implement both
json.Marshaler and json.Unmarshaler
and thus avoid any accidental deletions of their respective
methods which would then cause surprises at runtime.
2017-12-12 01:15:39 -07:00
Ethan Buchman 47216538fd types: add UnmarshalJSON funcs for Response types 2017-12-06 03:19:28 -05:00
Ethan Buchman e1ee4d6bf5 types: add MarshalJSON funcs for Response types with a Code 2017-12-06 01:56:39 -05:00
Ethan Buchman 1b2c383205 ResponseSetOption includes a response Code. Closes #64" 2017-12-05 18:41:52 -05:00
Ethan Buchman 2b804bb5a1 remove custom type int https://github.com/gogo/protobuf/issues/359 2017-12-02 11:47:02 -05:00
Ethan Buchman 82d56571b5 types: int32 with gogo int 2017-12-02 01:48:46 -05:00
Ethan Buchman 3890a2058f types: IsOK() 2017-12-02 01:48:37 -05:00
Ethan Buchman b20273439d types: RequestBeginBlock includes absent and byzantine validators 2017-12-01 03:00:11 -05:00
Ethan Buchman 9272756c49 types: add note about ReadMessage having no cap 2017-12-01 03:00:11 -05:00
Ethan Buchman 3d3d1288d1 types: consolidate some file 2017-12-01 03:00:11 -05:00
Ethan Buchman 0ad7dea71f uint64 -> int64 2017-12-01 00:41:07 -05:00
Ethan Buchman e3f6666ecc update changelog; add rudis script for safe keeping 2017-11-30 17:48:05 -05:00
Ethan Buchman 81e4effbdb types: use data.Bytes directly in type.proto via gogo/protobuf. wow 2017-11-30 15:31:12 -05:00
Ethan Buchman 308cb8e454 use gogo/protobuf 2017-11-30 14:47:09 -05:00
Ethan Buchman 42a8e3240c remove CodeType 2017-11-30 14:29:12 -05:00
Anton Kaliaev 20befcf6d6
add 2 helper methods for building KVPair(s) 2017-11-30 11:17:35 -06:00
Ethan Buchman ab51bdef99 types.pb.go isnt linted. use nolint :( 2017-11-27 20:53:03 +00:00
Ethan Buchman e08885e3cd minor fix 2017-11-27 20:16:35 +00:00
Ethan Buchman 7dc5b746ac types: add gas and fee fields to CheckTx 2017-11-27 20:10:11 +00:00
Ethan Buchman c7f54fb56c everything takes Request, returns Response; expect DeliverTx/CheckTx/Commit 2017-11-27 19:04:21 +00:00
Anton Kaliaev 67d2a5f66d
set Code to OK in ResponseQuery in BaseApplication
See https://github.com/tendermint/abci/pull/130#discussion_r152713220
2017-11-24 16:45:36 -06:00
Anton Kaliaev 9b30fab4fc
preserve behaviour of BaseApplication 2017-11-22 19:38:28 -06:00
Anton Kaliaev 2cfad8523a
test HumanCode 2017-11-22 18:24:53 -06:00
Anton Kaliaev 1726e82865
add IsErr and Error method for ResultQuery 2017-11-22 18:19:41 -06:00
Anton Kaliaev 91efacfabc
remove types.Result 2017-11-22 17:44:39 -06:00
Anton Kaliaev f01f2bbf3a
DeliverTxSync/CheckTxSync/CommitSync now return error as well 2017-11-22 17:34:00 -06:00
Anton Kaliaev 01252e8cc8
mark Result as deprecated 2017-11-22 16:18:06 -06:00
Anton Kaliaev 5fd83b3eee
implement error interface for ResponseDeliverTx/CheckTx/Commit 2017-11-22 16:17:34 -06:00
Anton Kaliaev fbe7234639
remove Result from the client package
plus make Client interface more consistent. All *Sync functions now
return an error as a second return param. Deliver/Check/Commit use Code
to indicate errors and have IsErr() func defined on ResponseXYZ structs.
2017-11-21 17:44:13 -06:00
Anton Kaliaev 3a3d508e5c
CheckTx and DeliverTx return ResponseCheckTx and ResponseDeliverTx respectively
Commit now returns ResponseCommit
2017-11-20 20:36:42 -06:00
Anton Kaliaev fc7db13fa8
remove tags from CheckTx
add value_type field to KVPair
2017-11-20 18:21:59 -06:00
Anton Kaliaev 33b51378f2
reformat types.proto 2017-11-20 16:56:57 -06:00
Anton Kaliaev bb0d7e9526
add tags field to DeliverTx and CheckTx 2017-11-20 16:56:57 -06:00
Ethan Buchman 667c2543ea use request struct for Info 2017-09-22 11:10:55 -04:00
Zach Ramsay fe426de5d4 lint: couple more fixes 2017-09-22 09:45:50 -04:00
Ethan Buchman 318345f996 fix tests 2017-09-22 00:10:13 -04:00
Ethan Buchman f279171a28 use request structs for InitChain and BeginBlock 2017-09-18 15:51:48 -04:00
Ethan Buchman f1094f760b types: remove redundant version file 2017-09-06 02:22:59 -04:00
Ethan Buchman 5dabeffb35 fixes from review 2017-05-15 12:59:44 -04:00
rigel rozanski 05dc4d12dd result.IsSameCode 2017-05-15 09:50:49 -04:00
Adrian Brink 577ec5452f Fix indentation 2017-05-09 12:33:38 +02:00
Adrian Brink 322b4e54de Remove unused enum MessageTypes 2017-05-09 12:23:37 +02:00
Krzysztof Jurewicz a3d4e5797d Comment out MessageType
As it is an unused enum, leaving it uncommented causes dead Protocol
Buffers code to be generated.
2017-05-09 12:23:37 +02:00
Ethan Buchman 8d8e35ae53 types: methods convert pb types to use data.Bytes 2017-04-27 19:53:22 -04:00
Ethan Buchman 8339dc3b1a types: Result and Validator use data.Bytes 2017-04-27 19:21:26 -04:00
Ethan Buchman be5a4345a3 formatting and update CHANGELOG 2017-03-06 02:58:26 -05:00
Ethan Buchman 31bdda27ad Query: LastHeight -> Height :) 2017-02-14 16:53:21 -05:00
Ethan Buchman e909cafa0b BaseApplication 2017-02-13 20:16:21 -05:00