a969e24177
crank context timeouts
2017-11-15 01:42:15 +00:00
7b0fa6c889
p2p: peer should respect errors from SetDeadline
...
Noticed while auditing the code that we aren't respecting
(*net.Conn) SetDeadline errors which return after
a connection has been killed and is simultaneously
being used.
For example given program, without SetDeadline error checks
```go
package main
import (
"log"
"net"
"time"
)
func main() {
conn, err := net.Dial("tcp", "tendermint.com:443")
if err != nil {
log.Fatal(err)
}
go func() {
<-time.After(400 * time.Millisecond)
conn.Close()
}()
for i := 0; i < 5; i++ {
if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil {
log.Fatalf("set deadline #%d, err: %v", i, err)
}
log.Printf("Successfully set deadline #%d", i)
<-time.After(150 * time.Millisecond)
}
}
```
erraneously gives
```shell
2017/11/14 17:46:28 Successfully set deadline #0
2017/11/14 17:46:29 Successfully set deadline #1
2017/11/14 17:46:29 Successfully set deadline #2
2017/11/14 17:46:29 Successfully set deadline #3
2017/11/14 17:46:29 Successfully set deadline #4
```
However, if we properly fix it to respect that error with
```diff
--- wild.go 2017-11-14 17:44:38.000000000 -0700
+++ main.go 2017-11-14 17:45:40.000000000 -0700
@@ -16,7 +16,9 @@
conn.Close()
}()
for i := 0; i < 5; i++ {
- conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second)))
+ if err := conn.SetDeadline(time.Now().Add(time.Duration(10 *
time.Second))); err != nil {
+ log.Fatalf("set deadline #%d, err: %v", i, err)
+ }
log.Printf("Successfully set deadline #%d", i)
<-time.After(150 * time.Millisecond)
}
```
properly catches any problems and gives
```shell
$ go run main.go
2017/11/14 17:43:44 Successfully set deadline #0
2017/11/14 17:43:45 Successfully set deadline #1
2017/11/14 17:43:45 Successfully set deadline #2
2017/11/14 17:43:45 set deadline #3 , err: set tcp 10.182.253.51:57395:
use of closed network connection
exit status 1
```
2017-11-14 18:01:51 -07:00
fa60d8120e
fix TestFullRound1 race (Refs #846 )
...
```
==================
WARNING: DATA RACE
Write at 0x00c42d7605f0 by goroutine 844:
github.com/tendermint/tendermint/consensus.(*ConsensusState).updateToState()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:465 +0x59e
I[11-14|22:37:28.781] Added to prevote vote="Vote{0:646753DCE124 1/02/1(Prevote) E9B19636DCDB {/CAD5FA805E8C.../}}" prevotes="VoteSet{H:1 R:2 T:1 +2/3:<nil> BA{2:X_} map[]}"
github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1229 +0x16a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1135 +0x721
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1087 +0x153
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1114 +0xa34
github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1423 +0xdd6
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1317 +0x77
github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:565 +0x7a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:523 +0x6d2
Previous read at 0x00c42d7605f0 by goroutine 654:
github.com/tendermint/tendermint/consensus.validatePrevote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:149 +0x57
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:256 +0x3c5
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 844 (running) created at:
github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:258 +0x8c
github.com/tendermint/tendermint/consensus.startTestRound()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:118 +0x63
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:247 +0x1fb
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 654 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:789 +0x568
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1004 +0xa7
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
testing.runTests()
/usr/local/go/src/testing/testing.go:1002 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:921 +0x206
main.main()
github.com/tendermint/tendermint/consensus/_test/_testmain.go:106 +0x1d3
==================
```
2017-11-14 17:41:30 -06:00
8b7649b90c
enhancements made in response to PR full review comments
2017-11-14 18:26:06 -05:00
687834c99e
added initial trust metric test routines
2017-11-14 18:26:06 -05:00
54c25ccbf5
integrated trust metric store as per PR comments
2017-11-14 18:26:06 -05:00
e160a6198c
added initial trust metric design doc and code
2017-11-14 18:26:06 -05:00
e69d36d54f
some more robust sleeps
2017-11-14 22:31:23 +00:00
844c43e044
use stdlib context
2017-11-14 22:30:00 +00:00
194712fd3b
rpc: wait for rpc servers to be available in tests
2017-11-14 21:51:49 +00:00
30f675aafa
Merge pull request #839 from tendermint/bugfix/pubsub-failures
...
Fix nondeterministic tests failures related to pubsub
2017-11-14 18:13:47 +00:00
695266e907
Merge pull request #844 from tendermint/bunch-up-p2p.AddrBook-wg-calls
...
p2p: comment on the wg.Add before go saveRoutine()
2017-11-14 17:18:27 +00:00
3db44dacae
Merge pull request #840 from tendermint/fix/tests
...
Fix/tests
2017-11-14 15:48:17 +00:00
62c1bc0a20
p2p: comment on the wg.Add before go saveRoutine()
...
Just noticed while auditing the code in p2p/addrbook.go,
wg.Add(1) but no subsequent defer.
@jaekwon and I had a discussion offline and we agreed to
comment about why the code was that way and why
we shouldn't move the wg.Add(1) into .saveRoutine() because
if go a.saveRoutine() isn't started before anyone invokes
a.Wait(), then we'd have raced a.saveRoutine().
2017-11-13 18:14:58 -07:00
3863885c71
WIP: begin parallel refactoring with go-wire Write methods and MConnection
2017-11-12 22:11:15 -08:00
238e2b72ee
Merge pull request #834 from tendermint/829-enable-logs-by-default
...
Enable logs by default
2017-11-12 07:06:14 +00:00
a65ab3b0e0
Merge pull request #838 from tendermint/docker
...
docker update || 0.12.0
2017-11-12 06:51:01 +00:00
aba8a8f4fc
consensus: crank timeout in timeoutWaitGroup
2017-11-12 06:41:15 +00:00
0448c2b437
consensus: fix LastCommit log
2017-11-12 06:40:27 +00:00
0ada0cf525
certifiers: test uses WaitForHeight
2017-11-12 00:43:16 +00:00
7fa12662c4
check whatever we can read from the channel
...
```
panic: interface conversion: interface {} is nil, not types.TMEventData
goroutine 7690 [running]:
github.com/tendermint/tendermint/consensus.waitForAndValidateBlock.func1(0xc427727620, 0x3)
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:292 +0x62b
created by github.com/tendermint/tendermint/consensus.timeoutWaitGroup
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:349 +0xa4
exit status 2
FAIL github.com/tendermint/tendermint/consensus 38.614s
```
2017-11-10 18:16:31 -05:00
bc9c4e8dee
update readme [ci skip]
2017-11-10 15:38:32 -05:00
8004af2519
update docker readme
2017-11-10 15:17:13 -05:00
21e87ebc11
update Go version to 1.9.2
2017-11-10 15:10:52 -05:00
70d8afa6e9
update Dockerfile
2017-11-10 15:09:38 -05:00
847f865438
Merge pull request #836 from tendermint/fix/tests
...
consensus: make mempool_test deterministic
2017-11-10 05:08:54 +00:00
2cda777900
consensus: make mempool_test deterministic
2017-11-09 23:54:02 +00:00
432a7276e2
[test_integrations] enable logs from peers by default (Refs #829 )
2017-11-09 15:19:49 -05:00
533f7c45eb
fix bash linter warnings for atomic_broadcast integration test
2017-11-09 14:58:16 -05:00
a1cdc2b68a
set logger for peer's MConnection
2017-11-09 14:57:40 -05:00
9c4d533695
Merge pull request #833 from tendermint/fix/consensus-tests
...
consensus: fix for initializing block parts during catchup
2017-11-09 19:04:21 +00:00
ad03491ee6
remove duplicated key
2017-11-09 13:37:29 -05:00
4b9dfc8990
consensus: fix for initializing block parts during catchup
2017-11-09 18:14:41 +00:00
a46f64cd1e
Merge pull request #824 from tendermint/bugfix/node_test
...
rewrite node test to use new pubsub
2017-11-09 01:35:35 +00:00
b1e7163689
rewrite node test to use new pubsub
2017-11-08 13:12:48 -05:00
c931279960
p2p: some fixes re @odeke-em issues #813,#816,#817
2017-11-08 17:54:29 +00:00
12b25fdf6e
blockchain: add comment in AddPeer. closes #666
2017-11-08 02:42:27 +00:00
c0e2649ed6
Merge pull request #788 from tendermint/feature/548-indexing-tags
...
new pubsub package
2017-11-08 01:02:48 +00:00
593c127257
rpc/lib/types: RPCResponse.Result is not a pointer
2017-11-08 01:00:15 +00:00
9f6a09277e
Merge pull request #812 from tendermint/808-make-connected-switches
...
MakeConnectedSwitches: connect first switch to others
2017-11-08 00:54:23 +00:00
dd47884661
Merge pull request #820 from tendermint/790-use-tickers-instead-of-time-Sleep
...
prefer tickers to time.Sleep
2017-11-08 00:53:42 +00:00
a01c226dc4
wsConnection: call onDisconnect
2017-11-07 19:22:01 -05:00
47f5e37205
copy RoundState for event
2017-11-07 23:57:23 +00:00
51c9211cf4
add test for MConnection TrySend and Send
2017-11-07 23:35:25 +00:00
7869e541f6
change MakeConnectedSwitches to not connect to itself
...
and a test for it
2017-11-07 18:33:00 -05:00
e0daca5693
fixes from Bucky's review
2017-11-07 18:20:24 -05:00
e8e512f1fa
Merge pull request #815 from tendermint/p2p-readme-tests
...
P2P: readme and tests
2017-11-07 23:01:15 +00:00
37ce171061
p2p/connetion: remove panics, test error cases
2017-11-07 23:00:52 +00:00
e01986e2b3
p2p: update readme, some minor things
2017-11-07 23:00:49 +00:00
433416fef8
Merge pull request #818 from tendermint/fix/810-stuck-trailing-node
...
consensus: ensure prs.ProposalBlockParts is initialized. fixes #810
2017-11-07 21:52:08 +00:00
Ethan Buchman
Emmanuel Odeke
Anton Kaliaev
caffix
Petabyte Storage