62c1bc0a20
p2p: comment on the wg.Add before go saveRoutine()
...
Just noticed while auditing the code in p2p/addrbook.go,
wg.Add(1) but no subsequent defer.
@jaekwon and I had a discussion offline and we agreed to
comment about why the code was that way and why
we shouldn't move the wg.Add(1) into .saveRoutine() because
if go a.saveRoutine() isn't started before anyone invokes
a.Wait(), then we'd have raced a.saveRoutine().
2017-11-13 18:14:58 -07:00
a1cdc2b68a
set logger for peer's MConnection
2017-11-09 14:57:40 -05:00
c931279960
p2p: some fixes re @odeke-em issues #813,#816,#817
2017-11-08 17:54:29 +00:00
9f6a09277e
Merge pull request #812 from tendermint/808-make-connected-switches
...
MakeConnectedSwitches: connect first switch to others
2017-11-08 00:54:23 +00:00
dd47884661
Merge pull request #820 from tendermint/790-use-tickers-instead-of-time-Sleep
...
prefer tickers to time.Sleep
2017-11-08 00:53:42 +00:00
51c9211cf4
add test for MConnection TrySend and Send
2017-11-07 23:35:25 +00:00
7869e541f6
change MakeConnectedSwitches to not connect to itself
...
and a test for it
2017-11-07 18:33:00 -05:00
e0daca5693
fixes from Bucky's review
2017-11-07 18:20:24 -05:00
37ce171061
p2p/connetion: remove panics, test error cases
2017-11-07 23:00:52 +00:00
e01986e2b3
p2p: update readme, some minor things
2017-11-07 23:00:49 +00:00
2d4ad02356
prefer tickers to time.Sleep (Refs #790 )
2017-11-07 15:38:25 -05:00
e785697a64
connect first switch to others (Refs #808 )
2017-11-06 23:43:40 -05:00
fe9ff62297
fix comment typos
2017-10-28 22:01:45 -07:00
6b366b2443
fix test using uncommon names
2017-10-28 20:29:11 -07:00
ceedd4d968
remove unnecessary plus [ci skip]
2017-10-25 22:28:20 -04:00
0bbf38141a
blockchain/pool: some comments and small changes
2017-10-23 10:13:46 -04:00
136b6a7673
rpc/lib: remove dead files, closes #710
2017-10-04 17:45:15 -04:00
f23d47e5d2
upnp: keep a link
2017-10-04 17:19:49 -04:00
d56b44f3a5
all: no more anonymous imports
2017-10-04 16:40:45 -04:00
925696ca65
Merge branch 'p2p-prune-unused-IPRangeCount-funcs' into develop
2017-09-22 21:09:41 -06:00
ddb3d8945d
p2p: allow listener with no external connection
2017-09-22 10:13:23 -04:00
b50339e8e7
p2p: sw.AddPeer -> sw.addPeer
2017-09-21 15:47:41 -04:00
aea8629272
peer interface
2017-09-15 18:40:59 -04:00
5138bcb1c7
p2p: delete unused and untested *IPRangeCount functions
...
Fixes #602
Delete unused and untested functions:
- AddToIPRangeCounts
- CheckIPRangeCounts
2017-09-15 14:03:01 -06:00
54c63726b0
p2p: minor comment fixes
2017-09-06 16:40:21 -04:00
cb80ab2965
Merge remote-tracking branch 'orijtech/p2p-full-test-PeerSet' into develop
2017-09-06 16:40:07 -04:00
c48e772115
p2p: fully test PeerSet, more docs, parallelize PeerSet tests
...
* Full test PeerSet and check its concurrent guarantees
* Improve the doc for PeerSet.Has and remove unnecessary
defer for a path that sets a variable, make it fast anyways.
* Parallelize PeerSet tests with t.Parallel()
* Document functions in peer_set.go more.
2017-09-06 02:47:31 -06:00
cc2b418f7f
p2p: test fix
2017-09-05 17:10:11 -04:00
88138c38cf
mempool: reactor test
2017-09-05 16:25:02 -04:00
daa258ea6d
p2p: put maxMsgPacketPayloadSize, recvRate, sendRate in config
...
Updates #628
2017-09-01 21:44:15 -04:00
086544e367
p2p: sw.peers.List() is empty in sw.OnStart
2017-07-10 20:43:38 -04:00
75df0d91ba
comments from review
2017-07-10 13:39:23 -04:00
5f6b996d22
breakup some long lines; add more comments to consensus reactor
2017-07-09 18:38:59 -04:00
74a3a2b56a
fix comments
2017-07-09 18:01:25 -04:00
b07d01f102
Add more comments on public functions and extra logging during 'enterPrevote'
...
Signed-off-by: Adrian Brink <adrian@brink-holdings.com>
2017-07-09 20:35:48 +02:00
e6cecb9595
p2p: fix test
2017-07-07 13:33:15 -04:00
3c10f7a122
add p2p flush throttle to config
2017-07-07 13:08:52 -04:00
0d1fa8e884
fixes from review
2017-06-28 11:12:45 -04:00
2750343de5
Merge branch 'apply-megacheck' into unstable
2017-06-23 21:38:22 -04:00
3c0128a680
undo some megacheck suggestions
2017-06-23 21:36:47 -04:00
b4ece65726
standardize key for errors (should be "err")
2017-06-14 12:50:49 +04:00
bf5181d9ca
address PR comments
2017-05-30 13:27:08 -04:00
cf31f8d06f
core: apply megacheck vet tool (unused, gosimple, staticcheck)
2017-05-29 23:11:40 -04:00
4fe67652ff
move SetLogger down
2017-05-14 00:24:58 +02:00
c5bccc5474
set missing logger on switch
...
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x882cec]
goroutine 328 [running]:
github.com/tendermint/tendermint/p2p.(*Switch).DialPeerWithAddress(0xc42000a500, 0xc4202088d0, 0xc420403500, 0x0, 0x0, 0x0)
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/switch.go:324 +0x2fc
github.com/tendermint/tendermint/p2p.(*PEXReactor).ensurePeers.func1(0xc4201663f0, 0xc4202088d0)
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/pex_reactor.go:280 +0x3e
created by github.com/tendermint/tendermint/p2p.(*PEXReactor).ensurePeers
/home/vagrant/go/src/github.com/tendermint/tendermint/p2p/pex_reactor.go:284 +0x5d4
```
2017-05-13 17:05:44 +02:00
f8fdbe3dbc
changes as per Bucky's review
2017-05-13 16:22:51 +02:00
c9cd8de9c6
set logger
2017-05-13 10:25:00 +02:00
bc4e6566e7
[p2p] refactor upnp to use new logger
2017-05-13 10:24:59 +02:00
16509ac3db
p2p: fix race by peer.Start() before peers.Add()
2017-05-13 10:24:59 +02:00
f803544195
new logging
2017-05-13 10:24:58 +02:00
Emmanuel Odeke
Anton Kaliaev
Ethan Buchman
Petabyte Storage
Zach Ramsay
caojingqi
Adrian Brink
zramsay