tendermint/consensus
srmo e36ce6f893 fix race condition on proposal height for published txs (#2021)
* #1920 try to fix race condition on proposal height for published txs

- related to create_empty_blocks=false
- published height for accepted tx can be wrong (too low)
- use the actual mempool height + 1 for the proposal
- expose Height() on mempool

* #1920 add initial test for mempool.Height()

- not sure how to test the lock
- can the mutex reference be of type Locker?
-- this way, we can use a "mock" of the mutex to test triggering

* #1920 use the ConsensusState height in favor of mempool

- gets rid of indirections
- doesn't need any "+1" magic

* #1920 cosmetic

- if we use cs.Height, it's enough to evaluate right before propose

* #1920 cleanup TODO and non-needed code

* #1920 add changelog entry
2018-07-23 15:34:45 +04:00
..
types Merge remote-tracking branch 'origin/develop' into dev/refactor_crypto 2018-07-20 08:59:41 -07:00
README.md Revert "delete everything" (includes everything non-go-crypto) 2018-06-20 17:35:30 -07:00
byzantine_test.go fix import paths 2018-07-01 22:36:49 -04:00
common_test.go Revert "rename privval#GetAddress and GetPubKey to Address and PubKey" 2018-07-12 22:40:07 +04:00
mempool_test.go fix import paths 2018-07-01 22:36:49 -04:00
metrics.go Revert "delete everything" (includes everything non-go-crypto) 2018-06-20 17:35:30 -07:00
reactor.go crypto: Refactor to move files out of the top level directory 2018-07-18 08:38:44 -07:00
reactor_test.go Revert "rename privval#GetAddress and GetPubKey to Address and PubKey" 2018-07-12 22:40:07 +04:00
replay.go crypto: Refactor to move files out of the top level directory 2018-07-18 08:38:44 -07:00
replay_file.go fix import paths 2018-07-01 22:36:49 -04:00
replay_test.go Revert "rename privval#GetAddress and GetPubKey to Address and PubKey" 2018-07-12 22:40:07 +04:00
state.go fix race condition on proposal height for published txs (#2021) 2018-07-23 15:34:45 +04:00
state_test.go Revert "rename privval#GetAddress and GetPubKey to Address and PubKey" 2018-07-12 22:40:07 +04:00
ticker.go fix import paths 2018-07-01 22:36:49 -04:00
version.go fix import paths 2018-07-01 22:36:49 -04:00
wal.go fix import paths 2018-07-01 22:36:49 -04:00
wal_fuzz.go Revert "delete everything" (includes everything non-go-crypto) 2018-06-20 17:35:30 -07:00
wal_generator.go fix import paths 2018-07-01 22:36:49 -04:00
wal_test.go fix import paths 2018-07-01 22:36:49 -04:00
wire.go crypto: Refactor to move files out of the top level directory 2018-07-18 08:38:44 -07:00

README.md

See the consensus spec and the reactor consensus spec for more information.