Refund even in failure

2023-02-21 22:29:51 +00:00 · 2023-02-21 22:29:51 +00:00 · 556b0dd572
parent a1df44b3ee
commit 556b0dd572
1 changed files with 3 additions and 5 deletions
--- a/ethereum/contracts/coreRelayer/CoreRelayer.sol
+++ b/ethereum/contracts/coreRelayer/CoreRelayer.sol
@ -438,11 +438,9 @@ contract CoreRelayer is CoreRelayerGovernance {
            : (preGas - postGas);

        // refund unused gas budget
-        uint256 weiToRefund = internalInstruction.receiverValueTarget;
-        if (success) {
-            weiToRefund = (internalInstruction.executionParameters.gasLimit - gasUsed)
-                * internalInstruction.maximumRefundTarget / internalInstruction.executionParameters.gasLimit;
-        }
+        uint256 weiToRefund = (internalInstruction.executionParameters.gasLimit - gasUsed)
+            * internalInstruction.maximumRefundTarget / internalInstruction.executionParameters.gasLimit
+            + (success ? 0 : internalInstruction.receiverValueTarget);

        // unlock the contract
        setContractLock(false);