certusone
/
trustless-generic-relayer
mirror of https://github.com/certusone/trustless-generic-relayer.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Avoids double read on the same storage slot.

This commit is contained in:
Sebastián Claudio Nale 2023-01-31 18:35:32 -03:00 committed by Joe Howarth
parent 7fa160e50e
commit e1b57fb4df
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ethereum/contracts/coreRelayer/CoreRelayer.sol
View File

@ -209,8 +209,10 @@ contract CoreRelayer is CoreRelayerGovernance {
);
}
function emitForward(uint256 refundAmount) internal returns (uint64, bool) {
ForwardingRequest memory forwardingRequest = getForwardingRequest();
function emitForward(uint256 refundAmount, ForwardingRequest memory forwardingRequest)
internal
returns (uint64, bool)
{
DeliveryRequestsContainer memory container =
decodeDeliveryRequestsContainer(forwardingRequest.deliveryRequestsContainer);
@ -454,7 +456,7 @@ contract CoreRelayer is CoreRelayerGovernance {
forwardingRequest.isValid
&& (forwardingRequest.sender == fromWormholeFormat(internalInstruction.targetAddress))
) {
(, success) = emitForward(weiToRefund);
(, success) = emitForward(weiToRefund, forwardingRequest);
if (success) {
emit ForwardRequestSuccess(
deliveryVaaHash, fromWormholeFormat(internalInstruction.targetAddress), sourceChain, sourceSequence