Commit Graph

15 Commits

Author SHA1 Message Date
derpy-duck 6fee6ba1e4
Nice comments in the code (#111)
* resend doesn't take nonce as parameter

* Replace 'delivery failure' with 'receiver failure' in specs

* helper send method

* Fix interface to match not having nonce for resend

* Fix forge tests to not have nonce as a parameter

* fix redeliveryTest

* Split CoreRelayer into CoreRelayer and CoreRelayerDelivery

* fix build error

* forge fmt

* fix interface of getdefaultrelayprovider

* Nice comments for main functions in CoreRelayer.sol

* Nice comments for CoreRelayerMessages

* forge fmt

* merge

* Removes wormholeMessageFee from storage to avoid excessive gas costs.

---------

Co-authored-by: Sebastián Claudio Nale <sebinale@gmail.com>
2023-02-28 10:09:01 -05:00
derpy-duck f7de3d649d
Code cleanup (#109)
* DRY: Remove duplicate structs

* Move encode/decode/convert-request-to-instruction related files to CoreRelayerMessages

* remove rolloverchain; now it is just the chain of the first request

* forge test fix to accomdoate for removing two getters

* DRY: Remove repeated error messages

* Remove miscellaneous comments

* DRY send and forward

* replace relayprovider interface with address to match the IWormholeRelayer interface

* forge fmt

* Remove byteslib from CoreRelayer

* Remove the encoding and decoding of the delivery request -> just store the struct itself!

* forge fmt

* Rewriting of checks in send/resend/forward

* test passes

* DRY - Emit only one event

* DRY

* forge fmt

* Fix typescript error

* using IWormholeRelayer

* Consistent naming

* call wormhole.messageFee() once

* Remove unnecessary line

* Compute the length once, not every iteration

* forge tests pass
2023-02-27 14:32:57 -05:00
derpy-duck b803184a8d forge fmt 2023-02-14 14:08:21 -05:00
derpy-duck 46d276e37e Rebase completed! 2023-02-14 14:08:21 -05:00
derpy-duck 346df2e017 Most forge tests pass 2023-02-13 17:13:42 -05:00
derpy-duck 1f69c238d7 forge builds! 2023-02-13 17:13:42 -05:00
derpy-duck 673542854d
Redelivery fixes (#61)
* smart contract changes for redelivery

* Tests pass for new Redelivery interface

* remove console logs

* forge fmt

* forwarding interface fix

* Remove the rolloverChain parameter from requestForward

Co-authored-by: chase-45 <chasemoran45@gmail.com>
2023-01-26 15:10:44 -05:00
agodnic 87cfc41bf5
Replace strings with typed errors (#37)
* Replace strings with typed errors

Replace strings with typed errors in `ethereum/contracts/relayProvider/*.sol`.

* Rename misleading identifier

* Update forge assertions to use typed errors

Update RelayProvider unit tests to use typed errors.

* Replace strings with typed errors

Replace strings with typed errors in `ethereum/contracts/coreRelayer/*.sol`.

* Update forge assertions to use typed errors

Update CoreRelayer unit tests to use typed errors.

* `forge fmt`
2023-01-19 09:59:35 -05:00
scnale 4a57a6c371
Replaces "bare" with named parameters in struct constructor calls. (#35) 2023-01-13 15:27:59 -05:00
derpy-duck db159946bb Redelivery Error Testing - Errors 1, 9-17 2023-01-06 22:27:03 +00:00
Joe Howarth d9f9dfb173 run forge fmt 2023-01-05 17:46:58 -07:00
Joe Howarth ab833b38cf
Move development branch to main (#23)
* refactoring for multidelivery

* partial ts-test fixes

* use typechain in integration tests, update prettier, fix remaining integration tests

* run formatter on solidity files

* gas refunding

* gas forwarding logic

* msg.send -> refundAmount

* minor test refactor & additions

* created relayer engine directory

* more testing & tilt environment config for relayer engine

* starting work on the xMint example contracts

* additions for relayer engine

* minor modifications & todos

* fixed some errors

* refactoring + cleaned up some TODOs

* updated ICoreRelayer interface

* adjusted tests for new interface

* Working testSend

* Merged refactoring + cleaned up some TODOs

* updated ICoreRelayer interface

* adjusted tests for new interface

* Working testSend with new interface'

* refactoring interfaces & files for single VAA design

* GasOracle implementation of new interface

* GasOracle compiles

* Gas oracle upgradable

* Fix compile errors in GasOracleGovernance

* minor core relayer cleanup

* Changes to getters, setters, state

* implement quoteEvmDeliveryPrice, quoteTargetEvmGas, assetConversionAmount for corerelayer

* Correcting interface inconsistencies between CoreRelayerStructs and ICoreRelayer

* Fix encodeDeliveryRequestsContainer

* added single vaa delivery entrypoint logic

* Encode and Decode delivery instructions

* Fixed many compile errors

* First attempt at removing stacktoodeep error

* Commenting out chunks of code to identify stack too deep error

* Continue stack too deep quest

* Revert "Commenting out chunks of code to identify stack too deep error"

This reverts commit 8cd55d26ce.

* Revert "Continue stack too deep quest"

This reverts commit f0cde6871e.

* Fix stack too deep error in CoreRelayerMessages

* tests compile, run, pass

* fixing up fee collection assertions

* GasOracle tests altering

* Rename encodeDeliveryIntructions to convertToEncodedDeliveryInstructions because we are going from delivery request to delivery instruction

* adding evm events to delivery execution

* forwarding refactor for single vaa

* relay provider name refactor

* Test file slight refactor to allow for multiple chains

* first impl of hub and spoke example

* Forward test progress

* Forwarding test passes!

* More general parameters for test

* Testing file more modular, calls 'generic relayer'

* redelivery implementation

* removing todos

* Tests can use arbitrary amount of chains

* Address various TODOs

* refactored RelayProvider to be upgradeable via proxy

* Add overhead inteface to RelayProvider & adjusted necessary fee calculations

* added TODOs related to rewardAddress payout

* provider price quoting changes

* provider payments made at source

* Fixed all compile errors

* testForward and testSend pass again!

* Switched quoteAssetConversion to quoteApplicationBudgetFee in CoreRelayer interface

* First round of changes to support individual vaas in offchain relayer

- Use new custom plugin event source api in relayer engine
- Supports mulit delivery
- Config for celo and fuji

* contracts deploy successfully to tilt

* bug fixes, contracts deploy to tilt

* Starting the redelivery test

* Tests pass again, with exception of the RelayProvider tests that tested reverts, and the new testRedelivery which isn't finished

* small plugin changes

* MockRelayerIntegration is used for sending

* prepare offchain relayer to run in both tilt and testnet

* update readme and npm scripts for offchain relayer

* nit: remove console.log(argv)

* solc version bump

* Tests changed to pass (commented out the tests with differing require statements and kept redelivery incomplete

* chain registration typescript scripts

* Redeliver works!

* Redelivery test works!

* testnet deploy + relayer engine test

* Testing two sends

* Friday changes to round trip on testnet

* Shortening current tests

* Funds are correct! Relayer gets paid!

* Remove extraneous comments

* ts scripts for deployment and config

* Wormhole Fee Test

Co-authored-by: chase-45 <chasemoran45@gmail.com>
Co-authored-by: derpy-duck <115193320+derpy-duck@users.noreply.github.com>
2023-01-05 17:26:27 -05:00
Reptile ddc421bb90
Update comments and interface (#9)
* Update comments and interface

* Remove casting to uint8 in struct definitions

Co-authored-by: gator-boi <gator-boi@users.noreply.github.com>
2022-10-31 14:57:07 -05:00
A5 Pickle 0b9e81ffc5
Clean up send (#2)
* Update README.md with trustlessness

* ethereum: rename AllowedEmitterSequence; remove arbitrary payloads

* ethereum: refactor integrator contract; add verifying payload

* ethereum: update IWormhole

* ethereum: add message verifying in mock integration

* Remove deliveryList from DeliveryInstructions and fix stack too deep

* Remove maximum batch size from relay parameters

* ethereum: fix observation loop; formatting

* sdk: fix eth-integration test

* offchain-relayer: add regenerate-abi.sh

* fix Makefile

* offchain-relayer: add relayer.tilt.yaml

Co-authored-by: Evan Gray <56235822+evan-gray@users.noreply.github.com>
Co-authored-by: A5 Pickle <a5-pickle@users.noreply.github.com>
Co-authored-by: gator-boi <gator-boi@users.noreply.github.com>
2022-10-06 12:16:57 -05:00
Reptile d3b6470936
Add tests for send and deliver functionality (#9)
* Complete send and deliver functionality

* Clean up

* Add tests for relayer send method

* ethereum: remove interfaces

* ethereum: fix test

* ethereum: rename directory

* ethereum: clean up; add ts tests

* Add tests and clean up

* ethereum: fix test

* ethereum: fix output

* Add reentrancy protection and reduce gas overhead for relayers

* Add tests for full batch delivery

* Update relayer contracts to reflect changes to batch VAA implementation

* add rewards payout

* implement redeliveries, replay protection

* Complete full batch test suite

* sdk: add sdk

* sdk: fix package.json

* Add partial batch unit test and add to integration test

* Fix comments in integration test

* sdk: fix tsconfig.json

* ethereum: fix build

* Add relayer registration to integration test

* Finish integration test suite

* ethereum: fix readAbi

* ethereum: fix merge conflict

* Complete full batch test suite

* Add partial batch unit test and add to integration test

* Finish integration test suite

* Fix local validator test

* Fix merge conflict

* Add Makefile

* Add documentation to relayer contracts

* Fix Makefile

* ethereum: clean up

* ethereum: fix interface

* ethereum: fix method names and tests

* Prepare integration test for off-chain relayer changes

* Refactor contracts

Co-authored-by: Drew <dsterioti@users.noreply.github.com>
Co-authored-by: Karl Kempe <karlkempe@users.noreply.github.com>
Co-authored-by: valentin <valentinvonalbrecht@yahoo.de>
Co-authored-by: justinschuldt <justinschuldt@gmail.com>
2022-09-30 11:18:49 -05:00