certusone
/
wormhole-explorer
mirror of https://github.com/certusone/wormhole-explorer.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix tx hash parsing for Solana (#444) 

### Description

Tracking issue: https://github.com/wormhole-foundation/wormhole-explorer/issues/434

Some Solana transaction hashes were failing to parse. This pull request fixes the issue.
This commit is contained in:
agodnic 2023-06-21 21:46:23 -03:00 committed by GitHub
parent d0cea55f2d
commit 317e411900
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
api/types/tx_hash.go
View File

@ -9,10 +9,13 @@ import (
"github.com/mr-tron/base58"
)
const solanaTxHashLen = 88
const algorandTxHashLen = 52
const wormholeMinTxHashLen = 64
const wormholeMaxTxHashLen = 66
const (
algorandTxHashLen = 52
wormholeMinTxHashLen = 64
wormholeMaxTxHashLen = 66
solanaMinTxHashLen = 87
solanaMaxTxHashLen = 88
)
// TxHash represents a transaction hash passed by query params.
type TxHash struct {
@ -32,7 +35,7 @@ type TxHash struct {
func ParseTxHash(value string) (*TxHash, error) {
// Solana txHashes are 64 bytes long, encoded as base58.
if len(value) == solanaTxHashLen {
if len(value) >= solanaMinTxHashLen && len(value) <= solanaMaxTxHashLen {
return parseSolanaTxHash(value)
}

14
api/types/tx_hash_test.go
View File

@ -13,17 +13,23 @@ func TestParseTxHash(t *testing.T) {
isWormholeTxHash bool
}{
{
// Solana hash
// Solana hash - 88 characters
input: "2maR6uDZzroV7JFF76rp5QR4CFP1PFUe76VRE8gF8QtWRifpGAKJQo4SQDBNs3TAM9RrchJhnJ644jUL2yfagZco",
output: "2maR6uDZzroV7JFF76rp5QR4CFP1PFUe76VRE8gF8QtWRifpGAKJQo4SQDBNs3TAM9RrchJhnJ644jUL2yfagZco",
isSolanaTxHash: true,
},
{
// Solana hash w/ invalid length
input: "2maR6uDZzroV7JFF76rp5QR4CFP1PFUe76VRE8gF8QtWRifpGAKJQo4SQDBNs3TAM9RrchJhnJ644jUL2yfagZc",
// Solana hash - 87 characters
input: "VKrJx5ak3amnpY5EXiqfu6pnrzxHTLU95m9vfbYnGSSLQrkRzb4tm4NztCGeLcJxieXQYnqddUwoaEsDRTRh57R",
output: "VKrJx5ak3amnpY5EXiqfu6pnrzxHTLU95m9vfbYnGSSLQrkRzb4tm4NztCGeLcJxieXQYnqddUwoaEsDRTRh57R",
isSolanaTxHash: true,
},
{
// Solana hash w/ invalid length
// Solana hash w/ invalid length (86 characters)
input: "VKrJx5ak3amnpY5EXiqfu6pnrzxHTLU95m9vfbYnGSSLQrkRzb4tm4NztCGeLcJxieXQYnqddUwoaEsDRTRh57",
},
{
// Solana hash w/ invalid length (89 characters)
input: "2maR6uDZzroV7JFF76rp5QR4CFP1PFUe76VRE8gF8QtWRifpGAKJQo4SQDBNs3TAM9RrchJhnJ644jUL2yfagZco2",
},
{