certusone
/
wormhole-explorer
mirror of https://github.com/certusone/wormhole-explorer.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[API] Change status code for enqueued VAAs endpoint (#151) 

Previously, when calling `GET /api/v1/governor/enqueued_vaas`, it returned a status code of 404 when there were no enqueued VAAs.

Now, the endpoint returns a status code of 200, and the response body contains an empty array.
This commit is contained in:
agodnic 2023-02-10 14:31:33 -03:00 committed by GitHub
parent dde87acf84
commit c4b2e792b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/handlers/governor/repository.go
View File

@ -784,10 +784,6 @@ func (r *Repository) GetEnqueueVass(ctx context.Context, q *EnqueuedVaaQuery) ([
return nil, errors.WithStack(err) return nil, errors.WithStack(err)
} }
if len(rows) == 0 {
return nil, errs.ErrNotFound
}
// TODO: Change this logic to mongo query code. // TODO: Change this logic to mongo query code.
// proecess and build the response. // proecess and build the response.
keys := map[string]string{} keys := map[string]string{}
@ -815,10 +811,6 @@ func (r *Repository) GetEnqueueVass(ctx context.Context, q *EnqueuedVaaQuery) ([
} }
} }
if len(enqueuedVaas) == 0 {
return nil, errs.ErrNotFound
}
// group by chainID. // group by chainID.
enqueuedVaasGroupedByChainID := map[vaa.ChainID][]*EnqueuedVaa{} enqueuedVaasGroupedByChainID := map[vaa.ChainID][]*EnqueuedVaa{}
for _, f := range enqueuedVaas { for _, f := range enqueuedVaas {

4
api/routes/wormscan/governor/controller.go
View File

@ -305,7 +305,7 @@ func (c *Controller) GetMaxNotionalAvailableByChainID(ctx *fiber.Ctx) error {
return ctx.JSON(response) return ctx.JSON(response)
} }
// GetEnqueueVaas godoc // GetEnqueuedVaas godoc
// @Description Returns enqueued VAAs for each blockchain. // @Description Returns enqueued VAAs for each blockchain.
// @Tags Wormscan // @Tags Wormscan
// @ID governor-enqueued-vaas // @ID governor-enqueued-vaas
@ -316,7 +316,7 @@ func (c *Controller) GetMaxNotionalAvailableByChainID(ctx *fiber.Ctx) error {
// @Failure 400 // @Failure 400
// @Failure 500 // @Failure 500
// @Router /api/v1/governor/enqueued_vaas/ [get] // @Router /api/v1/governor/enqueued_vaas/ [get]
func (c *Controller) GetEnqueueVaas(ctx *fiber.Ctx) error { func (c *Controller) GetEnqueuedVaas(ctx *fiber.Ctx) error {
p, err := middleware.ExtractPagination(ctx) p, err := middleware.ExtractPagination(ctx)
if err != nil { if err != nil {

2
api/routes/wormscan/routes.go
View File

@ -89,6 +89,6 @@ func RegisterRoutes(
governorNotional.Get("/max_available/:chain", governorCtrl.GetMaxNotionalAvailableByChainID) governorNotional.Get("/max_available/:chain", governorCtrl.GetMaxNotionalAvailableByChainID)
enqueueVaas := governor.Group("/enqueued_vaas") enqueueVaas := governor.Group("/enqueued_vaas")
enqueueVaas.Get("/", governorCtrl.GetEnqueueVaas) enqueueVaas.Get("/", governorCtrl.GetEnqueuedVaas)
enqueueVaas.Get("/:chain", governorCtrl.GetEnqueuedVaasByChainID) enqueueVaas.Get("/:chain", governorCtrl.GetEnqueuedVaasByChainID)
} }