273 contract watcher fix status for evm standard (#278)

* Add client to eth transaction Receipt endpoint

* Only process evm transaction from the contractAddress

* Add function to get Status for evm and evm standard watcher

* Fix unkown status and retry count

contract-watcher/go.mod

@@ -12,7 +12,7 @@ require (
 	github.com/sethvargo/go-envconfig v0.9.0
 	github.com/stretchr/testify v1.8.2
 	github.com/wormhole-foundation/wormhole-explorer/common v0.0.0-20230307192542-867f1c29626a
-	github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230308163036-9b3458a90997
+	github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230426150516-e695fad0bed8
 	go.mongodb.org/mongo-driver v1.11.2
 	go.uber.org/ratelimit v0.2.0
 	go.uber.org/zap v1.24.0

contract-watcher/go.sum

@@ -395,8 +395,8 @@ github.com/valyala/fasthttp v1.44.0/go.mod h1:f6VbjjoI3z1NDOZOv17o6RvtRSWxC77seB
 github.com/valyala/fasttemplate v1.0.1/go.mod h1:UQGH1tvbgY+Nz5t2n7tXsz52dQxojPUpymEIMZ47gx8=
 github.com/valyala/tcplisten v1.0.0 h1:rBHj/Xf+E1tRGZyWIWwJDiRY0zc1Js+CV5DqwacVSA8=
 github.com/valyala/tcplisten v1.0.0/go.mod h1:T0xQ8SeCZGxckz9qRXTfG43PvQ/mcWh7FwZEA7Ioqkc=
-github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230308163036-9b3458a90997 h1:K9P4tfL0Q9MuoJjIKMNzwvLJeYHHSoVrIL7CxJfIz8w=
-github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230308163036-9b3458a90997/go.mod h1:dE12DOucCq23gjGGGhtbyx41FBxuHxjpPvG+ArO+8t0=
+github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230426150516-e695fad0bed8 h1:rrOyHd+H9a6Op1iUyZNCaI5v9D1syq8jDAYyX/2Q4L8=
+github.com/wormhole-foundation/wormhole/sdk v0.0.0-20230426150516-e695fad0bed8/go.mod h1:dE12DOucCq23gjGGGhtbyx41FBxuHxjpPvG+ArO+8t0=
 github.com/xdg-go/pbkdf2 v1.0.0 h1:Su7DPu48wXMwC3bs7MCNG+z4FhcyEuz5dlvchbq0B0c=
 github.com/xdg-go/pbkdf2 v1.0.0/go.mod h1:jrpuAogTd400dnrH08LKmI/xc1MbPOebTwRqcT5RDeI=
 github.com/xdg-go/scram v1.1.1/go.mod h1:RaEWvsqvNKKvBPvcKeFjrG2cJqOkHTiyTpzz23ni57g=

contract-watcher/internal/evm/client.go

@@ -78,6 +78,33 @@ func (s *EvmSDK) GetBlock(ctx context.Context, block uint64) (*GetBlockResult, e
 	return &result.Result, nil
 }
 
+func (s *EvmSDK) GetTransactionReceipt(ctx context.Context, txHash string) (*TransactionReceiptResult, error) {
+	s.rl.Take()
+	req := newEvmRequest("eth_getTransactionReceipt", txHash)
+	resp, err := s.client.R().
+		SetContext(ctx).
+		SetBody(req).
+		SetResult(&getTransactionReceiptResponse{}).
+		Post("")
+
+	if err != nil {
+		return nil, err
+	}
+
+	if resp.IsError() {
+		if resp.StatusCode() == http.StatusTooManyRequests {
+			return nil, ErrTooManyRequests
+		}
+		return nil, fmt.Errorf("status code: %s. %s", resp.Status(), string(resp.Body()))
+	}
+
+	result := resp.Result().(*getTransactionReceiptResponse)
+	if result == nil {
+		return nil, fmt.Errorf("empty response")
+	}
+	return &result.Result, nil
+}
+
 func newEvmRequest(method string, params ...any) EvmRequest {
 	return EvmRequest{
 		Jsonrpc: "2.0",

contract-watcher/internal/evm/types.go

@@ -37,6 +37,27 @@ type getBlockResponse struct {
 	Result GetBlockResult `json:"result"`
 }
 
+type getTransactionReceiptResponse struct {
+	Result TransactionReceiptResult `json:"result"`
+}
+
+type TransactionReceiptResult struct {
+	BlockHash         string  `json:"blockHash"`
+	BlockNumber       string  `json:"blockNumber"`
+	ContractAddress   *string `json:"contractAddress"`
+	CumulativeGasUsed string  `json:"cumulativeGasUsed"`
+	EffectiveGasPrice string  `json:"effectiveGasPrice"`
+	From              string  `json:"from"`
+	GasUsed           string  `json:"gasUsed"`
+	Logs              []any   `json:"logs"`
+	LogsBloom         string  `json:"logsBloom"`
+	Status            string  `json:"status"`
+	To                *string `json:"to"`
+	TransactionHash   *string `json:"transactionHash"`
+	TransactionIndex  *string `json:"transactionIndex"`
+	Type              string  `json:"type"`
+}
+
 type EvmRequest struct {
 	Jsonrpc string `json:"jsonrpc"`
 	Method  string `json:"method"`

contract-watcher/watcher/evm.go

@@ -47,17 +47,19 @@ type EVMParams struct {
 	InitialBlock    int64
 }
 
+type EvmGetStatusFunc func() (string, error)
+
 type EvmTransaction struct {
 	Hash           string
 	From           string
 	To             string
-	Status         string
+	Status         EvmGetStatusFunc
 	BlockNumber    string
 	BlockTimestamp string
 	Input          string
 }
 
-// get transaction status
+// get gloabal transaction status from evm blockchain status code.
 func getTxStatus(status string) string {
 	switch status {
 	case TxStatusSuccess:
@@ -65,6 +67,9 @@ func getTxStatus(status string) string {
 	case TxStatusFailReverted:
 		return TxStatusFailedToProcess
 	default:
+		if status == "" {
+			return TxStatusUnkonwn
+		}
 		return fmt.Sprintf("%s: %s", TxStatusUnkonwn, status)
 	}
 }
@@ -150,12 +155,19 @@ func processTransaction(ctx context.Context, chainID vaa.ChainID, tx *EvmTransac
 			return
 		}
 
+		// get evm blockchain status code
+		txStatusCode, err := tx.Status()
+		if err != nil {
+			log.Error("cannot get tx status", zap.Error(err))
+			return
+		}
+
 		updatedAt := time.Now()
 		globalTx := storage.TransactionUpdate{
 			ID: vaa.MessageID(),
 			Destination: storage.DestinationTx{
 				ChainID:     chainID,
-				Status:      getTxStatus(tx.Status),
+				Status:      getTxStatus(txStatusCode),
 				Method:      getMethodByInput(tx.Input),
 				TxHash:      support.Remove0x(tx.Hash),
 				To:          tx.To,

contract-watcher/watcher/evm_standard_watcher.go

@@ -13,7 +13,7 @@ import (
 )
 
 const (
-	evmMaxRetries = 10
+	evmMaxRetries = 5
 	evmRetryDelay = 5 * time.Second
 )
 
@@ -119,11 +119,41 @@ func (w *EvmStandarWatcher) processBlock(ctx context.Context, fromBlock uint64,
 				}
 
 				for _, tx := range blockResult.Transactions {
+
+					// only process transactions to the contract address.
+					if w.contractAddress != tx.To {
+						continue
+					}
+
 					evmTx := &EvmTransaction{
-						Hash:           tx.Hash,
-						From:           tx.From,
-						To:             tx.To,
-						Status:         TxStatusSuccess,
+						Hash: tx.Hash,
+						From: tx.From,
+						To:   tx.To,
+						Status: func() (string, error) {
+							var status string
+							// add retry to get the transaction receipt.
+							err := retry.Do(
+								func() error {
+									tranctionReceipt, err := w.client.GetTransactionReceipt(ctx, tx.Hash)
+									if err != nil {
+										w.logger.Error("cannot get tranction receipt",
+											zap.Uint64("block", block),
+											zap.String("txHash", tx.Hash),
+											zap.Error(err))
+										if err == evm.ErrTooManyRequests {
+											return err
+										}
+										return nil
+									}
+									// get the status of the transaction
+									status = tranctionReceipt.Status
+									return nil
+								},
+								retry.Attempts(evmMaxRetries),
+								retry.Delay(evmRetryDelay),
+							)
+							return status, err
+						},
 						BlockNumber:    tx.BlockNumber,
 						BlockTimestamp: blockResult.Timestamp,
 						Input:          tx.Input,

contract-watcher/watcher/evm_watcher.go

@@ -122,10 +122,12 @@ func (w *EVMWatcher) processBlock(ctx context.Context, currentBlock int64, lastB
 		var lastBlockNumberHex string
 		for _, tx := range r.Result.Transactions {
 			evmTx := &EvmTransaction{
-				Hash:           tx.Hash,
-				From:           tx.From,
-				To:             tx.To,
-				Status:         tx.Status,
+				Hash: tx.Hash,
+				From: tx.From,
+				To:   tx.To,
+				Status: func() (string, error) {
+					return tx.Status, nil
+				},
 				BlockNumber:    tx.BlockNumber,
 				BlockTimestamp: tx.Timestamp,
 				Input:          tx.Input,