certusone
/
wormhole
mirror of https://github.com/certusone/wormhole.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node/pkg/ethereum: correctly log "not found" error 

commit-id:23a5fd80
This commit is contained in:
Leo 2022-01-10 20:13:33 +01:00 committed by Leopold Schabel
parent 81d1e821c0
commit 146c08d5af
1 changed files with 32 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
node/pkg/ethereum/watcher.go
View File

@ -306,6 +306,7 @@ func (e *Watcher) Run(ctx context.Context) error {
zap.Stringer("current_blockhash", currentHash),
zap.String("eth_network", e.networkName),
)
ethMessagesOrphaned.WithLabelValues(e.networkName, "timeout").Inc()
delete(e.pending, key)
continue
}
@ -315,7 +316,32 @@ func (e *Watcher) Run(ctx context.Context) error {
timeout, cancel = context.WithTimeout(ctx, 15*time.Second)
tx, err := c.TransactionReceipt(timeout, pLock.message.TxHash)
cancel()
if err != nil && err != rpc.ErrNoResult {
// If the node returns an error after waiting expectedConfirmation blocks,
// it means the chain reorged and the transaction was orphaned. The
// TransactionReceipt call is using the same websocket connection than the
// head notifications, so it's guaranteed to be atomic.
//
// Check multiple possible error cases - the node seems to return a
// "not found" error most of the time, but it could conceivably also
// return a nil tx or rpc.ErrNoResult.
if tx == nil || err == rpc.ErrNoResult || (err != nil && err.Error() == "not found") {
logger.Info("tx was orphaned",
zap.Stringer("tx", pLock.message.TxHash),
zap.Stringer("blockhash", key.BlockHash),
zap.Stringer("emitter_address", key.EmitterAddress),
zap.Uint64("sequence", key.Sequence),
zap.Stringer("current_block", ev.Number),
zap.Stringer("current_blockhash", currentHash),
zap.String("eth_network", e.networkName),
zap.Error(err))
delete(e.pending, key)
ethMessagesOrphaned.WithLabelValues(e.networkName, "not_found").Inc()
continue
}
// Any error other than "not found" is likely transient - we retry next block.
if err != nil {
logger.Warn("transaction could not be fetched",
zap.Stringer("tx", pLock.message.TxHash),
zap.Stringer("blockhash", key.BlockHash),
@ -327,19 +353,10 @@ func (e *Watcher) Run(ctx context.Context) error {
zap.Error(err))
continue
}
if tx == nil || err == rpc.ErrNoResult {
logger.Info("tx was orphaned",
zap.Stringer("tx", pLock.message.TxHash),
zap.Stringer("blockhash", key.BlockHash),
zap.Stringer("emitter_address", key.EmitterAddress),
zap.Uint64("sequence", key.Sequence),
zap.Stringer("current_block", ev.Number),
zap.Stringer("current_blockhash", currentHash),
zap.String("eth_network", e.networkName))
delete(e.pending, key)
ethMessagesOrphaned.WithLabelValues(e.networkName, "not_found").Inc()
continue
}
// It's possible for a transaction to be orphaned and then included in a different block
// but with the same tx hash. Drop the observation (it will be re-observed and needs to
// wait for the full confirmation time again).
if tx.BlockHash != key.BlockHash {
logger.Info("tx got dropped and mined in a different block; the message should have been reobserved",
zap.Stringer("tx", pLock.message.TxHash),
@ -353,6 +370,7 @@ func (e *Watcher) Run(ctx context.Context) error {
ethMessagesOrphaned.WithLabelValues(e.networkName, "blockhash_mismatch").Inc()
continue
}
logger.Info("observation confirmed",
zap.Stringer("tx", pLock.message.TxHash),
zap.Stringer("blockhash", key.BlockHash),