certusone
/
wormhole
mirror of https://github.com/certusone/wormhole.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Code review rework

This commit is contained in:
Bruce Riley 2024-08-16 09:13:48 -05:00 committed by Evan Gray
parent b06132d638
commit 22eecc6b72
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ethereum/README.md
View File

@ -71,7 +71,7 @@ ethereum$ MNEMONIC= ./sh/upgrade.sh testnet TokenBridge blast
#### Registering Other Chains on a New TokenBridge #### Registering Other Chains on a New TokenBridge
```shell ```shell
ethereum$ MNEMONIC= ./sh/registerAllChainsOnTokenBridge.sh testnet blast ethereum$ MNEMONIC= ./sh/registerAllChainsOnTokenBridge.sh.sh testnet blast
``` ```
### Deploying using Truffle (deprecated) ### Deploying using Truffle (deprecated)

2
ethereum/env/.env.snaxchain.testnet vendored
View File

@ -17,5 +17,5 @@ BRIDGE_INIT_CHAIN_ID=43
BRIDGE_INIT_GOV_CHAIN_ID=0x1 BRIDGE_INIT_GOV_CHAIN_ID=0x1
BRIDGE_INIT_GOV_CONTRACT=0x0000000000000000000000000000000000000000000000000000000000000004 BRIDGE_INIT_GOV_CONTRACT=0x0000000000000000000000000000000000000000000000000000000000000004
BRIDGE_INIT_FINALITY=1 BRIDGE_INIT_FINALITY=1
# I think this is right. It’s what we use on Optimism, and it exists on Snax. . . # Snaxchain is an OP Stack chain and therefore has the same WETH address. https://docs.optimism.io/stack/protocol/features/custom-gas-token#what-is-the-wrapped-erc-20-gas-token
BRIDGE_INIT_WETH=0x4200000000000000000000000000000000000006 BRIDGE_INIT_WETH=0x4200000000000000000000000000000000000006

9
node/pkg/governor/mainnet_tokens_test.go
View File

@ -6,7 +6,6 @@ import (
"testing" "testing"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/wormhole-foundation/wormhole/sdk/vaa" "github.com/wormhole-foundation/wormhole/sdk/vaa"
) )
@ -77,9 +76,11 @@ func TestGovernedChainHasGovernedAssets(t *testing.T) {
// Make sure we're not ignoring any chains with governed tokens. // Make sure we're not ignoring any chains with governed tokens.
for _, tokenEntry := range tokenList() { for _, tokenEntry := range tokenList() {
if _, exists := ignoredChains[vaa.ChainID(tokenEntry.chain)]; exists { t.Run(vaa.ChainID(tokenEntry.chain).String(), func(t *testing.T) {
require.Equal(t, "", fmt.Sprintf("Chain %s is in ignoredChains but it has governed tokens", vaa.ChainID(tokenEntry.chain))) if _, exists := ignoredChains[vaa.ChainID(tokenEntry.chain)]; exists {
} assert.Fail(t, "Chain is in ignoredChains but it has governed tokens")
}
})
} }
} }