sdk: enforce single canonical VerifySignatures method (#1995)

This commit is contained in:
Nikhil Suri 2022-11-30 10:42:07 -08:00 committed by GitHub
parent 63a5654c02
commit 88293f36eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 8 deletions

View File

@ -632,6 +632,9 @@ func (v *BatchVAA) ObsvHashArray() []common.Hash {
}
func VerifySignatures(data []byte, signatures []*Signature, addresses []common.Address) bool {
if len(addresses) < len(signatures) {
return false
}
last_index := -1
signing_addresses := []common.Address{}
@ -674,20 +677,12 @@ func VerifySignatures(data []byte, signatures []*Signature, addresses []common.A
// VerifySignatures verifies the signature of the VAA given the signer addresses.
// Returns true if the signatures were verified successfully.
func (v *VAA) VerifySignatures(addresses []common.Address) bool {
if len(addresses) < len(v.Signatures) {
return false
}
return VerifySignatures(v.SigningMsg().Bytes(), v.Signatures, addresses)
}
// VerifySignatures verifies the signature of the BatchVAA given the signer addresses.
// Returns true if the signatures were verified successfully.
func (v *BatchVAA) VerifySignatures(addresses []common.Address) bool {
if len(addresses) < len(v.Signatures) {
return false
}
return VerifySignatures(v.SigningMsg().Bytes(), v.Signatures, addresses)
}