certusone
/
wormhole
mirror of https://github.com/certusone/wormhole.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

terra: Ensure that recipient address is 32 bytes. 

Before this check, users were able to lose funds by sending money to an
address that's shorter than 32 bytes.
This commit is essentially a backport of the fix from the new cosmwasm contract.
This commit is contained in:
Csongor Kiss 2022-08-05 09:33:11 -05:00 committed by Csongor Kiss
parent 45de97015c
commit aea76be327
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/js/src/token_bridge/__tests__/terra-integration.ts
View File

@ -122,9 +122,7 @@ describe("Terra Integration Tests", () => {
},
},
recipient_chain: CHAIN_ID_ETH,
recipient: Buffer.from(await signer.getAddress()).toString(
"base64"
),
recipient: Buffer.from(tryNativeToUint8Array(await signer.getAddress(), 'ethereum')).toString('base64'),
fee: "0",
nonce: Math.round(Math.round(Math.random() * 100000)),
},

16
terra/contracts/token-bridge/src/contract.rs
View File

@ -275,7 +275,7 @@ pub fn execute(deps: DepsMut, env: Env, info: MessageInfo, msg: ExecuteMsg) -> S
info,
asset,
recipient_chain,
recipient.into(),
recipient.to_array()?,
fee,
TransferType::WithoutPayload,
nonce,
@ -293,7 +293,7 @@ pub fn execute(deps: DepsMut, env: Env, info: MessageInfo, msg: ExecuteMsg) -> S
info,
asset,
recipient_chain,
recipient.into(),
recipient.to_array()?,
fee,
TransferType::WithPayload {
payload: payload.into(),
@ -972,7 +972,7 @@ fn handle_initiate_transfer(
info: MessageInfo,
asset: Asset,
recipient_chain: u16,
recipient: Vec<u8>,
recipient: [u8; 32],
fee: Uint128,
transfer_type: TransferType<Vec<u8>>,
nonce: u32,
@ -1012,7 +1012,7 @@ fn handle_initiate_transfer_token(
asset: HumanAddr,
mut amount: Uint128,
recipient_chain: u16,
recipient: Vec<u8>,
recipient: [u8; 32],
mut fee: Uint128,
transfer_type: TransferType<Vec<u8>>,
nonce: u32,
@ -1063,7 +1063,7 @@ fn handle_initiate_transfer_token(
token_address: asset_address.clone(),
amount: (0, amount.u128()),
recipient_chain,
recipient: recipient.clone(),
recipient: recipient.to_vec(),
fee: (0, fee.u128()),
};
@ -1143,7 +1143,7 @@ fn handle_initiate_transfer_token(
token_address: asset_address.clone(),
amount: (0, amount.u128()),
recipient_chain,
recipient: recipient.clone(),
recipient: recipient.to_vec(),
fee: (0, fee.u128()),
};
@ -1229,7 +1229,7 @@ fn handle_initiate_transfer_native_token(
denom: String,
amount: Uint128,
recipient_chain: u16,
recipient: Vec<u8>,
recipient: [u8; 32],
fee: Uint128,
transfer_type: TransferType<Vec<u8>>,
nonce: u32,
@ -1269,7 +1269,7 @@ fn handle_initiate_transfer_native_token(
token_address: asset_address.to_vec(),
amount: (0, amount.u128()),
recipient_chain,
recipient: recipient.clone(),
recipient: recipient.to_vec(),
fee: (0, fee.u128()),
};