From d436ac2166af390b7c946252ccdfd852628b825f Mon Sep 17 00:00:00 2001 From: tbjump Date: Wed, 3 May 2023 23:17:49 +0000 Subject: [PATCH] node/governor fix potential nil ptr deref in reloadPendingTransfer --- node/pkg/governor/governor_db.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/node/pkg/governor/governor_db.go b/node/pkg/governor/governor_db.go index b7414dd2b..b47f650d3 100644 --- a/node/pkg/governor/governor_db.go +++ b/node/pkg/governor/governor_db.go @@ -89,6 +89,10 @@ func (gov *ChainGovernor) reloadPendingTransfer(pending *db.PendingTransfer, now payload, err := vaa.DecodeTransferPayloadHdr(msg.Payload) if err != nil { + if payload == nil { + // avoid nil ptr deref + payload = &vaa.TransferPayloadHdr{} + } gov.logger.Error("failed to parse payload for reloaded pending transfer, dropping it", zap.String("MsgID", msg.MessageIDString()), zap.Stringer("TxHash", msg.TxHash),