diff --git a/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCell.java b/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCell.java index 2cfe711f7..5c01cc9d2 100644 --- a/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCell.java +++ b/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCell.java @@ -268,7 +268,7 @@ public class ContributedLibraryTableCell extends InstallerTableCell { Lists.newLinkedList(Lists.transform(uninstalledReleases, new Function() { @Override public ContributedLibrary apply(ContributedLibrary input) { - if (installed == null || VersionComparator.VERSION_COMPARATOR.greaterThan(installed.getVersion(), input.getVersion())) { + if (installed == null || VersionComparator.VERSION_COMPARATOR.greaterThan(installed.getParsedVersion(), input.getParsedVersion())) { uninstalledPreviousReleases.add(input); } else { uninstalledNewerReleases.add(input); @@ -357,7 +357,7 @@ public class ContributedLibraryTableCell extends InstallerTableCell { // ...version. if (installed != null) { - Version installedVer = VersionHelper.valueOf(installed.getVersion()); + String installedVer = installed.getParsedVersion(); if (installedVer == null) { desc += " " + _("Version unknown"); } else { diff --git a/app/src/cc/arduino/contributions/libraries/ui/LibrariesIndexTableModel.java b/app/src/cc/arduino/contributions/libraries/ui/LibrariesIndexTableModel.java index 2ad94c7e7..47c12a897 100644 --- a/app/src/cc/arduino/contributions/libraries/ui/LibrariesIndexTableModel.java +++ b/app/src/cc/arduino/contributions/libraries/ui/LibrariesIndexTableModel.java @@ -54,13 +54,13 @@ public class LibrariesIndexTableModel extends FilteredAbstractTableModel releases; - public final List versions; + public final List versions; public ContributedLibrary selected; public ContributedLibraryReleases(ContributedLibrary library) { this.name = library.getName(); - this.versions = new LinkedList(); + this.versions = new LinkedList(); this.releases = new LinkedList(); this.selected = null; add(library); @@ -72,7 +72,7 @@ public class LibrariesIndexTableModel extends FilteredAbstractTableModel getReleasesVersions(int row) { - return contributions.get(row).versions; - } - public ContributedLibraryReleases getReleases(int row) { return contributions.get(row); } diff --git a/app/src/cc/arduino/contributions/libraries/ui/LibraryInstaller.java b/app/src/cc/arduino/contributions/libraries/ui/LibraryInstaller.java index fdb5cf790..d099f3a7a 100644 --- a/app/src/cc/arduino/contributions/libraries/ui/LibraryInstaller.java +++ b/app/src/cc/arduino/contributions/libraries/ui/LibraryInstaller.java @@ -100,8 +100,9 @@ public class LibraryInstaller { } public void install(ContributedLibrary lib, ContributedLibrary replacedLib) throws Exception { - if (lib.isInstalled()) + if (lib.isInstalled()) { throw new Exception(_("Library is already installed!")); + } final MultiStepProgress progress = new MultiStepProgress(3); diff --git a/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCell.java b/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCell.java index e4690354f..8cddf1e0f 100644 --- a/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCell.java +++ b/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCell.java @@ -282,7 +282,7 @@ public class ContributedPlatformTableCell extends InstallerTableCell { Lists.newLinkedList(Lists.transform(uninstalledReleases, new Function() { @Override public ContributedPlatform apply(ContributedPlatform input) { - if (installed == null || VersionComparator.VERSION_COMPARATOR.greaterThan(installed.getVersion(), input.getVersion())) { + if (installed == null || VersionComparator.VERSION_COMPARATOR.greaterThan(installed.getParsedVersion(), input.getParsedVersion())) { uninstalledPreviousReleases.add(input); } else { uninstalledNewerReleases.add(input); @@ -357,7 +357,7 @@ public class ContributedPlatformTableCell extends InstallerTableCell { desc += " " + format("by {0}", author); } if (installed != null) { - desc += " " + format(_("version {0}"), VersionHelper.valueOf(installed.getVersion())) + " INSTALLED"; + desc += " " + format(_("version {0}"), installed.getParsedVersion()) + " INSTALLED"; } desc += "
"; diff --git a/app/src/cc/arduino/contributions/packages/ui/ContributionIndexTableModel.java b/app/src/cc/arduino/contributions/packages/ui/ContributionIndexTableModel.java index 06089f6eb..bf0880e70 100644 --- a/app/src/cc/arduino/contributions/packages/ui/ContributionIndexTableModel.java +++ b/app/src/cc/arduino/contributions/packages/ui/ContributionIndexTableModel.java @@ -54,14 +54,14 @@ public class ContributionIndexTableModel extends FilteredAbstractTableModel releases; - public final List versions; + public final List versions; public ContributedPlatform selected = null; public ContributedPlatformReleases(ContributedPlatform platform) { this.packager = platform.getParentPackage(); this.arch = platform.getArchitecture(); this.releases = new LinkedList(); - this.versions = new LinkedList(); + this.versions = new LinkedList(); add(platform); } @@ -73,7 +73,7 @@ public class ContributionIndexTableModel extends FilteredAbstractTableModel getReleasesVersions(int row) { - return contributions.get(row).versions; - } - public ContributedPlatformReleases getReleases(int row) { return contributions.get(row); } diff --git a/app/src/cc/arduino/contributions/ui/FilteredAbstractTableModel.java b/app/src/cc/arduino/contributions/ui/FilteredAbstractTableModel.java index 05999ad37..7391acedc 100644 --- a/app/src/cc/arduino/contributions/ui/FilteredAbstractTableModel.java +++ b/app/src/cc/arduino/contributions/ui/FilteredAbstractTableModel.java @@ -47,7 +47,7 @@ public abstract class FilteredAbstractTableModel extends AbstractTableModel { Collections.sort(contribs, new Comparator() { @Override public int compare(T contrib1, T contrib2) { - return VersionComparator.VERSION_COMPARATOR.compare(contrib1.getVersion(), contrib2.getVersion()); + return VersionComparator.VERSION_COMPARATOR.compare(contrib1.getParsedVersion(), contrib2.getParsedVersion()); } }); diff --git a/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibrary.java b/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibrary.java index bec9873e1..2dd604d4e 100644 --- a/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibrary.java +++ b/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibrary.java @@ -98,7 +98,7 @@ public abstract class ContributedLibrary extends DownloadableContribution { @Override public String toString() { - return I18n.format(_("Version {0}"), getVersion()); + return I18n.format(_("Version {0}"), getParsedVersion()); } public String info() { @@ -106,7 +106,7 @@ public abstract class ContributedLibrary extends DownloadableContribution { res += " ContributedLibrary : " + getName() + "\n"; res += " author : " + getAuthor() + "\n"; res += " maintainer : " + getMaintainer() + "\n"; - res += " version : " + getVersion() + "\n"; + res += " version : " + getParsedVersion() + "\n"; res += " website : " + getUrl() + "\n"; res += " category : " + getCategory() + "\n"; res += " license : " + getLicense() + "\n"; @@ -138,8 +138,8 @@ public abstract class ContributedLibrary extends DownloadableContribution { return false; } - String thisVersion = getVersion(); - String otherVersion = ((ContributedLibrary) obj).getVersion(); + String thisVersion = getParsedVersion(); + String otherVersion = ((ContributedLibrary) obj).getParsedVersion(); boolean versionEquals = thisVersion == null || otherVersion == null || thisVersion.equals(otherVersion); diff --git a/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibraryComparator.java b/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibraryComparator.java index dbc80dfc4..fb35f4b35 100644 --- a/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibraryComparator.java +++ b/arduino-core/src/cc/arduino/contributions/libraries/ContributedLibraryComparator.java @@ -8,7 +8,7 @@ public class ContributedLibraryComparator implements Comparator 0) + if (version.compare(p.getParsedVersion(), found.getParsedVersion()) > 0) found = p; } return found; @@ -98,7 +97,7 @@ public abstract class ContributedPackage { } res += "\n category : " + plat.getCategory(); res += "\n architecture : " + - plat.getArchitecture() + " " + plat.getVersion() + "\n"; + plat.getArchitecture() + " " + plat.getParsedVersion() + "\n"; if (plat.getToolsDependencies() != null) for (ContributedToolReference t : plat.getToolsDependencies()) { res += " tool dep : " + t.getName() + " " + diff --git a/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java b/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java index ce8460d70..e3e43549a 100644 --- a/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java +++ b/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java @@ -87,6 +87,6 @@ public abstract class ContributedPlatform extends DownloadableContribution { @Override public String toString() { - return getVersion(); + return getParsedVersion(); } } diff --git a/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatformComparator.java b/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatformComparator.java index 872439ffa..83a31bdfa 100644 --- a/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatformComparator.java +++ b/arduino-core/src/cc/arduino/contributions/packages/ContributedPlatformComparator.java @@ -8,7 +8,7 @@ public class ContributedPlatformComparator implements Comparator