From 8c83281a194bfc86033771d4a391291a69e3d0e4 Mon Sep 17 00:00:00 2001 From: Federico Fissore Date: Thu, 28 May 2015 14:55:05 +0200 Subject: [PATCH] Do not cache PrinterJob instances. Cache is evil --- app/src/processing/app/Editor.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/app/src/processing/app/Editor.java b/app/src/processing/app/Editor.java index ea4da1b8d..f5d6518f0 100644 --- a/app/src/processing/app/Editor.java +++ b/app/src/processing/app/Editor.java @@ -119,7 +119,6 @@ public class Editor extends JFrame implements RunnerListener { boolean untitled; PageFormat pageFormat; - PrinterJob printerJob; // file, sketch, and tools menus for re-inserting items JMenu fileMenu; @@ -2760,15 +2759,11 @@ public class Editor extends JFrame implements RunnerListener { * Handler for File → Page Setup. */ public void handlePageSetup() { - //printerJob = null; - if (printerJob == null) { - printerJob = PrinterJob.getPrinterJob(); - } + PrinterJob printerJob = PrinterJob.getPrinterJob(); if (pageFormat == null) { pageFormat = printerJob.defaultPage(); } pageFormat = printerJob.pageDialog(pageFormat); - //System.out.println("page format is " + pageFormat); } @@ -2778,9 +2773,7 @@ public class Editor extends JFrame implements RunnerListener { public void handlePrint() { statusNotice(_("Printing...")); //printerJob = null; - if (printerJob == null) { - printerJob = PrinterJob.getPrinterJob(); - } + PrinterJob printerJob = PrinterJob.getPrinterJob(); if (pageFormat != null) { //System.out.println("setting page format " + pageFormat); printerJob.setPrintable(textarea, pageFormat);