From f34787d100d22c2893320e1e9781110491371e0f Mon Sep 17 00:00:00 2001 From: Ankit Daftery Date: Thu, 3 Jul 2014 13:08:12 +0530 Subject: [PATCH 1/3] Update HelloWorld.ino Adding power connections, just to be thorough --- libraries/LiquidCrystal/examples/HelloWorld/HelloWorld.ino | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/LiquidCrystal/examples/HelloWorld/HelloWorld.ino b/libraries/LiquidCrystal/examples/HelloWorld/HelloWorld.ino index e99957d9a..eaf0f6f2d 100644 --- a/libraries/LiquidCrystal/examples/HelloWorld/HelloWorld.ino +++ b/libraries/LiquidCrystal/examples/HelloWorld/HelloWorld.ino @@ -17,6 +17,8 @@ * LCD D6 pin to digital pin 3 * LCD D7 pin to digital pin 2 * LCD R/W pin to ground + * LCD VSS pin to ground + * LCD VCC pin to 5V * 10K resistor: * ends to +5V and ground * wiper to LCD VO pin (pin 3) From 865594d132f388f9b6eed6597ee40e6a1daba602 Mon Sep 17 00:00:00 2001 From: Amulya Kumar Sahoo Date: Wed, 23 Jul 2014 01:03:44 +0530 Subject: [PATCH 2/3] Fix of a bug --- hardware/arduino/cores/arduino/HID.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hardware/arduino/cores/arduino/HID.cpp b/hardware/arduino/cores/arduino/HID.cpp index ac6360844..553b7463c 100644 --- a/hardware/arduino/cores/arduino/HID.cpp +++ b/hardware/arduino/cores/arduino/HID.cpp @@ -106,7 +106,7 @@ const u8 _hidReportDescriptor[] = { 0x81, 0x00, // INPUT (Data,Ary,Abs) 0xc0, // END_COLLECTION -#if RAWHID_ENABLED +#ifdef RAWHID_ENABLED // RAW HID 0x06, LSB(RAWHID_USAGE_PAGE), MSB(RAWHID_USAGE_PAGE), // 30 0x0A, LSB(RAWHID_USAGE), MSB(RAWHID_USAGE), @@ -517,4 +517,4 @@ size_t Keyboard_::write(uint8_t c) #endif -#endif /* if defined(USBCON) */ \ No newline at end of file +#endif /* if defined(USBCON) */ From 97dc72ce05ddaeb9979c02b07a31031116ebbfc3 Mon Sep 17 00:00:00 2001 From: Amulya Kumar Sahoo Date: Wed, 23 Jul 2014 01:17:31 +0530 Subject: [PATCH 3/3] Fix of a spelling mistake --- libraries/LiquidCrystal/LiquidCrystal.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/LiquidCrystal/LiquidCrystal.cpp b/libraries/LiquidCrystal/LiquidCrystal.cpp index 0653487d7..d7bd9e453 100644 --- a/libraries/LiquidCrystal/LiquidCrystal.cpp +++ b/libraries/LiquidCrystal/LiquidCrystal.cpp @@ -96,7 +96,7 @@ void LiquidCrystal::begin(uint8_t cols, uint8_t lines, uint8_t dotsize) { // SEE PAGE 45/46 FOR INITIALIZATION SPECIFICATION! // according to datasheet, we need at least 40ms after power rises above 2.7V - // before sending commands. Arduino can turn on way befer 4.5V so we'll wait 50 + // before sending commands. Arduino can turn on way before 4.5V so we'll wait 50 delayMicroseconds(50000); // Now we pull both RS and R/W low to begin commands digitalWrite(_rs_pin, LOW);