noisymime
/
speeduino-personal
mirror of https://github.com/noisymime/speeduino-personal.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow 6g72 patterns under the new sync method of the 4g63 decoder. #76

This commit is contained in:
Josh Stewart 2018-06-17 15:16:22 +10:00
parent 600fa72f7f
commit e5ea1ce36e
4 changed files with 119 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
reference/speeduino.ini
View File

@ -1376,7 +1376,7 @@ menuDialog = main
field = "Skip Revolutions", SkipCycles field = "Skip Revolutions", SkipCycles
field = "Note: This is the number of revolutions that will be skipped during" field = "Note: This is the number of revolutions that will be skipped during"
field = "cranking before the injectors and coils are fired" field = "cranking before the injectors and coils are fired"
field = "Trigger edge", TrigEdge field = "Trigger edge", TrigEdge { TrigPattern != 4 } ;4G63 uses both edges
field = "Secondary trigger edge", TrigEdgeSec, { TrigPattern == 0 || TrigPattern == 2 || TrigPattern == 9 || TrigPattern == 12 } ;Missing tooth, dual wheel and Miata 9905 field = "Secondary trigger edge", TrigEdgeSec, { TrigPattern == 0 || TrigPattern == 2 || TrigPattern == 9 || TrigPattern == 12 } ;Missing tooth, dual wheel and Miata 9905
field = "Missing Tooth Secondary type" trigPatternSec, { TrigPattern == 0 } field = "Missing Tooth Secondary type" trigPatternSec, { TrigPattern == 0 }
field = "Trigger Filter", TrigFilter field = "Trigger Filter", TrigFilter

2
speeduino/decoders.h
View File

@ -12,7 +12,7 @@
#endif #endif
static inline void addToothLogEntry(unsigned long); static inline void addToothLogEntry(unsigned long);
static inline uint16_t stdGetRPM(); static inline uint16_t stdGetRPM(uint16_t degreesOver);
static inline void setFilter(unsigned long); static inline void setFilter(unsigned long);
static inline int crankingGetRPM(byte); static inline int crankingGetRPM(byte);
static inline void doPerToothTiming(uint16_t crankAngle); static inline void doPerToothTiming(uint16_t crankAngle);

135
speeduino/decoders.ino
View File

@ -44,8 +44,8 @@ As nearly all the decoders use a common method of determining RPM (The time the
A common function is simpler A common function is simpler
degreesOver is the number of crank degrees between tooth #1s. Some patterns have a tooth #1 every crank rev, others are every cam rev. degreesOver is the number of crank degrees between tooth #1s. Some patterns have a tooth #1 every crank rev, others are every cam rev.
*/ */
//static inline uint16_t stdGetRPM(uin16_t degreesOver) static inline uint16_t stdGetRPM(uint16_t degreesOver=360)
static inline uint16_t stdGetRPM() //static inline uint16_t stdGetRPM()
{ {
uint16_t tempRPM = 0; uint16_t tempRPM = 0;
@ -58,7 +58,7 @@ static inline uint16_t stdGetRPM()
noInterrupts(); noInterrupts();
revolutionTime = (toothOneTime - toothOneMinusOneTime); //The time in uS that one revolution would take at current speed (The time tooth 1 was last seen, minus the time it was seen prior to that) revolutionTime = (toothOneTime - toothOneMinusOneTime); //The time in uS that one revolution would take at current speed (The time tooth 1 was last seen, minus the time it was seen prior to that)
interrupts(); interrupts();
//if(degreesOver == 720) { revolutionTime / 2; } if(degreesOver == 720) { revolutionTime = revolutionTime / 2; }
tempRPM = (US_IN_MINUTE / revolutionTime); //Calc RPM based on last full revolution time (Faster as /) tempRPM = (US_IN_MINUTE / revolutionTime); //Calc RPM based on last full revolution time (Faster as /)
if(tempRPM >= MAX_RPM) { tempRPM = currentStatus.RPM; } //Sanity check if(tempRPM >= MAX_RPM) { tempRPM = currentStatus.RPM; } //Sanity check
} }
@ -694,7 +694,7 @@ void triggerSetup_4G63()
//Note that these angles are for every rising and falling edge //Note that these angles are for every rising and falling edge
if(configPage2.nCylinders == 6) if(configPage2.nCylinders == 6)
{ {
// 70 / 50 for 6 cylinder applications // 70 / 50 for 6 cylinder applications (50 high, 70 low)
toothAngles[0] = 185; // toothAngles[0] = 185; //
toothAngles[1] = 235; // toothAngles[1] = 235; //
toothAngles[2] = 305; // toothAngles[2] = 305; //
@ -702,7 +702,22 @@ void triggerSetup_4G63()
toothAngles[4] = 65; // toothAngles[4] = 65; //
toothAngles[5] = 115; // toothAngles[5] = 115; //
triggerActualTeeth = 6; //New values below
toothAngles[0] = 715; //Rising edge of tooth #1
toothAngles[1] = 45; //Falling edge of tooth #1
toothAngles[2] = 115; //Rising edge of tooth #2
toothAngles[3] = 165; //Falling edge of tooth #2
toothAngles[4] = 235; //Rising edge of tooth #3
toothAngles[5] = 285; //Falling edge of tooth #3
toothAngles[6] = 355; //Rising edge of tooth #4
toothAngles[7] = 405; //Falling edge of tooth #4
toothAngles[8] = 475; //Rising edge of tooth #5
toothAngles[9] = 525; //Falling edge of tooth $5
toothAngles[10] = 595; //Rising edge of tooth #6
toothAngles[11] = 645; //Falling edge of tooth #6
triggerActualTeeth = 12; //Both sides of all teeth over 720 degrees
} }
else else
{ {
@ -755,7 +770,7 @@ void triggerPri_4G63()
toothCurrentCount++; toothCurrentCount++;
if( (toothCurrentCount == 1) || (toothCurrentCount > triggerActualTeeth) ) //Trigger is on CHANGE, hence 4 pulses = 1 crank rev if( (toothCurrentCount == 1) || (toothCurrentCount > triggerActualTeeth) ) //Trigger is on CHANGE, hence 4 pulses = 1 crank rev (or 6 pulses for 6 cylinders)
{ {
toothCurrentCount = 1; //Reset the counter toothCurrentCount = 1; //Reset the counter
toothOneMinusOneTime = toothOneTime; toothOneMinusOneTime = toothOneTime;
@ -776,9 +791,9 @@ void triggerPri_4G63()
} }
else if(configPage2.nCylinders == 6) else if(configPage2.nCylinders == 6)
{ {
if( toothCurrentCount == 1 ) { endCoil1Charge(); } if( toothCurrentCount == 1 || (toothCurrentCount == 7) ) { endCoil1Charge(); }
else if( toothCurrentCount == 3 ) { endCoil2Charge(); } else if( toothCurrentCount == 3 || (toothCurrentCount == 9) ) { endCoil2Charge(); }
else if( toothCurrentCount == 5 ) { endCoil3Charge(); } else if( toothCurrentCount == 5 || (toothCurrentCount == 11) ) { endCoil3Charge(); }
} }
} }
@ -786,7 +801,7 @@ void triggerPri_4G63()
if( (configPage4.triggerFilter == 1) || (currentStatus.RPM < 1400) ) if( (configPage4.triggerFilter == 1) || (currentStatus.RPM < 1400) )
{ {
//Lite filter //Lite filter
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
{ {
triggerToothAngle = 70; triggerToothAngle = 70;
triggerFilterTime = curGap; //Trigger filter is set to whatever time it took to do 70 degrees (Next trigger is 110 degrees away) triggerFilterTime = curGap; //Trigger filter is set to whatever time it took to do 70 degrees (Next trigger is 110 degrees away)
@ -809,21 +824,75 @@ void triggerPri_4G63()
else if(configPage4.triggerFilter == 2) else if(configPage4.triggerFilter == 2)
{ {
//Medium filter level //Medium filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; triggerFilterTime = (curGap * 5) >> 2 ; } //87.5 degrees with a target of 110 if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
else { triggerToothAngle = 110; triggerFilterTime = (curGap >> 1); } //55 degrees with a target of 70 {
triggerToothAngle = 70;
if(configPage2.nCylinders == 4)
{
triggerFilterTime = (curGap * 5) >> 2 ; //87.5 degrees with a target of 110
}
else
{
triggerFilterTime = curGap >> 1 ; //35 degrees with a target of 50
}
}
else
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 110;
triggerFilterTime = (curGap >> 1); //55 degrees with a target of 70
}
else
{
triggerToothAngle = 50;
triggerFilterTime = curGap; //50 degrees with a target of 70
}
}
} }
else if (configPage4.triggerFilter == 3) else if (configPage4.triggerFilter == 3)
{ {
//Aggressive filter level //Aggressive filter level
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; triggerFilterTime = (curGap * 11) >> 3 ; } //96.26 degrees with a target of 110 if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
else { triggerToothAngle = 110; triggerFilterTime = (curGap * 9) >> 5; } //61.87 degrees with a target of 70 {
triggerToothAngle = 70;
if(configPage2.nCylinders == 4)
{
triggerFilterTime = (curGap * 11) >> 3;//96.26 degrees with a target of 110
}
else
{
triggerFilterTime = curGap >> 1 ; //35 degrees with a target of 50
}
}
else
{
if(configPage2.nCylinders == 4)
{
triggerToothAngle = 110;
triggerFilterTime = (curGap * 9) >> 5; //61.87 degrees with a target of 70
}
else
{
triggerToothAngle = 50;
triggerFilterTime = curGap; //50 degrees with a target of 70
}
}
} }
else else
{ {
//trigger filter is turned off. //trigger filter is turned off.
triggerFilterTime = 0; triggerFilterTime = 0;
if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) ) { triggerToothAngle = 70; } //96.26 degrees with a target of 110 if( (toothCurrentCount == 1) || (toothCurrentCount == 3) || (toothCurrentCount == 5) || (toothCurrentCount == 7) || (toothCurrentCount == 9) || (toothCurrentCount == 11) )
else { triggerToothAngle = 110; } //61.87 degrees with a target of 70 {
if(configPage2.nCylinders == 4) { triggerToothAngle = 70; }
else { triggerToothAngle = 70; }
}
else
{
if(configPage2.nCylinders == 4) { triggerToothAngle = 120; }
else { triggerToothAngle = 50; }
}
} }
//EXPERIMENTAL! //EXPERIMENTAL!
@ -844,9 +913,19 @@ void triggerPri_4G63()
} }
else else
{ {
if( (READ_SEC_TRIGGER() == false) && (revolutionOne == true) ) { toothCurrentCount = 1; } //Crank is low, cam is low and the crank pulse STARTED when the cam was high. Means we're at 5* BTDC if( (READ_SEC_TRIGGER() == false) && (revolutionOne == true) )
{
//Crank is low, cam is low and the crank pulse STARTED when the cam was high.
if(configPage2.nCylinders == 4) { toothCurrentCount = 1; } //Means we're at 5* BTDC on a 4G63 4 cylinder
else if(configPage2.nCylinders == 6) { toothCurrentCount = 8; }
}
//If sequential is ever enabled, the below toothCurrentCount will need to change: //If sequential is ever enabled, the below toothCurrentCount will need to change:
else if( (READ_SEC_TRIGGER() == true) && (revolutionOne == true) ) { toothCurrentCount = 1; } //Crank is low, cam is high and the crank pulse STARTED when the cam was high. Means we're at 5* BTDC. else if( (READ_SEC_TRIGGER() == true) && (revolutionOne == true) )
{
//Crank is low, cam is high and the crank pulse STARTED when the cam was high.
if(configPage2.nCylinders == 4) { toothCurrentCount = 1; } //Means we're at 5* BTDC on a 4G63 4 cylinder
else if(configPage2.nCylinders == 6) { toothCurrentCount = 2; } //Means we're at 45* ATDC on 6G72 6 cylinder
}
} }
} }
} //Filter time } //Filter time
@ -885,17 +964,29 @@ void triggerSec_4G63()
triggerFilterTime = 1500; //If this is removed, can have trouble getting sync again after the engine is turned off (but ECU not reset). triggerFilterTime = 1500; //If this is removed, can have trouble getting sync again after the engine is turned off (but ECU not reset).
triggerSecFilterTime = triggerSecFilterTime >> 1; //Divide the secondary filter time by 2 again, making it 25%. Only needed when cranking triggerSecFilterTime = triggerSecFilterTime >> 1; //Divide the secondary filter time by 2 again, making it 25%. Only needed when cranking
if(READ_PRI_TRIGGER() == true)// && (crankState == digitalRead(pinTrigger))) if(READ_PRI_TRIGGER() == true)// && (crankState == digitalRead(pinTrigger)))
{
if(configPage2.nCylinders == 4)
{ {
if(toothCurrentCount == 4) { currentStatus.hasSync = true; } if(toothCurrentCount == 4) { currentStatus.hasSync = true; }
} }
else if(configPage2.nCylinders == 6)
{
if(toothCurrentCount == 7) { currentStatus.hasSync = true; }
}
}
else else
{
if(configPage2.nCylinders == 4)
{ {
if(toothCurrentCount == 1) { currentStatus.hasSync = true; } if(toothCurrentCount == 1) { currentStatus.hasSync = true; }
} }
//Cannot gain sync for 6 cylinder here.
}
} }
//if ( (micros() - secondaryLastToothTime1) < triggerSecFilterTime_duration && configPage2.useResync ) //if ( (micros() - secondaryLastToothTime1) < triggerSecFilterTime_duration && configPage2.useResync )
if ( (configPage4.useResync == 1) && (currentStatus.hasSync == true) ) if ( (configPage4.useResync == 1) && (currentStatus.hasSync == true) && (toothCurrentCount == 4) )
{ {
triggerSecFilterTime_duration = (micros() - secondaryLastToothTime1) >> 1; triggerSecFilterTime_duration = (micros() - secondaryLastToothTime1) >> 1;
if(READ_PRI_TRIGGER() == true)// && (crankState == digitalRead(pinTrigger))) if(READ_PRI_TRIGGER() == true)// && (crankState == digitalRead(pinTrigger)))
@ -907,7 +998,6 @@ void triggerSec_4G63()
else { toothCurrentCount = 4; } //Why? Just why? else { toothCurrentCount = 4; } //Why? Just why?
} }
else { toothCurrentCount = 4; } //If the crank trigger is currently HIGH, it means we're on tooth #1 else { toothCurrentCount = 4; } //If the crank trigger is currently HIGH, it means we're on tooth #1
} }
} // Use resync } // Use resync
} //Trigger filter } //Trigger filter
@ -930,7 +1020,7 @@ uint16_t getRPM_4G63()
{ {
noInterrupts(); noInterrupts();
tempToothAngle = triggerToothAngle; tempToothAngle = triggerToothAngle;
toothTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 70 and 110 depending on the last tooth that was seen toothTime = (toothLastToothTime - toothLastMinusOneToothTime); //Note that trigger tooth angle changes between 70 and 110 depending on the last tooth that was seen (or 70/50 for 6 cylinders)
interrupts(); interrupts();
toothTime = toothTime * 36; toothTime = toothTime * 36;
tempRPM = ((unsigned long)tempToothAngle * 6000000UL) / toothTime; tempRPM = ((unsigned long)tempToothAngle * 6000000UL) / toothTime;
@ -940,7 +1030,8 @@ uint16_t getRPM_4G63()
} }
else else
{ {
tempRPM = stdGetRPM(); if(configPage2.nCylinders == 4) { tempRPM = stdGetRPM(); }
else if(configPage2.nCylinders == 6) { tempRPM = stdGetRPM(720); }
//EXPERIMENTAL! Add/subtract RPM based on the last rpmDOT calc //EXPERIMENTAL! Add/subtract RPM based on the last rpmDOT calc
//tempRPM += (micros() - toothOneTime) * currentStatus.rpmDOT //tempRPM += (micros() - toothOneTime) * currentStatus.rpmDOT
MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this MAX_STALL_TIME = revolutionTime << 1; //Set the stall time to be twice the current RPM. This is a safe figure as there should be no single revolution where this changes more than this

9
speeduino/utils.ino
View File

@ -947,17 +947,8 @@ void initialiseTriggers()
getCrankAngle = getCrankAngle_4G63; getCrankAngle = getCrankAngle_4G63;
triggerSetEndTeeth = triggerSetEndTeeth_4G63; triggerSetEndTeeth = triggerSetEndTeeth_4G63;
//These may both need to change, not sure
if(configPage4.TrigEdge == 0)
{
attachInterrupt(triggerInterrupt, trigger, CHANGE); // Attach the crank trigger wheel interrupt (Hall sensor drags to ground when triggering)
attachInterrupt(triggerInterrupt2, triggerSec_4G63, FALLING); //changed
}
else
{
attachInterrupt(triggerInterrupt, trigger, CHANGE); // Primary trigger connects to attachInterrupt(triggerInterrupt, trigger, CHANGE); // Primary trigger connects to
attachInterrupt(triggerInterrupt2, triggerSec_4G63, FALLING); attachInterrupt(triggerInterrupt2, triggerSec_4G63, FALLING);
}
break; break;
case 5: case 5: