Missed lines from last commit

speeduino/speeduino.ino

@@ -991,25 +991,72 @@ void loop()
       }
       else
       {
-        long rpm_adjust = ((long)(micros() - toothOneTime) * (long)currentStatus.rpmDOT) / 1000000; //Take into account any likely accleration that has occurred since the last full revolution completed
+        //If we can, attempt to get the timePerDegree by comparing the times of the last two teeth seen. This is only possible for evenly spaced teeth
+        if(triggerToothAngleIsCorrect == true && toothLastToothTime > toothLastMinusOneToothTime)
+        {
+          noInterrupts();
+          unsigned long tempToothLastToothTime = toothLastToothTime;
+          unsigned long tempToothLastMinusOneToothTime = toothLastMinusOneToothTime;
+          uint16_t tempTriggerToothAngle = triggerToothAngle;
+          interrupts();
+          timePerDegree = (unsigned long)(tempToothLastToothTime - tempToothLastMinusOneToothTime) / tempTriggerToothAngle;
+
+        }
+        else
+        {
+          long rpm_adjust = ((long)(micros() - toothOneTime) * (long)currentStatus.rpmDOT) / 1000000; //Take into account any likely accleration that has occurred since the last full revolution completed
+          timePerDegree = ldiv( 166666L, currentStatus.RPM + rpm_adjust).quot; //There is a small amount of rounding in this calculation, however it is less than 0.001 of a uS (Faster as ldiv than / )
+        }
 
-        //timePerDegree = DIV_ROUND_CLOSEST(166666L, (currentStatus.RPM + rpm_adjust));
-        timePerDegree = ldiv( 166666L, currentStatus.RPM + rpm_adjust).quot; //There is a small amount of rounding in this calculation, however it is less than 0.001 of a uS (Faster as ldiv than / )
       }
 
-      //Check that the duty cycle of the chosen pulsewidth isn't too high. This is disabled at cranking
+      //Check that the duty cycle of the chosen pulsewidth isn't too high.
-      if( !BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK) )
+      unsigned long pwLimit = percentage(configPage1.dutyLim, revolutionTime); //The pulsewidth limit is determined to be the duty cycle limit (Eg 85%) by the total time it takes to perform 1 revolution
+      if (CRANK_ANGLE_MAX_INJ == 720) { pwLimit = pwLimit * 2; } //For sequential, the maximum pulse time is double (2 revolutions). Wouldn't work for 2 stroke...
+      //Apply the pwLimit if staging is dsiabled and engine is not cranking
+      if( (!BIT_CHECK(currentStatus.engine, BIT_ENGINE_CRANK)) && configPage11.stagingEnabled == false) { if (currentStatus.PW1 > pwLimit) { currentStatus.PW1 = pwLimit; } }
+
+      //Calculate staging pulsewidths if used
+      if(configPage11.stagingEnabled == true)
       {
-        unsigned long pwLimit = percentage(configPage1.dutyLim, revolutionTime); //The pulsewidth limit is determined to be the duty cycle limit (Eg 85%) by the total time it takes to perform 1 revolution
+        //Scale the 'full' pulsewidth by each of the injector capacities
-        if (CRANK_ANGLE_MAX_INJ == 720) { pwLimit = pwLimit * 2; } //For sequential, the maximum pulse time is double (2 revolutions). Wouldn't work for 2 stroke...
+        uint32_t tempPW1 = ((unsigned long)currentStatus.PW1 * staged_req_fuel_mult_pri) / 100;
-        if (currentStatus.PW1 > pwLimit) { currentStatus.PW1 = pwLimit; }
-      }
 
+        if(configPage11.stagingMode == STAGING_MODE_TABLE)
+        {
+          uint32_t tempPW3 = ((unsigned long)currentStatus.PW1 * staged_req_fuel_mult_sec) / 100; //This is ONLY needed in in table mode. Auto mode only calculates the difference.
+
+          byte stagingSplit = get3DTableValue(&stagingTable, currentStatus.MAP, currentStatus.RPM);
+          currentStatus.PW1 = ((100 - stagingSplit) * tempPW1) / 100;
+
+          if(stagingSplit > 0) { currentStatus.PW3 = (stagingSplit * tempPW3) / 100; }
+          else { currentStatus.PW3 = 0; }
+        }
+        else if(configPage11.stagingMode == STAGING_MODE_AUTO)
+        {
+          currentStatus.PW1 = tempPW1;
+          //If automatic mode, the primary injectors are used all the way up to their limit (COnfigured by the pulsewidth limit setting)
+          //If they exceed their limit, the extra duty is passed to the secondaries
+          if(tempPW1 > pwLimit)
+          {
+            uint32_t extraPW = tempPW1 - pwLimit;
+            currentStatus.PW1 = pwLimit;
+            currentStatus.PW3 = ((extraPW * staged_req_fuel_mult_sec) / staged_req_fuel_mult_pri) + inj_opentime_uS; //Convert the 'left over' fuel amount from primary injector scaling to secondary
+          }
+          else { currentStatus.PW3 = 0; } //If tempPW1 < pwLImit it means that the entire fuel load can be handled by the primaries. Simply set the secondaries to 0
+        }
+
+        //currentStatus.PW3 = 2000;
+        //Set the 2nd channel of each stage with the same pulseWidth
+        currentStatus.PW2 = currentStatus.PW1;
+        currentStatus.PW4 = currentStatus.PW3;
+      }
+      //If staging is off, all the pulse widths are set the same (Sequential adjustments will be made below)
+      else { currentStatus.PW2 = currentStatus.PW3 = currentStatus.PW4 = currentStatus.PW1; } // Initial state is for all pulsewidths to be the same (This gets changed below)
 
       //***********************************************************************************************
       //BEGIN INJECTION TIMING
       //Determine next firing angles
-      currentStatus.PW2 = currentStatus.PW3 = currentStatus.PW4 = currentStatus.PW1; // Initial state is for all pulsewidths to be the same (This gets changed below)
       if(!configPage1.indInjAng) {configPage1.inj4Ang = configPage1.inj3Ang = configPage1.inj2Ang = configPage1.inj1Ang;} //Forcing all injector close angles to be the same.
       int PWdivTimerPerDegree = div(currentStatus.PW1, timePerDegree).quot; //How many crank degrees the calculated PW will take at the current speed
       injector1StartAngle = configPage1.inj1Ang - ( PWdivTimerPerDegree ); //This is a little primitive, but is based on the idea that all fuel needs to be delivered before the inlet valve opens. See http://www.extraefi.co.uk/sequential_fuel.html for more detail
@@ -1064,6 +1111,17 @@ void loop()
               if (pw4percent != 100) { currentStatus.PW4 = (pw4percent * currentStatus.PW4) / 100; }
             }
           }
+          if(configPage11.stagingEnabled == true)
+          {
+            PWdivTimerPerDegree = div(currentStatus.PW3, timePerDegree).quot; //Need to redo this for PW3 as it will be dramatically different to PW1 when staging
+            injector3StartAngle = configPage1.inj3Ang - ( PWdivTimerPerDegree ); //This is a little primitive, but is based on the idea that all fuel needs to be delivered before the inlet valve opens. See http://www.extraefi.co.uk/sequential_fuel.html for more detail
+            if(injector3StartAngle < 0) {injector3StartAngle += CRANK_ANGLE_MAX_INJ;}
+            if(injector3StartAngle > CRANK_ANGLE_MAX_INJ) {injector3StartAngle -= CRANK_ANGLE_MAX_INJ;}
+
+            injector4StartAngle = injector3StartAngle + (CRANK_ANGLE_MAX_INJ / 2);
+            if(injector4StartAngle < 0) {injector4StartAngle += CRANK_ANGLE_MAX_INJ;}
+            if(injector4StartAngle > CRANK_ANGLE_MAX_INJ) {injector4StartAngle -= CRANK_ANGLE_MAX_INJ;}
+          }
           break;
         //5 cylinders
         case 5:
@@ -1235,15 +1293,18 @@ void loop()
       int crankAngle = getCrankAngle(timePerDegree);
       if (crankAngle > CRANK_ANGLE_MAX_INJ ) { crankAngle -= 360; }
 
-      if (fuelOn && currentStatus.PW1 > 0 && !BIT_CHECK(currentStatus.status1, BIT_STATUS1_BOOSTCUT))
+      if (fuelOn && !BIT_CHECK(currentStatus.status1, BIT_STATUS1_BOOSTCUT))
       {
-        if ( (injector1StartAngle <= crankAngle) && (fuelSchedule1.Status == RUNNING) ) { injector1StartAngle += CRANK_ANGLE_MAX_INJ; }
+        if(currentStatus.PW1 >= inj_opentime_uS)
-        if (injector1StartAngle > crankAngle)
         {
-          setFuelSchedule1(
+          if ( (injector1StartAngle <= crankAngle) && (fuelSchedule1.Status == RUNNING) ) { injector1StartAngle += CRANK_ANGLE_MAX_INJ; }
-                    ((unsigned long)(injector1StartAngle - crankAngle) * (unsigned long)timePerDegree),
+          if (injector1StartAngle > crankAngle)
-                    (unsigned long)currentStatus.PW1
+          {
-                    );
+            setFuelSchedule1(
+                      ((unsigned long)(injector1StartAngle - crankAngle) * (unsigned long)timePerDegree),
+                      (unsigned long)currentStatus.PW1
+                      );
+          }
         }
 
         /*-----------------------------------------------------------------------------------------
@@ -1257,7 +1318,7 @@ void loop()
         |   This will very likely need to be rewritten when sequential is enabled
         |------------------------------------------------------------------------------------------
         */
-        if(channel2InjEnabled)
+        if( (channel2InjEnabled) && (currentStatus.PW2 >= inj_opentime_uS) )
         {
           tempCrankAngle = crankAngle - channel2InjDegrees;
           if( tempCrankAngle < 0) { tempCrankAngle += CRANK_ANGLE_MAX_INJ; }
@@ -1273,7 +1334,7 @@ void loop()
           }
         }
 
-        if(channel3InjEnabled)
+        if( (channel3InjEnabled) && (currentStatus.PW3 >= inj_opentime_uS) )
         {
           tempCrankAngle = crankAngle - channel3InjDegrees;
           if( tempCrankAngle < 0) { tempCrankAngle += CRANK_ANGLE_MAX_INJ; }
@@ -1289,7 +1350,7 @@ void loop()
           }
         }
 
-        if(channel4InjEnabled)
+        if( (channel4InjEnabled) && (currentStatus.PW4 >= inj_opentime_uS) )
         {
           tempCrankAngle = crankAngle - channel4InjDegrees;
           if( tempCrankAngle < 0) { tempCrankAngle += CRANK_ANGLE_MAX_INJ; }
@@ -1362,21 +1423,32 @@ void loop()
             unsigned long timePerDegree_1 = ldiv( 166666L, newRPM).quot;
             unsigned long timeout = (unsigned long)(ignition1StartAngle - crankAngle) * 282UL;
             */
-            setIgnitionSchedule1(ign1StartFunction,
+            if(ignitionSchedule1.Status != RUNNING)
-                      //((unsigned long)(ignition1StartAngle - crankAngle) * (unsigned long)timePerDegree),
+            {
-                      degreesToUS((ignition1StartAngle - crankAngle)),
+              setIgnitionSchedule1(ign1StartFunction,
-                      currentStatus.dwell + fixedCrankingOverride, //((unsigned long)((unsigned long)currentStatus.dwell* currentStatus.RPM) / newRPM) + fixedCrankingOverride,
+                        //((unsigned long)(ignition1StartAngle - crankAngle) * (unsigned long)timePerDegree),
-                      ign1EndFunction
+                        degreesToUS((ignition1StartAngle - crankAngle)),
-                      );
+                        currentStatus.dwell + fixedCrankingOverride, //((unsigned long)((unsigned long)currentStatus.dwell* currentStatus.RPM) / newRPM) + fixedCrankingOverride,
+                        ign1EndFunction
+                        );
+            }
         }
         /*
-        if(ignition1EndAngle > crankAngle && configPage2.StgCycles == 0)
+        if( (ignitionSchedule1.Status == RUNNING) && (ignition1EndAngle > crankAngle) && configPage2.StgCycles == 0)
+        //if( (ignitionSchedule1.Status == RUNNING) && (configPage2.StgCycles == 0 ) )
         {
-          unsigned long uSToEnd = degreesToUS( (ignition1EndAngle - crankAngle) );
+          unsigned long uSToEnd = 0;
+          //if(ignition1EndAngle > crankAngle) { uSToEnd = fastDegreesToUS( (ignition1EndAngle - crankAngle) ); }
+          //else { uSToEnd = fastDegreesToUS( (360 + ignition1EndAngle - crankAngle) ); }
+          uSToEnd = fastDegreesToUS( (ignition1EndAngle - crankAngle) );
+          //uSToEnd = ((ignition1EndAngle - crankAngle) * (toothLastToothTime - toothLastMinusOneToothTime)) / triggerToothAngle;
+
           refreshIgnitionSchedule1( uSToEnd + fixedCrankingOverride );
         }
         */
 
+
+
         tempCrankAngle = crankAngle - channel2IgnDegrees;
         if( tempCrankAngle < 0) { tempCrankAngle += CRANK_ANGLE_MAX_IGN; }
         tempStartAngle = ignition2StartAngle - channel2IgnDegrees;