Commit Graph

3125 Commits

Author SHA1 Message Date
Josh Stewart 4e8e292891 Manually set write permissions for bot on memory deltas workflow 2024-08-15 07:33:14 +10:00
Josh Stewart ec312a119d Fix issues from #634 where launch would not engage if VSS was not used.
Added default value in updates and added a new unit test for this
2024-08-14 10:50:47 +10:00
Adam Gauthier 8472f1dd1e
Launch control Vss threshold activation (#634)
* Launch control Vss threshold

Set a maximum speed which the Launch control can be activated. Prevent activating on rev matching downshift.

* Only check launch vss condition if vss is active

---------

Co-authored-by: Josh Stewart <josh@noisymime.org>
2024-08-14 08:44:16 +10:00
john1786 ab3eca0728
Fix stepper driver on open loop always remaining enabled
Also fixes #1235
2024-08-14 08:25:15 +10:00
Daniel Tobias ca16017383
Make build-test CI run on fixes branches (#1198)
* Make build-test CI run on fixes branches

* Update repository owner checks on workflows

---------

Co-authored-by: Josh Stewart <josh@noisymime.org>
2024-08-13 23:25:09 +10:00
Josh Stewart 28080df575 Move github token location in workflow 2024-08-13 23:05:41 +10:00
Josh Stewart 784cdfac62 Typo fixes 2024-08-13 17:16:33 +10:00
Daniel Tobias 6ebe0c2b4e
add codespell CI action (#1190)
* add codespell CI action

* use latest available codespell dictionaries
2024-08-13 15:28:25 +10:00
Josh Stewart 5a9835933d Add github token to workflow 2024-08-13 15:03:40 +10:00
Josh Stewart 7e635d7597
Add workflow to show memory increase/decrease on PRs (#1236)
* Initial test

* Fix syntax

* Fix platform names

* Fix platforms order

* Add sketch-paths

* Add verbose

* Disable fail fast

* Attempt compile only top level file

* Update compile-sketches action version

* Try mega2560 compile with native core

* Try blank source-url

* Change to array for platform

* Change formatting

* Last try

* Use scalar multiline strings for paltform

* Use string literals for newline

* Formatting

* Try mega2560 without library

* Add stm32f407

* Add library board property

* Fixes

* Fix mega platform

* Change Time to TimeLib

* Try different escaping

* Use individual lines for build extra-flags

* Try without escaping

* Try only single build flag

* Add 2nd -D for mega

* Add all mega build options back

* Match stm32 build option format

* Remove HWSERIAL 2 and 3 for stm32

* Lock stm32 to v2.7.1

* Enable reporting on PR

* Disable verbose

* Add workflow name

* Dummy test data to verify memory change

* Revert "Dummy test data to verify memory change"

This reverts commit e83609ec9e.

* Dummy memory increase for Teensy and stm32

* Revert "Dummy memory increase for Teensy and stm32"

This reverts commit 830b255e75.

* Only run on PRs

* Revert "Only run on PRs"

This reverts commit 24d61e5069.
2024-08-13 14:37:23 +10:00
Josh Stewart f65b0e95b3 Fix for build failing on stm32 2024-08-12 13:18:20 +10:00
Josh Stewart 8400db2f92 Cleanup warning on boostTarget constrain 2024-08-12 07:34:20 +10:00
Josh Stewart 9c7b9df1c4 Reduce serial timeout to 700ms 2024-08-12 07:25:19 +10:00
tx_haggis bea806f611
Bugfix for serial I/O hanging when the payload size is only partially sent (#1227)
* Fix for spurious serial command causing timeout
due to ill formed payload size

* DOxygen

* MISRA fixes

* Comms - minor simplification
No need to include payload size in serialBytesRxTx whilst receiving payload.
2024-08-10 08:22:51 +10:00
chaoschris 799825ff27
Update init.cpp (#1231)
fixed boost pin definition for BlitzBox pin mapping
2024-08-08 15:00:54 +10:00
Josh Stewart a9d695db45 Fix for failing builds on non-CAN platforms 2024-08-08 14:09:17 +10:00
Josh Stewart ad93a801c4 Revised CAN Broadcast system. Added Haltech dash protocol 2024-08-08 13:45:49 +10:00
tx_haggis 7c14269fc3
Tweak unit tests so they pass on Teensy 3.5 (#1233) 2024-08-02 15:51:23 +10:00
tx_haggis 96dce4429c
Unit test all corrections (#1207)
* Add unit tests for correctionCranking

* Unit test correctionASE

* Add test_maths_div10_s16_perf

* Make TPS AE tests independent

* Add test_corrections_MAE

* Use RUN_TEST_P to reduce test RAM usage

* Unit test correctionFloodClear

* Unit test battery correction

* Add unit tests for correctionLaunch

* Test repetability - initialiseAll at the start of every test

* Unit test flex & fuel temp corrections, plus minor cleanup

* Unit tests - avoid forward declarations

* Separate out populate_table() from 3D table tests

* Separate calculation of AFR target from correction (and unit test the calculation).
Separation of concerns and will make unit test AFR correction easier.

* Unit test correctionAFRClosedLoop

* Unit test correctionsFuel

* Add populate_2dtable_P test utility function

* Unit test all ignition corrections

* Add compile time buffer overflow check to RUN_TEST_P

* DFCO - test behavior not implementation

* Tweak tests to pass on Teensy 3.5

* Shrink unit test for faster build/upload/execute
We just need the 2D tables wired up, not the whole system initialized.
1. Factor out construct2dTables() from initialiseAll()
2. In the unit tests,  call construct2dTables() instead of initialiseAll()
Linker then does the heavy lifting of removing unused symbols

* Add test_correctionsDwell_uses_batvcorrection

* Use TEST_ASSERT_BIT_[HIGH_LOW] instead of TEST_ASSERT_[TRUE|FALSE]
Better failure messages, declares intent

* Igniton corrction test: expand assertions: make sure all corrections test both positive an negative advance values.

* Add AE test assertion: especially for MAE

* Add AE timeout unit tests

* Convert copy/paste 2D table construction code into shared functions

* Disbale knock unit tests until knock implementation is stable.
2024-07-30 14:35:20 +10:00
Daniel Johnson fc5397b5a7
fix: inconsistent type on revolutionTime (#1228) 2024-07-21 09:39:18 +10:00
Josh Stewart 3921610a46 Initial knock control for analog external controller input 2024-07-12 08:16:37 +10:00
Josh Stewart 003b1f0631 Initial knock control for use with external controller. Digital mode only supported 2024-07-11 16:14:09 +10:00
Josh Stewart 68d0ad33c9 Fix incorrect log variable name in ini (flexBoostCor) 2024-07-11 10:44:33 +10:00
Vitor Moreno B. Sales 6f80fb78df
Fix for #1218 and rusEFI code simplification (#1223) 2024-07-11 10:14:06 +10:00
Josh Stewart dd41d64dc6 Fix for potential double interrupt on Teensy 4.1 PIT timers 2024-07-09 12:31:31 +10:00
Josh Stewart dd9881c62d Fix for incorrect ignition pulse width with 3 and 5 cylinder engines under specific conditions
Conditions required for this bug:
Fuel set to sequential
Ignition set to single channel
Per tooth ignition timing enabled
3 or 5 Cylinders
2024-07-09 12:31:02 +10:00
Josh Stewart 1d6391a05e Prevent potential divide by 0 on init 2024-06-21 19:41:35 +10:00
tx_haggis 0f13753ed3
Performance: optimized 32-bit shifts (#1187)
* Add optimized 32-bit shifting

* Tooth based time to angle coversion is only used by a few decoders.
So move the functions into decoders.cpp

* Better separation of deocders and crank maths.

* Apply optimised shifts

* Doxygen
2024-05-30 14:12:14 +10:00
Josh Stewart 478e16cc52 Prevent flex boost adjustment being added multiple times to boost target 2024-05-29 17:45:19 +10:00
Josh Stewart aa0a7b7ab6 Fix for Flex Boost Correction variable not being set correctly 2024-05-29 16:32:25 +10:00
Josh Stewart a31e64b9df Warnings cleanup 2024-05-29 16:29:25 +10:00
tx_haggis cb78a45326
Unit Tests: provide correct filename in test messages (#1211)
* Make Unity print the correct file name - VS code output will then provide a clickable link :-)

* Provide macro to save, set & restore Unity filename
2024-05-29 15:27:50 +10:00
nickamuch 40463c51d6
Adding functionality for Honda J series crank decoder. (#1202)
Changes have been tested and are running well on a J32.

Co-authored-by: Nick Amuchastegui <nick@watttime.org>
2024-05-29 14:41:51 +10:00
tx_haggis 951f97f559
cppcheck: have to use absolute paths. (#1216) 2024-05-29 13:44:12 +10:00
Josh Stewart 0258f641ee Enable secondary trigger on non-seq missing tooth when VVT is enabled. See #1213 2024-05-29 13:28:05 +10:00
Josh Stewart bff1beca5d Record VVT angle when Poll cam method is in use. Fixes #1213 2024-05-27 09:34:00 +10:00
Vitor Moreno B. Sales 84e63d867e
Fix coil 6 declaration for STM32F407 SPECTRE board (#1215) 2024-05-27 08:15:40 +10:00
Josh Stewart 3c8726ffa0 Correct IO numbers for Teensy boards. Fixes #567 2024-05-14 12:46:15 +10:00
Josh Stewart cac1a05f97 Fix compilation for RTC_ENABLED is set but not SD_LOGGING 2024-05-11 09:07:44 +10:00
tx_haggis 5ac589752b
Provide hook for developer local PIO configuration (#1212) 2024-05-10 08:04:13 +10:00
Josh Stewart cd4a8e9640 Clear interrupt flag before enabling schedule timers on T4.1 2024-05-09 19:31:12 +10:00
Josh Stewart df78f5109c Disable the OFF Open Load pull-down current on MC33810 init 2024-04-07 15:15:35 +10:00
Josh Stewart a94b1231f3 Revert "Include current inj angle in injector timeout calculation. Fixes #1181"
This reverts commit 97b72b027e.
2024-04-05 16:31:36 +11:00
Josh Stewart 97b72b027e Include current inj angle in injector timeout calculation. Fixes #1181 2024-04-05 15:21:47 +11:00
Josh Stewart bbe7fa7f09 Correctly handle 2 stroke basic distributor setups. Fixes #1192 2024-04-03 15:37:49 +11:00
Josh Stewart e2f1c67c78 Fix regression that broke tacho sweep function. Fixes #1195 2024-04-03 14:57:47 +11:00
dependabot[bot] 0c725bc6f8
Bump actions/setup-python from 4 to 5 (#1143)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-02 10:08:30 +11:00
Josh Stewart 378200c2a7 Prevent potential fuel pump oscillation during tooth timeout period 2024-04-01 16:09:41 +11:00
Josh Stewart 9474f659b0 Disable automatic pulldown on Teensy 4.1 analog pins 2024-04-01 15:57:35 +11:00
tx_haggis 170c3a8a31
Fix compile failure (PR->master branch mismatch issue) (#1200) 2024-03-22 22:48:01 +11:00