ansible: Factor out ava-start role

Also took the opportunity to
 - break the ava command over multiple lines, for cleaner diffs
 - quote the command line parameters, to handle potential whitespace

Due to how YAML collapses whitespace, the rendered command will not
contain any newline characters.

scripts/ansible/restart_playbook.yml

@@ -13,8 +13,4 @@
     - name: ava-stop
     - name: ava-build
     - name: ava-reset
-  tasks:
-    - name: Start node
-      shell: "nohup {{ ava_binary }} --network-id={{ network_id }} --api-admin-enabled={{ api_admin_enabled }} --api-keystore-enabled={{ api_keystore_enabled }} --api-metrics-enabled={{ api_metrics_enabled }} --ava-tx-fee={{ ava_tx_fee }} --assertions-enabled={{ assertions_enabled }} --signature-verification-enabled={{ signature_verification_enabled }} --db-enabled={{ db_enabled }} --db-dir={{ db_dir }} --http-port={{ http_port }} --http-tls-enabled={{ http_tls_enabled }} --http-tls-key-file={{ http_tls_key_file }} --http-tls-cert-file={{ http_tls_cert_file }} --bootstrap-ips={{ bootstrap_ips }} --bootstrap-ids={{ bootstrap_ids }} --public-ip={{ ansible_host }} --staking-port={{ staking_port }} --staking-tls-enabled={{ staking_tls_enabled }} --staking-tls-key-file={{ staking_tls_key_file }} --staking-tls-cert-file={{ staking_tls_cert_file }} --plugin-dir={{ plugin_dir }} --log-dir={{ log_dir }} --log-level={{ log_level }} --snow-sample-size={{ snow_sample_size }} --snow-quorum-size={{ snow_quorum_size }} --snow-virtuous-commit-threshold={{ snow_virtuous_commit_threshold }} --snow-rogue-commit-threshold={{ snow_rogue_commit_threshold }} --snow-avalanche-num-parents={{ snow_avalanche_num_parents }} --snow-avalanche-batch-size={{ snow_avalanche_batch_size }} --api-ipcs-enabled={{ api_ipcs_enabled }} --xput-server-enabled={{ xput_server_enabled }} --xput-server-port={{ xput_server_port }} >/dev/null 2>&1 &"
-      environment:
-        PATH: /sbin:/usr/sbin:/bin:/usr/bin:/usr/local/bin:/snap/bin
+    - name: ava-start

scripts/ansible/roles/ava-start/tasks/main.yml

@@ -0,0 +1,38 @@
+- name: Start node
+  shell:
+    nohup {{ ava_binary }}
+      --network-id="{{ network_id }}"
+      --api-admin-enabled="{{ api_admin_enabled }}"
+      --api-keystore-enabled="{{ api_keystore_enabled }}"
+      --api-metrics-enabled="{{ api_metrics_enabled }}"
+      --ava-tx-fee="{{ ava_tx_fee }}"
+      --assertions-enabled="{{ assertions_enabled }}"
+      --signature-verification-enabled="{{ signature_verification_enabled }}"
+      --db-enabled="{{ db_enabled }}"
+      --db-dir="{{ db_dir }}"
+      --http-port="{{ http_port }}"
+      --http-tls-enabled="{{ http_tls_enabled }}"
+      --http-tls-key-file="{{ http_tls_key_file }}"
+      --http-tls-cert-file="{{ http_tls_cert_file }}"
+      --bootstrap-ips="{{ bootstrap_ips }}"
+      --bootstrap-ids="{{ bootstrap_ids }}"
+      --public-ip="{{ ansible_host }}"
+      --staking-port="{{ staking_port }}"
+      --staking-tls-enabled="{{ staking_tls_enabled }}"
+      --staking-tls-key-file="{{ staking_tls_key_file }}"
+      --staking-tls-cert-file="{{ staking_tls_cert_file }}"
+      --plugin-dir="{{ plugin_dir }}"
+      --log-dir="{{ log_dir }}"
+      --log-level="{{ log_level }}"
+      --snow-sample-size="{{ snow_sample_size }}"
+      --snow-quorum-size="{{ snow_quorum_size }}"
+      --snow-virtuous-commit-threshold="{{ snow_virtuous_commit_threshold }}"
+      --snow-rogue-commit-threshold="{{ snow_rogue_commit_threshold }}"
+      --snow-avalanche-num-parents="{{ snow_avalanche_num_parents }}"
+      --snow-avalanche-batch-size="{{ snow_avalanche_batch_size }}"
+      --api-ipcs-enabled="{{ api_ipcs_enabled }}"
+      --xput-server-enabled="{{ xput_server_enabled }}"
+      --xput-server-port="{{ xput_server_port }}"
+      >/dev/null 2>&1 &
+  environment:
+    PATH: /sbin:/usr/sbin:/bin:/usr/bin:/usr/local/bin:/snap/bin

scripts/ansible/update_playbook.yml

@@ -12,8 +12,4 @@
   roles:
     - name: ava-stop
     - name: ava-build
-  tasks:
-    - name: Start node
-      shell: "nohup {{ ava_binary }} --network-id={{ network_id }} --api-admin-enabled={{ api_admin_enabled }} --api-keystore-enabled={{ api_keystore_enabled }} --api-metrics-enabled={{ api_metrics_enabled }} --ava-tx-fee={{ ava_tx_fee }} --assertions-enabled={{ assertions_enabled }} --signature-verification-enabled={{ signature_verification_enabled }} --db-enabled={{ db_enabled }} --db-dir={{ db_dir }} --http-port={{ http_port }} --http-tls-enabled={{ http_tls_enabled }} --http-tls-key-file={{ http_tls_key_file }} --http-tls-cert-file={{ http_tls_cert_file }} --bootstrap-ips={{ bootstrap_ips }} --bootstrap-ids={{ bootstrap_ids }} --public-ip={{ ansible_host }} --staking-port={{ staking_port }} --staking-tls-enabled={{ staking_tls_enabled }} --staking-tls-key-file={{ staking_tls_key_file }} --staking-tls-cert-file={{ staking_tls_cert_file }} --plugin-dir={{ plugin_dir }} --log-dir={{ log_dir }} --log-level={{ log_level }} --snow-sample-size={{ snow_sample_size }} --snow-quorum-size={{ snow_quorum_size }} --snow-virtuous-commit-threshold={{ snow_virtuous_commit_threshold }} --snow-rogue-commit-threshold={{ snow_rogue_commit_threshold }} --snow-avalanche-num-parents={{ snow_avalanche_num_parents }} --snow-avalanche-batch-size={{ snow_avalanche_batch_size }} --api-ipcs-enabled={{ api_ipcs_enabled }} --xput-server-enabled={{ xput_server_enabled }} --xput-server-port={{ xput_server_port }} >/dev/null 2>&1 &"
-      environment:
-        PATH: /sbin:/usr/sbin:/bin:/usr/bin:/usr/local/bin:/snap/bin
+    - name: ava-start