poanetwork
/
gecko
mirror of https://github.com/poanetwork/gecko.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

prevent runtime error in user.getKey by checking for nil shortID's in request args

This commit is contained in:
bb-2 2020-05-07 08:21:45 -04:00
parent 982447e8e8
commit 41e3ccbded
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vms/platformvm/service.go
View File

@ -34,6 +34,8 @@ var (
errGetStakeSource = errors.New("couldn't get account specified in 'stakeSource'")
errNoBlockchainWithAlias = errors.New("there is no blockchain with the specified alias")
errDSCantValidate = errors.New("new blockchain can't be validated by default Subnet")
errNilSigner = errors.New("nil ShortID 'signer' is not valid")
errNilTo = errors.New("nil ShortID 'to' is not valid")
)
// Service defines the API calls that can be made to the platform chain
@ -674,6 +676,10 @@ func (service *Service) Sign(_ *http.Request, args *SignArgs, reply *SignRespons
}
user := user{db: db}
if args.Signer.IsZero() {
return errNilSigner
}
key, err := user.getKey(args.Signer) // Key of [args.Signer]
if err != nil {
return errDB
@ -882,6 +888,10 @@ func (service *Service) ImportAVA(_ *http.Request, args *ImportAVAArgs, response
}
user := user{db: db}
if args.To.IsZero() {
return errNilTo
}
kc := secp256k1fx.NewKeychain()
key, err := user.getKey(args.To)
if err != nil {