From 9feed3f61ebd3875fef8355fab9f1027989c03d6 Mon Sep 17 00:00:00 2001 From: Gustav Simonsson Date: Mon, 30 Mar 2015 15:59:14 +0200 Subject: [PATCH] Correct gas limit validation according to new algorithm * Use absolute value of (block's gas limit) - (parent's gas limit) in comparison with diff limit. * Ensure the diff is strictly smaller than the allowed size. --- core/block_processor.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/block_processor.go b/core/block_processor.go index bc3274eb5..e970ad06e 100644 --- a/core/block_processor.go +++ b/core/block_processor.go @@ -260,10 +260,13 @@ func (sm *BlockProcessor) ValidateHeader(block, parent *types.Header) error { return fmt.Errorf("Difficulty check failed for block %v, %v", block.Difficulty, expd) } + // TODO: use use minGasLimit and gasLimitBoundDivisor from + // https://github.com/ethereum/common/blob/master/params.json // block.gasLimit - parent.gasLimit <= parent.gasLimit / 1024 a := new(big.Int).Sub(block.GasLimit, parent.GasLimit) + a.Abs(a) b := new(big.Int).Div(parent.GasLimit, big.NewInt(1024)) - if a.Cmp(b) > 0 { + if !(a.Cmp(b) < 0) { return fmt.Errorf("GasLimit check failed for block %v (%v > %v)", block.GasLimit, a, b) }