From 57c911c39804ccfcf597df0acc6a03eb096d7652 Mon Sep 17 00:00:00 2001 From: Bas van Kervel Date: Tue, 23 Jun 2015 08:26:17 +0200 Subject: [PATCH] bugfix in startRPC error handling --- rpc/api/admin.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rpc/api/admin.go b/rpc/api/admin.go index 7e79fd4d0..b27482cfe 100644 --- a/rpc/api/admin.go +++ b/rpc/api/admin.go @@ -217,7 +217,6 @@ func (self *adminApi) SetSolc(req *shared.Request) (interface{}, error) { } func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) { - var err error args := new(StartRPCArgs) if err := self.coder.Decode(req.Params, &args); err != nil { return nil, shared.NewDecodeParamError(err.Error()) @@ -229,14 +228,15 @@ func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) { CorsDomain: args.CorsDomain, } - if apis, err := ParseApiString(args.Apis, self.codec, self.xeth, self.ethereum); err == nil { - err = comms.StartHttp(cfg, self.codec, Merge(apis...)) + apis, err := ParseApiString(args.Apis, self.codec, self.xeth, self.ethereum) + if err != nil { + return false, err } + err = comms.StartHttp(cfg, self.codec, Merge(apis...)) if err == nil { return true, nil } - return false, err }