reformat code with goimports

This commit is contained in:
Bas van Kervel 2015-04-09 10:26:26 +02:00
parent 5304f43067
commit 6da5b2fc5f
3 changed files with 92 additions and 92 deletions

View File

@ -1,115 +1,118 @@
package utils package utils
import ( import (
"path/filepath" "flag"
"os" "fmt"
"strings" "os"
"os/user" "os/user"
"github.com/codegangsta/cli" "path/filepath"
"flag" "strings"
"fmt"
"github.com/codegangsta/cli"
) )
// Custom type which is registered in the flags library which cli uses for // Custom type which is registered in the flags library which cli uses for
// argument parsing. This allows us to expand Value to an absolute path when // argument parsing. This allows us to expand Value to an absolute path when
// the argument is parsed // the argument is parsed
type DirectoryString struct { type DirectoryString struct {
Value string Value string
} }
func (self DirectoryString) String() string { func (self DirectoryString) String() string {
return self.Value return self.Value
} }
func (self DirectoryString) Set(value string) error { func (self DirectoryString) Set(value string) error {
self.Value = expandPath(value) self.Value = expandPath(value)
return nil return nil
} }
// Custom cli.Flag type which expand the received string to an absolute path. // Custom cli.Flag type which expand the received string to an absolute path.
// e.g. ~/.ethereum -> /home/username/.ethereum // e.g. ~/.ethereum -> /home/username/.ethereum
type DirectoryFlag struct { type DirectoryFlag struct {
cli.GenericFlag cli.GenericFlag
Name string Name string
Value DirectoryString Value DirectoryString
Usage string Usage string
EnvVar string EnvVar string
} }
func (self DirectoryFlag) String() string { func (self DirectoryFlag) String() string {
var fmtString string var fmtString string
fmtString = "%s %v\t%v" fmtString = "%s %v\t%v"
if len(self.Value.Value) > 0 { if len(self.Value.Value) > 0 {
fmtString = "%s \"%v\"\t%v" fmtString = "%s \"%v\"\t%v"
} else { } else {
fmtString = "%s %v\t%v" fmtString = "%s %v\t%v"
} }
return withEnvHint(self.EnvVar, fmt.Sprintf(fmtString, prefixedNames(self.Name), self.Value.Value, self.Usage)) return withEnvHint(self.EnvVar, fmt.Sprintf(fmtString, prefixedNames(self.Name), self.Value.Value, self.Usage))
} }
func eachName(longName string, fn func(string)) { func eachName(longName string, fn func(string)) {
parts := strings.Split(longName, ",") parts := strings.Split(longName, ",")
for _, name := range parts { for _, name := range parts {
name = strings.Trim(name, " ") name = strings.Trim(name, " ")
fn(name) fn(name)
} }
} }
// called by cli library, grabs variable from environment (if in env) // called by cli library, grabs variable from environment (if in env)
// and adds variable to flag set for parsing. // and adds variable to flag set for parsing.
func (self DirectoryFlag) Apply(set *flag.FlagSet) { func (self DirectoryFlag) Apply(set *flag.FlagSet) {
if self.EnvVar != "" { if self.EnvVar != "" {
for _, envVar := range strings.Split(self.EnvVar, ",") { for _, envVar := range strings.Split(self.EnvVar, ",") {
envVar = strings.TrimSpace(envVar) envVar = strings.TrimSpace(envVar)
if envVal := os.Getenv(envVar); envVal != "" { if envVal := os.Getenv(envVar); envVal != "" {
self.Value.Value = envVal self.Value.Value = envVal
break break
} }
} }
} }
eachName(self.Name, func(name string) { eachName(self.Name, func(name string) {
set.Var(self.Value, self.Name, "a: " + self.Usage) set.Var(self.Value, self.Name, "a: "+self.Usage)
}) })
} }
func prefixFor(name string) (prefix string) { func prefixFor(name string) (prefix string) {
if len(name) == 1 { if len(name) == 1 {
prefix = "-" prefix = "-"
} else { } else {
prefix = "--" prefix = "--"
} }
return return
} }
func prefixedNames(fullName string) (prefixed string) { func prefixedNames(fullName string) (prefixed string) {
parts := strings.Split(fullName, ",") parts := strings.Split(fullName, ",")
for i, name := range parts { for i, name := range parts {
name = strings.Trim(name, " ") name = strings.Trim(name, " ")
prefixed += prefixFor(name) + name prefixed += prefixFor(name) + name
if i < len(parts)-1 { if i < len(parts)-1 {
prefixed += ", " prefixed += ", "
} }
} }
return return
} }
func withEnvHint(envVar, str string) string { func withEnvHint(envVar, str string) string {
envText := "" envText := ""
if envVar != "" { if envVar != "" {
envText = fmt.Sprintf(" [$%s]", strings.Join(strings.Split(envVar, ","), ", $")) envText = fmt.Sprintf(" [$%s]", strings.Join(strings.Split(envVar, ","), ", $"))
} }
return str + envText return str + envText
} }
func (self DirectoryFlag) getName() string { func (self DirectoryFlag) getName() string {
return self.Name return self.Name
} }
func (self *DirectoryFlag) Set(value string) { func (self *DirectoryFlag) Set(value string) {
self.Value.Value = value self.Value.Value = value
} }
// Expands a file path // Expands a file path
@ -118,16 +121,13 @@ func (self *DirectoryFlag) Set(value string) {
// 3. cleans the path, e.g. /a/b/../c -> /a/c // 3. cleans the path, e.g. /a/b/../c -> /a/c
// Note, it has limitations, e.g. ~someuser/tmp will not be expanded // Note, it has limitations, e.g. ~someuser/tmp will not be expanded
func expandPath(p string) string { func expandPath(p string) string {
if strings.HasPrefix(p, "~/") || strings.HasPrefix(p, "~\\") { if strings.HasPrefix(p, "~/") || strings.HasPrefix(p, "~\\") {
if user, err := user.Current(); err == nil { if user, err := user.Current(); err == nil {
if err == nil { if err == nil {
p = strings.Replace(p, "~", user.HomeDir, 1) p = strings.Replace(p, "~", user.HomeDir, 1)
} }
} }
} }
return filepath.Clean(os.ExpandEnv(p)) return filepath.Clean(os.ExpandEnv(p))
} }

View File

@ -1,28 +1,28 @@
package utils package utils
import ( import (
"testing" "os"
"os" "os/user"
"os/user" "testing"
) )
func TestPathExpansion(t *testing.T) { func TestPathExpansion(t *testing.T) {
user, _ := user.Current() user, _ := user.Current()
tests := map[string]string { tests := map[string]string{
"/home/someuser/tmp": "/home/someuser/tmp", "/home/someuser/tmp": "/home/someuser/tmp",
"~/tmp": user.HomeDir + "/tmp", "~/tmp": user.HomeDir + "/tmp",
"$DDDXXX/a/b": "/tmp/a/b", "$DDDXXX/a/b": "/tmp/a/b",
"/a/b/": "/a/b", "/a/b/": "/a/b",
} }
os.Setenv("DDDXXX", "/tmp") os.Setenv("DDDXXX", "/tmp")
for test, expected := range tests { for test, expected := range tests {
got := expandPath(test) got := expandPath(test)
if got != expected { if got != expected {
t.Errorf("test %s, got %s, expected %s\n", test, got, expected) t.Errorf("test %s, got %s, expected %s\n", test, got, expected)
} }
} }
} }

View File

@ -69,7 +69,7 @@ func NewApp(version, usage string) *cli.App {
var ( var (
// General settings // General settings
DataDirFlag = DirectoryFlag{ DataDirFlag = DirectoryFlag{
Name: "datadir", Name: "datadir",
Usage: "Data directory to be used", Usage: "Data directory to be used",
Value: DirectoryString{common.DefaultDataDir()}, Value: DirectoryString{common.DefaultDataDir()},
} }