quorum

Commit Graph

Author	SHA1	Message	Date
Felix Lange	f5f042ffdc	rpc: ensure client doesn't block for slow subscribers I initially made the client block if the 100-element buffer was exceeded. It turns out that this is inconvenient for simple uses of the client which subscribe and perform calls on the same goroutine, e.g. client, _ := rpc.Dial(...) ch := make(chan int) // note: no buffer sub, _ := client.EthSubscribe(ch, "something") for event := range ch { client.Call(...) } This innocent looking code will lock up if the server suddenly decides to send 2000 notifications. In this case, the client's main loop won't accept the call because it is trying to deliver a notification to ch. The issue is kind of hard to explain in the docs and few people will actually read them. Buffering is the simple option and works with close to no overhead for subscribers that always listen.	2016-08-05 20:48:33 +02:00
Felix Lange	91b7690428	rpc: add new client, use it everywhere The new client implementation supports concurrent requests, subscriptions and replaces the various ad hoc RPC clients throughout go-ethereum.	2016-07-22 23:21:27 +02:00
Felix Lange	a40e61b4ac	rpc: remove NotifierContextKey Context keys must have a unique type in order to prevent any unintented clashes. The code used int(1) as key. Fix it by implementing the pattern recommended by package context.	2016-04-15 18:10:52 +02:00
Felix Lange	d04a2e7557	all: update license information	2016-04-15 09:48:05 +02:00
Bas van Kervel	f7328c5ecb	rpc: add pub/sub support	2016-04-01 18:26:35 +02:00

5 Commits