quorum/light
Felix Lange 5f7826270c all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more

name              old time/op    new time/op    delta
PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)

name              old alloc/op   new alloc/op   delta
PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)

* all: unify big.Int zero checks

Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.

eg templates:

    func before(x *big.Int) bool { return x.BitLen() == 0 }
    func after(x *big.Int) bool  { return x.Sign() == 0 }

    func before(x *big.Int) bool { return x.BitLen() > 0 }
    func after(x *big.Int) bool  { return x.Sign() != 0 }

    func before(x *big.Int) int { return x.Cmp(common.Big0) }
    func after(x *big.Int) int  { return x.Sign() }

* common/math, crypto/secp256k1: make ReadBits public in package math
2017-02-28 15:09:11 +01:00
..
lightchain.go all: blidly swap out glog to our log15, logs need rework 2017-02-23 12:16:44 +02:00
lightchain_test.go core, core/state, trie: EIP158, reprice & skip empty account write 2016-11-13 10:44:04 +01:00
odr.go les, light: add block availability check for ODR requests 2016-12-10 09:53:25 +01:00
odr_test.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
odr_util.go all: blidly swap out glog to our log15, logs need rework 2017-02-23 12:16:44 +02:00
state.go all: blidly swap out glog to our log15, logs need rework 2017-02-23 12:16:44 +02:00
state_object.go all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
state_test.go core, core/state, trie: EIP158, reprice & skip empty account write 2016-11-13 10:44:04 +01:00
trie.go light: light chain, VM env and tx pool 2016-11-09 02:12:53 +01:00
txpool.go all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
txpool_test.go params: core, core/vm, miner: 64bit gas instructions 2017-02-13 21:44:25 +01:00
vm_env.go core, core/state, core/vm: remove exported account getters (#3618) 2017-02-22 23:29:59 +01:00