poanetwork
/
tokenbridge-contracts
mirror of https://github.com/poanetwork/tokenbridge-contracts.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Audit feedback: 

remove unneccesary check and add check for Ownable
This commit is contained in:
Roman Storm 2018-04-13 14:10:22 -07:00
parent 3a4c663d84
commit bcd608479f
3 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contracts/upgradeable_contracts/Ownable.sol
View File

@ -46,6 +46,7 @@ contract Ownable is EternalStorage {
* @dev Sets a new owner address
*/
function setOwner(address newOwner) internal {
require(newOwner != address(0));
OwnershipTransferred(owner(), newOwner);
addressStorage[keccak256("owner")] = newOwner;
}

1
contracts/upgradeable_contracts/U_BridgeValidators.sol
View File

@ -17,7 +17,6 @@ contract BridgeValidators is IBridgeValidators, EternalStorage, Ownable {
require(_requiredSignatures != 0);
require(_initialValidators.length >= _requiredSignatures);
for (uint i = 0; i < _initialValidators.length; i++) {
require(!isValidator(_initialValidators[i]) && _initialValidators[i] != address(0));
addValidator(_initialValidators[i]);
}
setRequiredSignatures(_requiredSignatures);

2
flats/BridgeValidators_flat.sol
View File

@ -122,6 +122,7 @@ contract Ownable is EternalStorage {
* @dev Sets a new owner address
*/
function setOwner(address newOwner) internal {
require(newOwner != address(0));
OwnershipTransferred(owner(), newOwner);
addressStorage[keccak256("owner")] = newOwner;
}
@ -140,7 +141,6 @@ contract BridgeValidators is IBridgeValidators, EternalStorage, Ownable {
require(_requiredSignatures != 0);
require(_initialValidators.length >= _requiredSignatures);
for (uint i = 0; i < _initialValidators.length; i++) {
require(!isValidator(_initialValidators[i]) && _initialValidators[i] != address(0));
addValidator(_initialValidators[i]);
}
setRequiredSignatures(_requiredSignatures);