From ad580f5b2ffe16e17af84b281bcc21484a63c6ba Mon Sep 17 00:00:00 2001 From: Alex Lewontin Date: Tue, 15 Dec 2020 21:58:33 -0500 Subject: [PATCH] NUC123 USB driver: fix off-by-one error when copying unaligned memory to/from USB SRAM buffer --- os/hal/ports/NUMICRO/LLD/USBv1/usb_memcpy.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/hal/ports/NUMICRO/LLD/USBv1/usb_memcpy.S b/os/hal/ports/NUMICRO/LLD/USBv1/usb_memcpy.S index 90a6126e..c010175d 100644 --- a/os/hal/ports/NUMICRO/LLD/USBv1/usb_memcpy.S +++ b/os/hal/ports/NUMICRO/LLD/USBv1/usb_memcpy.S @@ -148,9 +148,9 @@ unaligned: str r5, [r4, #16] unaligned_loop_top: + subs r2, r2, #1 ldrb r5, [r1, r2] strb r5, [r0, r2] - subs r2, r2, #1 unaligned_loop_check: bne.n unaligned_loop_top