From 6d164f0f7e91d392ecad7c979dec73908a4fbe41 Mon Sep 17 00:00:00 2001 From: kascade Date: Fri, 20 Apr 2007 00:29:01 +0000 Subject: [PATCH] updated ramtune test app git-svn-id: http://svn.3splooges.com/romraider-arch/trunk@642 d2e2e1cd-ba16-0410-be16-b7c4453c7c2d --- .../generator/AbstractCommandGenerator.java | 15 +++++++++++++++ .../generator/EcuInitCommandGenerator.java | 9 +++------ .../command/generator/ReadCommandGenerator.java | 7 ++----- .../command/generator/WriteCommandGenerator.java | 7 ++----- 4 files changed, 22 insertions(+), 16 deletions(-) create mode 100644 src/enginuity/ramtune/test/command/generator/AbstractCommandGenerator.java diff --git a/src/enginuity/ramtune/test/command/generator/AbstractCommandGenerator.java b/src/enginuity/ramtune/test/command/generator/AbstractCommandGenerator.java new file mode 100644 index 00000000..2c2ca3ca --- /dev/null +++ b/src/enginuity/ramtune/test/command/generator/AbstractCommandGenerator.java @@ -0,0 +1,15 @@ +package enginuity.ramtune.test.command.generator; + +import enginuity.io.protocol.Protocol; +import static enginuity.util.ParamChecker.checkNotNull; + +public abstract class AbstractCommandGenerator implements CommandGenerator { + protected final Protocol protocol; + + public AbstractCommandGenerator(Protocol protocol) { + checkNotNull(protocol, "protocol"); + this.protocol = protocol; + } + + public abstract String toString(); +} diff --git a/src/enginuity/ramtune/test/command/generator/EcuInitCommandGenerator.java b/src/enginuity/ramtune/test/command/generator/EcuInitCommandGenerator.java index 09bba144..a15aaec2 100644 --- a/src/enginuity/ramtune/test/command/generator/EcuInitCommandGenerator.java +++ b/src/enginuity/ramtune/test/command/generator/EcuInitCommandGenerator.java @@ -3,14 +3,11 @@ package enginuity.ramtune.test.command.generator; import enginuity.io.protocol.Protocol; import enginuity.ramtune.test.command.Command; import enginuity.ramtune.test.command.CommandImpl; -import static enginuity.util.ParamChecker.checkNotNull; - -public final class EcuInitCommandGenerator implements CommandGenerator { - private final Protocol protocol; +public final class EcuInitCommandGenerator extends AbstractCommandGenerator { + public EcuInitCommandGenerator(Protocol protocol) { - checkNotNull(protocol, "protocol"); - this.protocol = protocol; + super(protocol); } public Command createCommand(byte[] address, byte[] data) { diff --git a/src/enginuity/ramtune/test/command/generator/ReadCommandGenerator.java b/src/enginuity/ramtune/test/command/generator/ReadCommandGenerator.java index 3d97d70a..cf4058ad 100644 --- a/src/enginuity/ramtune/test/command/generator/ReadCommandGenerator.java +++ b/src/enginuity/ramtune/test/command/generator/ReadCommandGenerator.java @@ -3,15 +3,12 @@ package enginuity.ramtune.test.command.generator; import enginuity.io.protocol.Protocol; import enginuity.ramtune.test.command.Command; import enginuity.ramtune.test.command.CommandImpl; -import static enginuity.util.ParamChecker.checkNotNull; import static enginuity.util.ParamChecker.checkNotNullOrEmpty; -public final class ReadCommandGenerator implements CommandGenerator { - private final Protocol protocol; +public final class ReadCommandGenerator extends AbstractCommandGenerator { public ReadCommandGenerator(Protocol protocol) { - checkNotNull(protocol, "protocol"); - this.protocol = protocol; + super(protocol); } public Command createCommand(byte[] address, byte[] data) { diff --git a/src/enginuity/ramtune/test/command/generator/WriteCommandGenerator.java b/src/enginuity/ramtune/test/command/generator/WriteCommandGenerator.java index b987acb2..5b9a9566 100644 --- a/src/enginuity/ramtune/test/command/generator/WriteCommandGenerator.java +++ b/src/enginuity/ramtune/test/command/generator/WriteCommandGenerator.java @@ -3,15 +3,12 @@ package enginuity.ramtune.test.command.generator; import enginuity.io.protocol.Protocol; import enginuity.ramtune.test.command.Command; import enginuity.ramtune.test.command.CommandImpl; -import static enginuity.util.ParamChecker.checkNotNull; import static enginuity.util.ParamChecker.checkNotNullOrEmpty; -public final class WriteCommandGenerator implements CommandGenerator { - private final Protocol protocol; +public final class WriteCommandGenerator extends AbstractCommandGenerator { public WriteCommandGenerator(Protocol protocol) { - checkNotNull(protocol, "protocol"); - this.protocol = protocol; + super(protocol); } public Command createCommand(byte[] address, byte[] data) {