mirror of https://github.com/rusefi/RomRaider.git
Type checking some HashTables, Enumerations, Vectors
Last (this time for sure!) of the setSerialVersionUID additions for serializable classes git-svn-id: https://svn2.assembla.com/svn/romraider/trunk@207 38686702-15cf-42e4-a595-3071df8bf5ea
This commit is contained in:
parent
82a015e13b
commit
b02a276011
|
@ -70,7 +70,9 @@ import java.io.IOException;
|
||||||
import java.util.Vector;
|
import java.util.Vector;
|
||||||
|
|
||||||
public class ECUEditor extends JFrame implements WindowListener, PropertyChangeListener {
|
public class ECUEditor extends JFrame implements WindowListener, PropertyChangeListener {
|
||||||
private String titleText = PRODUCT_NAME + " v" + VERSION + " | ECU Editor";
|
private static final long serialVersionUID = -7826850987392016292L;
|
||||||
|
|
||||||
|
private String titleText = PRODUCT_NAME + " v" + VERSION + " | ECU Editor";
|
||||||
|
|
||||||
private static final String NEW_LINE = System.getProperty("line.separator");
|
private static final String NEW_LINE = System.getProperty("line.separator");
|
||||||
private final SettingsManager settingsManager = new SettingsManagerImpl();
|
private final SettingsManager settingsManager = new SettingsManagerImpl();
|
||||||
|
|
|
@ -41,7 +41,6 @@ import java.io.IOException;
|
||||||
import java.io.InputStream;
|
import java.io.InputStream;
|
||||||
import java.io.OutputStream;
|
import java.io.OutputStream;
|
||||||
|
|
||||||
@SuppressWarnings({"ResultOfMethodCallIgnored"})
|
|
||||||
public final class SerialConnectionImpl implements SerialConnection {
|
public final class SerialConnectionImpl implements SerialConnection {
|
||||||
private static final Logger LOGGER = getLogger(SerialConnectionImpl.class);
|
private static final Logger LOGGER = getLogger(SerialConnectionImpl.class);
|
||||||
private final SerialPort serialPort;
|
private final SerialPort serialPort;
|
||||||
|
|
|
@ -47,7 +47,6 @@ import static org.apache.log4j.Logger.getLogger;
|
||||||
import static java.lang.System.currentTimeMillis;
|
import static java.lang.System.currentTimeMillis;
|
||||||
import java.util.Random;
|
import java.util.Random;
|
||||||
|
|
||||||
@SuppressWarnings({"PointlessArithmeticExpression"})
|
|
||||||
final class TestSerialConnection implements SerialConnection {
|
final class TestSerialConnection implements SerialConnection {
|
||||||
private static final Logger LOGGER = getLogger(TestSerialConnection.class);
|
private static final Logger LOGGER = getLogger(TestSerialConnection.class);
|
||||||
private static final Random RANDOM = new Random(currentTimeMillis());
|
private static final Random RANDOM = new Random(currentTimeMillis());
|
||||||
|
|
|
@ -53,7 +53,6 @@ public final class SSMLoggerProtocol implements LoggerProtocol {
|
||||||
return protocol.constructReadAddressRequest(convertToByteAddresses(filteredQueries));
|
return protocol.constructReadAddressRequest(convertToByteAddresses(filteredQueries));
|
||||||
}
|
}
|
||||||
|
|
||||||
@SuppressWarnings({"PointlessArithmeticExpression"})
|
|
||||||
public byte[] constructReadAddressResponse(Collection<EcuQuery> queries) {
|
public byte[] constructReadAddressResponse(Collection<EcuQuery> queries) {
|
||||||
checkNotNullOrEmpty(queries, "queries");
|
checkNotNullOrEmpty(queries, "queries");
|
||||||
// 0x80 0xF0 0x10 data_length 0xE8 value1 value2 ... valueN checksum
|
// 0x80 0xF0 0x10 data_length 0xE8 value1 value2 ... valueN checksum
|
||||||
|
@ -83,7 +82,6 @@ public final class SSMLoggerProtocol implements LoggerProtocol {
|
||||||
}
|
}
|
||||||
|
|
||||||
// processes the response bytes and sets individual responses on corresponding query objects
|
// processes the response bytes and sets individual responses on corresponding query objects
|
||||||
@SuppressWarnings({"PointlessArithmeticExpression"})
|
|
||||||
public void processReadAddressResponses(Collection<EcuQuery> queries, byte[] response) {
|
public void processReadAddressResponses(Collection<EcuQuery> queries, byte[] response) {
|
||||||
checkNotNullOrEmpty(queries, "queries");
|
checkNotNullOrEmpty(queries, "queries");
|
||||||
checkNotNullOrEmpty(response, "response");
|
checkNotNullOrEmpty(response, "response");
|
||||||
|
|
|
@ -47,7 +47,7 @@ public final class XYTrendline extends AbstractXYDataset {
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
public Comparable getSeriesKey(int seriesIndex) {
|
public Comparable<String> getSeriesKey(int seriesIndex) {
|
||||||
return "foo";
|
return "foo";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -35,7 +35,8 @@ import static java.awt.BorderLayout.WEST;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
|
|
||||||
public final class MafTabImpl extends JPanel implements MafTab {
|
public final class MafTabImpl extends JPanel implements MafTab {
|
||||||
private final LoggerChartPanel chartPanel = new LoggerChartPanel("MAF (v)", "Total Correction (%)");
|
private static final long serialVersionUID = -6978027421649432740L;
|
||||||
|
private final LoggerChartPanel chartPanel = new LoggerChartPanel("MAF (v)", "Total Correction (%)");
|
||||||
private final MafControlPanel controlPanel;
|
private final MafControlPanel controlPanel;
|
||||||
|
|
||||||
public MafTabImpl(DataRegistrationBroker broker, ECUEditor ecuEditor) {
|
public MafTabImpl(DataRegistrationBroker broker, ECUEditor ecuEditor) {
|
||||||
|
|
|
@ -286,7 +286,7 @@ public class TableToolBar extends JToolBar implements MouseListener, ItemListene
|
||||||
int valueCount = 0;
|
int valueCount = 0;
|
||||||
|
|
||||||
//Pull data into format 3d graph understands
|
//Pull data into format 3d graph understands
|
||||||
Vector graphValues = new Vector();
|
Vector<float[]> graphValues = new Vector<float[]>();
|
||||||
if (table.getType() == Table.TABLE_3D) {
|
if (table.getType() == Table.TABLE_3D) {
|
||||||
Table3D table3d = (Table3D) table;
|
Table3D table3d = (Table3D) table;
|
||||||
DataCell[][] tableData = table3d.get3dData();
|
DataCell[][] tableData = table3d.get3dData();
|
||||||
|
|
|
@ -74,12 +74,12 @@ public class XMLFilter extends FileFilter {
|
||||||
fullDescription = description == null ? "(" : description
|
fullDescription = description == null ? "(" : description
|
||||||
+ " (";
|
+ " (";
|
||||||
// build the description from the extension list
|
// build the description from the extension list
|
||||||
Enumeration extensions = filters.keys();
|
Enumeration<String> extensions = filters.keys();
|
||||||
if (extensions != null) {
|
if (extensions != null) {
|
||||||
fullDescription += "." + (String) extensions.nextElement();
|
fullDescription += "." + extensions.nextElement();
|
||||||
while (extensions.hasMoreElements()) {
|
while (extensions.hasMoreElements()) {
|
||||||
fullDescription += ", ."
|
fullDescription += ", ."
|
||||||
+ (String) extensions.nextElement();
|
+ extensions.nextElement();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
fullDescription += ")";
|
fullDescription += ")";
|
||||||
|
|
Loading…
Reference in New Issue