rusefi
/
atbetaflight
mirror of https://github.com/rusefi/atbetaflight.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7312 from mikeller/amend_parentheses_rule 

Amended rule to stipulate minimal use of parentheses.
This commit is contained in:
Michael Keller 2019-01-12 19:22:55 +13:00 committed by GitHub
parent 9b43b30b48 af0a3ad58b
commit 10ae62efed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/development/CodingStyle.md
View File

@ -280,9 +280,15 @@ Same for multiple `return` from a function and multiple `break` inside a `case`.
In general, they reduce readability and maintainability. In general, they reduce readability and maintainability.
In rare cases such constructs can be justified but only when you have considered and understood the alternatives and still have a strong reason. In rare cases such constructs can be justified but only when you have considered and understood the alternatives and still have a strong reason.
Use parentheses around each group in logical and mathematical statements, In expressions, parentheses should only be used where they are required, i.e. where operator precedence will not evaluate in the right order, or where a compiler warning is triggered without parentheses. This brings all expressions into a canonical form, and avoids the problem of different developers having different ideas of what 'easy to read' expressions are.
rather than relying on the implicit logic and operator priority.
The compiler knows what it’s doing but it should be easy for people too. One exception to this rule is the ternary conditional operator
```
pidStabilisationEnabled = (pidControllerState == PID_STABILISATION_ON) ? true : false
```
Here, the condition shall be enclosed in braces, to make the ternary operator easier to spot when reading left to right.
# Includes # Includes