From 1bd091a031871d3d742c4e123630321d13d553d4 Mon Sep 17 00:00:00 2001
From: Nicholas Sherlock <n.sherlock@gmail.com>
Date: Tue, 17 Feb 2015 22:50:10 +1300
Subject: [PATCH] Avoid reading uninitialised memory during battery unit tests

---
 src/test/unit/battery_unittest.cc | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/test/unit/battery_unittest.cc b/src/test/unit/battery_unittest.cc
index 52bd836d1..2a6701743 100644
--- a/src/test/unit/battery_unittest.cc
+++ b/src/test/unit/battery_unittest.cc
@@ -39,6 +39,14 @@ TEST(BatteryTest, BatteryADCToVoltage)
 
     batteryConfig_t batteryConfig;
 
+    // batteryInit() reads a bunch of fields including vbatscale, so set up the config with useful initial values:
+    memset(&batteryConfig, 0, sizeof(batteryConfig));
+
+    batteryConfig.vbatmaxcellvoltage = 43;
+    batteryConfig.vbatmincellvoltage = 33;
+    batteryConfig.vbatwarningcellvoltage = 35;
+    batteryConfig.vbatscale = VBAT_SCALE_DEFAULT;
+
     batteryInit(&batteryConfig);
 
     batteryAdcToVoltageExpectation_t batteryAdcToVoltageExpectations[] = {