rusefi
/
atbetaflight
mirror of https://github.com/rusefi/atbetaflight.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improved CLI error messages.

This commit is contained in:
mikeller 2020-03-17 22:05:57 +13:00
parent 9c3d4603b7
commit d2605975a1
2 changed files with 290 additions and 264 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

541
src/main/cli/cli.c
View File

File diff suppressed because it is too large Load Diff

13
src/test/unit/cli_unittest.cc
View File

@ -53,8 +53,7 @@ extern "C" {
#include "scheduler/scheduler.h" #include "scheduler/scheduler.h"
#include "sensors/battery.h" #include "sensors/battery.h"
void cliSet(char *cmdline); void cliSet(const char *cmdName, char *cmdline);
void cliGet(char *cmdline);
int cliGetSettingIndex(char *name, uint8_t length); int cliGetSettingIndex(char *name, uint8_t length);
void *cliGetValuePointer(const clivalue_t *value); void *cliGetValuePointer(const clivalue_t *value);
@ -96,7 +95,7 @@ extern "C" {
TEST(CLIUnittest, TestCliSetArray) TEST(CLIUnittest, TestCliSetArray)
{ {
char *str = (char *)"array_unit_test = 123, -3 , 1"; char *str = (char *)"array_unit_test = 123, -3 , 1";
cliSet(str); cliSet("", str);
const uint16_t index = cliGetSettingIndex(str, 15); const uint16_t index = cliGetSettingIndex(str, 15);
EXPECT_LT(index, valueTableEntryCount); EXPECT_LT(index, valueTableEntryCount);
@ -119,7 +118,7 @@ TEST(CLIUnittest, TestCliSetArray)
TEST(CLIUnittest, TestCliSetStringNoFlags) TEST(CLIUnittest, TestCliSetStringNoFlags)
{ {
char *str = (char *)"str_unit_test = SAMPLE"; char *str = (char *)"str_unit_test = SAMPLE";
cliSet(str); cliSet("", str);
const uint16_t index = cliGetSettingIndex(str, 13); const uint16_t index = cliGetSettingIndex(str, 13);
EXPECT_LT(index, valueTableEntryCount); EXPECT_LT(index, valueTableEntryCount);
@ -147,7 +146,7 @@ TEST(CLIUnittest, TestCliSetStringWriteOnce)
{ {
char *str1 = (char *)"wos_unit_test = SAMPLE"; char *str1 = (char *)"wos_unit_test = SAMPLE";
char *str2 = (char *)"wos_unit_test = ELPMAS"; char *str2 = (char *)"wos_unit_test = ELPMAS";
cliSet(str1); cliSet("", str1);
const uint16_t index = cliGetSettingIndex(str1, 13); const uint16_t index = cliGetSettingIndex(str1, 13);
EXPECT_LT(index, valueTableEntryCount); EXPECT_LT(index, valueTableEntryCount);
@ -169,7 +168,7 @@ TEST(CLIUnittest, TestCliSetStringWriteOnce)
EXPECT_EQ('E', data[5]); EXPECT_EQ('E', data[5]);
EXPECT_EQ(0, data[6]); EXPECT_EQ(0, data[6]);
cliSet(str2); cliSet("", str2);
EXPECT_EQ('S', data[0]); EXPECT_EQ('S', data[0]);
EXPECT_EQ('A', data[1]); EXPECT_EQ('A', data[1]);
@ -179,7 +178,7 @@ TEST(CLIUnittest, TestCliSetStringWriteOnce)
EXPECT_EQ('E', data[5]); EXPECT_EQ('E', data[5]);
EXPECT_EQ(0, data[6]); EXPECT_EQ(0, data[6]);
cliSet(str1); cliSet("", str1);
EXPECT_EQ('S', data[0]); EXPECT_EQ('S', data[0]);
EXPECT_EQ('A', data[1]); EXPECT_EQ('A', data[1]);